Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4661999rwl; Tue, 28 Mar 2023 09:34:41 -0700 (PDT) X-Google-Smtp-Source: AKy350bOMMI0rjJdPj6pjWCkynjZQ94WljVylWXLUtkJfA6857JRd9iuN3X36qUZaGRZJv1nI3Sn X-Received: by 2002:aa7:c847:0:b0:501:bf46:a78d with SMTP id g7-20020aa7c847000000b00501bf46a78dmr14212640edt.36.1680021280829; Tue, 28 Mar 2023 09:34:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680021280; cv=none; d=google.com; s=arc-20160816; b=x/FEAvM1ue9XArtrYgv5XWEO8W6EI4H7C+Oj/5Vwf11dgokitLryC1ow0TWF1cgUZi zVusCSI+FqH7sxiFoxIHhMollchKBjx1yJGeLuf7Ymf6eoJTHhcrUhpWrtgNc/fJyX4Y 0dGEgp0t1ScE9HU0GU+wxCVZtDPPX4QTO/QPd0m9MwUrUUveZCdWdGtyzi9qaLAmFd4z t88Y4OP3qNHoDKRmLLY59tH6hAeqr2dCicCtnbK+ONKz6uIpqx21AM4Ax90y2vdUxy30 B7/4GRV48z9nG/pLPftKCkwgcK7cB6p2kG20Ny+QsBWNGnMcUf4UiBwrZkzIMyN2P85h yoDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EgGshohoJeLg0j9pbNhdz9Ca2WHh3ZNTK0xVCG/aUWs=; b=SX95UzDY8GDuBuDAgUvU/JfiSuaAGf8mfy8wCTjW6oXQhBO83xUIHAMGMOaHpIo9nh Pj2FP44RkFSw0HSdlmjoVckQ0A9HC+ddumx9yBthc/5EeeFvrOtQgakhfUevvWDssyo3 2Hudr4ImzMYFnbRI70n836BtE98APpYz3FyqvjMMIMYfalI+DarBJr+C3PD34JT7kNm3 kqspRQ6m5ZyKBpQJ40vx8pNzCImYYBntiZT6Q42m6tFcQoYahZ6KFkGutituKcBcAnU8 V1e4aYKKSGyTMNZk4TpqDoye6VxtZjfdI0SMPpCdpT2UNjYwpViabbhCgwvy059nLjaX VHEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s10-20020a056402164a00b005004ce1b26fsi17011813edx.593.2023.03.28.09.34.11; Tue, 28 Mar 2023 09:34:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233098AbjC1QTK (ORCPT + 99 others); Tue, 28 Mar 2023 12:19:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232787AbjC1QTI (ORCPT ); Tue, 28 Mar 2023 12:19:08 -0400 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7BBA4DBF2 for ; Tue, 28 Mar 2023 09:19:06 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 32SGIxo9009627; Tue, 28 Mar 2023 18:18:59 +0200 From: Willy Tarreau To: "Paul E. McKenney" Cc: linux@weissschuh.net, linux-kernel@vger.kernel.org, Alexey Dobriyan , Willy Tarreau Subject: [PATCH 0/1] tools/nolibc: tests: use volatile to force stack smashing Date: Tue, 28 Mar 2023 18:18:44 +0200 Message-Id: <20230328161845.9584-1-w@1wt.eu> X-Mailer: git-send-email 2.17.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Paul, as previously discussed after Alexey's report, Thomas updated his stack smashing code to use a volatile pointer instead of dropping compiler optimizations. It's both cleaner and safer this way. I verified on all supported archs that it doesn't change the behavior and passes the test without issues, so I'm fine with it: 125 test(s) passed. It can be queued on top of the existing series either for the next merge or the one after at your convenience, as I know that you're running long and complete tests with your series, and I don't want to make you change your tests at the last minute. This one is not urgent at all, it's more of a maintenance improvement anyway. Thank you! Willy Thomas Weißschuh (1): tools/nolibc: tests: use volatile to force stack smashing tools/testing/selftests/nolibc/nolibc-test.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.17.5