Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9baff4c3-31ff-c19c-01fb-f438797da9ea@nvidia.com>
Date:   Tue, 28 Mar 2023 18:02:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2] PCI: Assign PCI domain by ida_alloc()
Content-Language: en-US
To:     Rob Herring <robh+dt@kernel.org>
Cc:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Andrew Lunn <andrew@lunn.ch>,
        =?UTF-8?Q?Marek_Beh=c3=ban?= <marek.behun@nic.cz>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <20220702204737.7719-1-pali@kernel.org>
 <20220714184130.5436-1-pali@kernel.org>
 <b529cb69-0602-9eed-fc02-2f068707a006@nvidia.com>
 <20230320205936.wd6pj3trljsduj5c@pali>
 <993ca7dc-1d39-6ae9-1033-838d81aeb076@nvidia.com>
 <3414723d-7d79-809f-e63f-35243d945b50@nvidia.com>
 <CAL_JsqJ+3j60WK0HSr0rFQYwPkMbs=ZW=mifd7ggeNQA8+iuaA@mail.gmail.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <CAL_JsqJ+3j60WK0HSr0rFQYwPkMbs=ZW=mifd7ggeNQA8+iuaA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVVxam9STWJZYVZReE91NzIvWllibUxlSjdTd0ppZXBNK0NoVGVkM3RrTVho?=
 =?utf-8?B?ZGtldGxoQkQ5Nko4eG9Tc0RDMEZmYTRpckswWnZKZFRZbWVMYk9ITnFPNkI5?=
 =?utf-8?B?eHdYZC83Z1JsbWdMRVUvaEh2K1VuZGdrek10R3cvK0c0dmpCZzZld0dsaW5K?=
 =?utf-8?B?UmFBcFFsUEt4UFBoalBWbDlIbFB3K3JMeXdvSlhRNVVKQzhldjdsT256bGFs?=
 =?utf-8?B?cVhhYURsdGpobFNRR0F4Y2d6bm1EdzBwYmdwSVNaclpkVitpU0tnV3Nmb3Zt?=
 =?utf-8?B?dmJTSFZZQUx1QlU3OEZvYVdHME1XVXptcHpLcW5VczJtbEwrc2FSRVc1NDE1?=
 =?utf-8?B?cW9mRGhyWTVHVXY4TEVTZHZ3SXVuN3dRRFJtTTBYZ1BRa0REUGl4dTdSSjFv?=
 =?utf-8?B?dXVqYTJLNmZmMEtQRjJJVjFCcjZkVlJHTzBBYWtDZXg4ekpHZHFnTlNpeU5Z?=
 =?utf-8?B?bGhJRjE1cTdTUkJPTG9yT1RmM2I2cGhHemlaZjBRMmNNWFhmZ1RTM2htWHQ4?=
 =?utf-8?B?WkdRRFVMVHg5d291OHlYYmkweHJXL3BNakNlQmJ6RlhPQjlIUnJ1a3J2S3l4?=
 =?utf-8?B?ek9hSm9ickNhbnVqWm4wcUpaNlNSQmFDQWV3RmRoVEEzek1uWlk0SHpFUEgx?=
 =?utf-8?B?RTFvMjdlUTRXS0NHcnN6MS9mbkt5QTJVeTVYU3FGaVNCZit6cFRpN1NHRG9u?=
 =?utf-8?B?QlQ1RWtUb01kQ0dUUlhyTkVabHpRZzY3TXdvdXJYM3NrOSt2WStrcHkrVmJk?=
 =?utf-8?B?NVBUaFdxaDVUYjJRbDR2Y2gybnlXYzFDQU5HSlBkZDdqTi9uV0Z4WVFNTWVV?=
 =?utf-8?B?aTZBUzlycGZDYmtKZnZDK1lWRG5pMnkrbEZpNm9OaWdhK1NtNUQzdlR4NEhS?=
 =?utf-8?B?VHFoMDRGWW5FSzIwb2cyRUlvaFgyQTRqcHJ4M0hWZEljaVdVdXMxWW1yUXBi?=
 =?utf-8?B?U3JNRUFkZEdFUktYcmNTZWt5MG9ocFFOV0tRVFp5S2xCTjFWZGZTMmN1R2JU?=
 =?utf-8?B?MmVUSEtNNEt4ZlVJc0kvRDRrM21haGtYbGtRS3JEY0k3R21ZYk0zWlFMeXJo?=
 =?utf-8?B?Ujc3THQ1dlUzM2JkbnJ4RGFCeWlrVUVZUzBlcnFaYkN1Wi9qUUJzbXpXVGlC?=
 =?utf-8?B?aDRVcE5Ma1RGbjVXTDMrbjhZTHFGRENTRmNPY2Rxa0l0SDI5QXNqWFRxQVVm?=
 =?utf-8?B?cldHdjExTytwTy9iY2k4R29BQTcwMDZjOEZ3RWw2b242a1E0aSt2T2hXc0Z3?=
 =?utf-8?B?UXhPTUplU1I0RVp4TFlBTWxITFoyT2VGOGlEMnA5Wm1nTkxFMFc3NVh0VkJt?=
 =?utf-8?B?TEg0RllEUE5OQXlaV0FkYnR3OFM1dHFDRUVsbnYrWWdNMG5oanFYQ3lORkZE?=
 =?utf-8?B?clVmaUdsNzZBdktKc3NjRndrMkRoenc1dlVtSjBxL2tkTUNRU3djeVozbzB4?=
 =?utf-8?B?YXVNMmtOYU1ZR3ZEbjRycStNTEVqSXBkNjBxMEY0RlJBcm9NdWk3KzFVTy9t?=
 =?utf-8?B?S3ZwdDJKL0dzQzhlS3lsZXArWkkyS2ozUmc0Z0hNVlpTeGE3QzU4bWNteHpp?=
 =?utf-8?B?aVlSclhidWc5WG1vVlpCL0NVaE94dnFCYTVTMXNZZmpUeEdpaldiTUlOTjZ6?=
 =?utf-8?B?YVhzYUJ0bVN1b21WUDU4WmRQOWViK002aUFyRXJac21sZWpTci93WHVoU3hn?=
 =?utf-8?B?V1ZHVkljbFUvdEhVMTFJdC9xZVYyYVc4T0piNlQ4ZXZzOENkaTFDNjBBR2p0?=
 =?utf-8?B?UjBST0h2cmRZblRBRUFsY3BQb3F3eFc5dzRrOHlrRDF2ZytCOXBFamg5ZFpH?=
 =?utf-8?B?MGl1WXZRYlUzcDNvWE11TnQvQ0dtTXhKR24yL1JPTHNWWnB5YTdMS1dDTXJ6?=
 =?utf-8?B?RkdqMkUrUWplWnFnaVhQY1Fja3Q2bkRjZXdMYmp3Q3FoQnZ2cWRPRVpHS2dY?=
 =?utf-8?B?VDdaUVRkTDBzRXZVbk83VXd2bW1HTGdibFg4Y2M1N1FrYlIramUxRVp3aGhl?=
 =?utf-8?B?VCtBeCs2V0tHRVBJdEN3QmVJWkFyUFlJSURhVk9aQThNMlE3SHNUNTRxY2Vy?=
 =?utf-8?B?c0ZuTlZ6cGs0c2E1RXpqeE85V1dKcllOUkZhUzBxZUVPbDBNRUdaMDkvcEVu?=
 =?utf-8?Q?+jOtyeMxPrF3xOqT0mN0qWOBB?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4337476-1a51-4d95-0773-08db2fae4645
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 17:02:55.6417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i3f1aSUStKkbcg3KHN2Afe4B6jceJdGWNEDkT2rYwEONKzjcDRxza0H4TkUhot8umvFNO+Qurg89uTBDcrg8CQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8490
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        SPF_HELO_PASS,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 28/03/2023 14:31, Rob Herring wrote:

...

> Does this fix it?:
> 
> diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
> index 0145aef1b930..22d39e12b236 100644
> --- a/drivers/pci/remove.c
> +++ b/drivers/pci/remove.c
> @@ -157,8 +157,6 @@ void pci_remove_root_bus(struct pci_bus *bus)
>          list_for_each_entry_safe(child, tmp,
>                                   &bus->devices, bus_list)
>                  pci_remove_bus_device(child);
> -       pci_remove_bus(bus);
> -       host_bridge->bus = NULL;
> 
>   #ifdef CONFIG_PCI_DOMAINS_GENERIC
>          /* Release domain_nr if it was dynamically allocated */
> @@ -166,6 +164,9 @@ void pci_remove_root_bus(struct pci_bus *bus)
>                  pci_bus_release_domain_nr(bus, host_bridge->dev.parent);
>   #endif
> 
> +       pci_remove_bus(bus);
> +       host_bridge->bus = NULL;
> +
>          /* remove the host bridge */
>          device_del(&host_bridge->dev);
>   }


Yes that does fix it! I had been meaning to get back to this this week 
to figure out what is going on and so thanks for figuring this out.

If you plan to send a fix for this, please add my ...

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Cheers!
Jon

-- 
nvpublic