Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 12:34:48 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()
Message-ID: <20230328173448.GA2952425@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230328110610.3824-1-cai.huoqing@linux.dev>
Precedence: bulk

On Tue, Mar 28, 2023 at 07:06:10PM +0800, Cai Huoqing wrote:
> Remove pci_p2pmem_dma() reference,
> because pci_p2pmem_dma() method is already removed.

AFAICT, pci_p2pmem_dma() *never* existed.  I suppose it was a typo,
and pci_p2pdma_distance_many() was intended?

I'm happy to either merge this patch (with an updated commit log) to
remove the comment text or merge a patch correct the comment text.

I just don't want to merge this with a commit log that says we removed
the pci_p2pmem_dma() method when it never actually existed.

> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
> v1->v2:
>   1.remove pci_p2pmem_dma() reference directly instead of
>     using pci_p2pdma_map_segment().
> 
> v1 link:
>   https://lore.kernel.org/lkml/eea970cd-d781-9d4c-e020-9086505a4ba7@deltatee.com/
> 
>  drivers/pci/p2pdma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..6cd98ffca198 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -746,8 +746,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
>  
>  /**
>   * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
> - *	the specified list of clients and shortest distance (as determined
> - *	by pci_p2pmem_dma())
> + *	the specified list of clients and shortest distance
>   * @clients: array of devices to check (NULL-terminated)
>   * @num_clients: number of client devices in the list
>   *
> -- 
> 2.34.1
>