Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 10:46:40 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com,
        akpm@linux-foundation.org, chi.minghao@zte.com.cn,
        linmiaohe@huawei.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V8 1/2] mm: compaction: move compaction sysctl to its own
 file
Message-ID: <ZCMoAKgGj3PnOtMw@bombadil.infradead.org>
References: <202303281446280457758@zte.com.cn>
 <a231f05c-b157-f495-bf06-8aca903c7e17@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a231f05c-b157-f495-bf06-8aca903c7e17@suse.cz>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Tue, Mar 28, 2023 at 10:56:52AM +0200, Vlastimil Babka wrote:
> On 3/28/23 08:46, ye.xingchen@zte.com.cn wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> > 
> > This moves all compaction sysctls to its own file.
> > 
> > Move sysctl to where the functionality truly belongs to improve
> > readability, reduce merge conflicts, and facilitate maintenance.
> > 
> > I use x86_defconfig and linux-next-20230327 branch
> > $ make defconfig;make all -jn
> > CONFIG_COMPACTION=y
> > 
> > add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
> > Function                                     old     new   delta
> > vm_compaction                                  -     320    +320
> > kcompactd_init                               180     210     +30
> > vm_table                                    2112    1856    -256
> > Total: Before=21119987, After=21120081, chg +0.00%
> > 
> > Despite the addition of 94 bytes the patch still seems a worthwile
> > cleanup.
> > 
> > Link: https://lore.kernel.org/lkml/067f7347-ba10-5405-920c-0f5f985c84f4@suse.cz/
> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks, queued up on sysctl-next.

  Luis