Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 10:48:20 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Jan Kara <jack@suse.com>, Yangtao Li <frank.li@vivo.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Christian Brauner <brauner@kernel.org>,
        Seth Forshee <sforshee@digitalocean.com>,
        Dave Chinner <dchinner@redhat.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Baokun Li <libaokun1@huawei.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: quota: avoid unused function warning for
 !CONFIG_SYSCTL
Message-ID: <ZCMoZMftUgg7Mrv2@bombadil.infradead.org>
References: <20230328122244.2521387-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230328122244.2521387-1-arnd@kernel.org>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Tue, Mar 28, 2023 at 02:22:31PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Note: it may be better to just revert the 63d00e08515b patch, as the
> -#ifdef CONFIG_SYSCTL
> -	if (!register_sysctl("fs/quota", fs_dqstats_table))
> -		pr_notice("quota sysctl registration failed!\n");
> -#endif
> +	if (IS_ENABLED(CONFIG_SYSCTL)) {
> +		if (!register_sysctl("fs/quota", fs_dqstats_table))
> +			pr_notice("quota sysctl registration failed!\n");
> +	}

I'd agree to drop that patch and instead just use register_sysctl_init()
iwht Arnd's strategy.

  Luis