Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Mar 2023 12:51:32 -0500
From:   John Allen <john.allen@amd.com>
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "Yang, Weijiang" <weijiang.yang@intel.com>,
        "Christopherson, Sean" <seanjc@google.com>
Cc:     "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>, Borislav Petkov <bp@alien8.de>
Subject: Re: [RFC PATCH 0/7] SVM guest shadow stack support
Message-ID: <ZCMpJLAx8//1zLLV@johallen-workstation.lan>
References: <20221012203910.204793-1-john.allen@amd.com>
 <Y9B97dZnFnjEHhVf@google.com>
 <d4e15021af4e72d6daba4021feaebf289b676830.camel@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d4e15021af4e72d6daba4021feaebf289b676830.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WNBfftUzTKiYuD1XTJr0VhRCTKRnZ7wTNYuz+p19HKElDBcVe96yub0DiA16?=
 =?us-ascii?Q?7SaH9CkzK2MVqPSAkoZqUMbfCl4dz+f9NNcOJFa1grWGE/qohl+pJLcj1aZ0?=
 =?us-ascii?Q?xPzicCSiVGs4aPPU+tqAdAtogeIv4xbQs1wjCr1YvTcvZ17L8keUSul4MGPL?=
 =?us-ascii?Q?xb5a+QS9vU5cbi25XyfUZ0XEAljUg8xWNbNrn1KTH6x98XBJPFl4s7HnfpjO?=
 =?us-ascii?Q?8rLJNO7apo8x1ISl8bUsTeNQ8wo4fXbxkVPNvE127SHFEN8II9I+23VDXm7T?=
 =?us-ascii?Q?8kY07KFVo1t+ZZLx9RaTjMl9gYeo6lleP/YP1giIccBCQK93POt1oofUP8RV?=
 =?us-ascii?Q?rQxFcM/NCxTP+FCcD5zTVjnGAV2QR7rJ/pW+2F7r3MEc40S+EtRAXYxQPaUs?=
 =?us-ascii?Q?FjJ7/0y7LvdDxFCQp+R78eCpcgRE8Ss+q0h/OR538aX8ZsmPrnBesDJt6v24?=
 =?us-ascii?Q?85XfDz2/rjuTUZRpOy552tIYA+YzOI5co5AIhZL9mADtGiOxyi1Va+6NFUks?=
 =?us-ascii?Q?pWZj54rfcBALrnwPhveyOUytjDq84m8pnMqj98nsOWfnXjChrG/kmyEJ/mQ3?=
 =?us-ascii?Q?lTrCpHpmXA+aoEQ7pIWwiG+QltHtoOYm60VAaZSu53dRxUM7GHdgxHgM2Tze?=
 =?us-ascii?Q?Rjo+0xwY2tEYPrVVRpvvMZA0Az841+4kTlahnx0je0z6yR3wjL+WUMg6pZvS?=
 =?us-ascii?Q?P2DJGoBUCUo3+hy6fBHp6yZy6V10BHBewb81e0RVljw9xXbIWkLpobqagps8?=
 =?us-ascii?Q?TH/5V+spIms/V93nezAZX+GdjjH/iIscmaKFs6aLO0duoTZX8V9LERKztQ+p?=
 =?us-ascii?Q?CnJJXKJtkBTpGt8ulNZH3EzK884EuGZIqYclWYgoPaEGv9a89WXNRtbUmF5N?=
 =?us-ascii?Q?MmXeZeL5jKMeBPzFh+V8Eb33xH7sXDS81hb+LqpYZNHL5EJmlyVIzpmrYDfG?=
 =?us-ascii?Q?0IAi0kgp54RQkQAI6xYmEvbrBJtfDudMy1hRZzM4Mn6rOpZdPjDyVYcShSc1?=
 =?us-ascii?Q?5U11jReIMeHdhUnosGj/qgX7qPwiuVZvcM/wtcCSF5Y+UYfsRyfeORIOnjcQ?=
 =?us-ascii?Q?bkl/p7XV7gclfQJnj8TiZtDYZwAW85M3aOXcZ10DsyouOEULoTiKUasYevbO?=
 =?us-ascii?Q?qRmB3/dAbUHXtqDHull+DlN8AEPASRtrbP9fq6kb+UHcl3NaDDRnhJPcZ22n?=
 =?us-ascii?Q?wD2MTCd3IVr2hJHcWarc0nTuUoOshwtLzO/vZOmBXraEonchRlxTHAS+CHD1?=
 =?us-ascii?Q?j+5KIrLk4d0BfybNaEWruayLfuuC1j6ZOjeiZcBC9hVlhO5fx80Maf68g9EK?=
 =?us-ascii?Q?0byuqOkyKXBnNiIPwIFZ5XSt/0uxUcx5HEt/p44fG4y+psFfU6yET6UL/iOz?=
 =?us-ascii?Q?JN3vcb8EMuSQtHwjjQzDgUTPgJtMsGEiTtA/IhkeIA1Gx8cBvR+NZxOF8YZh?=
 =?us-ascii?Q?cmkd2QgNA85UHn0A/tJf/+2EPdn868dyIKtbezI/nERRv9NEi926RGf/+XfN?=
 =?us-ascii?Q?7sMsGr49SpMPwgNZr/s/Gxt+XrCWTh9eUv+aqFAwYrq5GV6cTYolyYaWjIHK?=
 =?us-ascii?Q?2rMdELleG/1fJMq/6vSCpDphely52Zp8QIfQ8qxv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa613be0-fc88-4dfa-29e8-08db2fb51698
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5995.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 17:51:41.9901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NvVDCY+8iVP1jlc57iBUMPjEjjE6L5eVaySV0lTjSVd2XJE8V4EF48KSn8kPTbZc1BFAzSoHmTbUDBfX8qdVNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6629
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 25, 2023 at 01:11:44AM +0000, Edgecombe, Rick P wrote:
> On Wed, 2023-01-25 at 00:55 +0000, Sean Christopherson wrote:
> > On Wed, Oct 12, 2022, John Allen wrote:
> > > AMD Zen3 and newer processors support shadow stack, a feature
> > > designed to
> > > protect against ROP (return-oriented programming) attacks in which
> > > an attacker
> > > manipulates return addresses on the call stack in order to execute
> > > arbitrary
> > > code. To prevent this, shadow stacks can be allocated that are only
> > > used by
> > > control transfer and return instructions. When a CALL instruction
> > > is issued, it
> > > writes the return address to both the program stack and the shadow
> > > stack. When
> > > the subsequent RET instruction is issued, it pops the return
> > > address from both
> > > stacks and compares them. If the addresses don't match, a control-
> > > protection
> > > exception is raised.
> > > 
> > > Shadow stack and a related feature, Indirect Branch Tracking (IBT),
> > > are
> > > collectively referred to as Control-flow Enforcement Technology
> > > (CET). However,
> > > current AMD processors only support shadow stack and not IBT.
> > > 
> > > This series adds support for shadow stack in SVM guests and builds
> > > upon the
> > > support added in the CET guest support patch series [1] and the CET
> > > kernel
> > > patch series [2]. Additional patches are required to support shadow
> > > stack
> > > enabled guests in qemu [3] and glibc [4].
> > > 
> > > [1]: CET guest support patches
> > > 
> https://lore.kernel.org/all/20220616084643.19564-1-weijiang.yang@intel.com/
> > > 
> > > [2]: Latest CET kernel patches
> > > 
> https://lore.kernel.org/all/20220929222936.14584-1-rick.p.edgecombe@intel.com/
> > 
> > That dependency chain makes me sad.
> > 
> > Outside of a very shallow comment on the last patch, I don't plan on
> > reviewing
> > this until the kernel side of things gets out of our way.  When that
> > finally
> > does happen, I'll definitely prioritize reviewing and merging this
> > and the KVM
> > Intel series.  I'd love to see this land.
> 
> I think all KVM needs is a few patches from the beginning of the host
> series (the FPU stuff). At one point Weijiang and I had discussed with
> Paolo and x86 folks that those few could go up with the KVM series if
> desired.

Now that the baremetal series has been accepted, how do we want to
proceed? I think I'd like to send a refreshed version based on the
version that was accpeted, but I'd want to wait to base it on a new
version of Weijiang's kvm/vmx series (if one is planned).

Weijiang and Rick,

Are you planning on sending a new version of the kvm/vmx series?

Thanks,
John