Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp4928982rwl; Tue, 28 Mar 2023 13:24:40 -0700 (PDT) X-Google-Smtp-Source: AKy350amB0hi3b4AA495a4b34lv4ay2a6esjksV9KS/kS6oC1lUsLLBcLSp8cYmqTf6UYhqtv3wN X-Received: by 2002:aa7:d782:0:b0:502:4d8c:c836 with SMTP id s2-20020aa7d782000000b005024d8cc836mr4832942edq.10.1680035079724; Tue, 28 Mar 2023 13:24:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680035079; cv=none; d=google.com; s=arc-20160816; b=y+ud+mgWUCRfsRhk+PyOON8uCoKWQ3pJ4DYR+a1iC3IXDIXdiDX9XxGXGA5T+EIRta W9bJSTkFyuxNy/ZSLvu9Oz+cYunbjW1i/KExijn2M8vnfVppdCem+ATOPP5NKj2UNEaL 2zQ7QejetAmkjoq0yibAF0tdEh3pBor8QcquC3bfsZzjw5WpYFvOX9orFpCkp1gX73lS 7XO1kDNxGVWXP/Q5lC71zCIpAHQnkdV7OX8QM+TR8jCirljejUfCzTjQvLOXWVmPGrCG vkANFfJRxEnw9Gs971K2GhleO8lmheJu9R6l787bNiEESOVYFYjKA24AaIxntcBJ5nDk FMlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4RXsuAHhqdjm2o41foRUAx+kNJRu6tTNq1+FEOvHpxQ=; b=oHYoPr5FvZE2JlPCzchlcSl0Kh8HPvtcoLswcoYAo6rk8XOTkmG57pQodekzaoFVXU PWpzru8o47DtLxJjzZbXqNjbGw7gpllckJDiZqp6Pmoi+hA4KnNwVWq+FYFFMzT9Mq0K 6mF2jyQuJBS655tHC4k1T9H8HXdZ8RlDuZ65jvG+kGV8piQMckYA3qWgXoQHI3mr+Awk PGMNdsz3/y9/abr3GLuHPRDm/3zjl7N0WYHj/IFTU7buGZjpcOB4Wvb2Y0O6ZFOa3pe8 dacd5CfuqXlq+3BWqYijUAcCRlk76UrzIxku0oeTlxdBQv++X0LMR6BuzlgMQEJjM4WD IpyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KZUnYdIO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d15-20020aa7d5cf000000b005008879d10dsi24599726eds.579.2023.03.28.13.24.15; Tue, 28 Mar 2023 13:24:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KZUnYdIO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjC1UWM (ORCPT + 99 others); Tue, 28 Mar 2023 16:22:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjC1UWK (ORCPT ); Tue, 28 Mar 2023 16:22:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BADB1FD8 for ; Tue, 28 Mar 2023 13:22:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9EFA2B81CAB for ; Tue, 28 Mar 2023 20:22:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34E4EC433D2; Tue, 28 Mar 2023 20:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680034927; bh=54nMkls0+I29HMEM1YCHcejfYPJPJVWADs2YaBN33sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KZUnYdIOdDiJtnu7j2PijSL5084ft6vcFDLeUBBtbtPMLaj7m/84vxZxKnFQsqBpn XRaTLvIlD3OS0q8KB5r+/EBbwIztblt8V7FpUE8/z9W0FvEZc0lLGXJB37hhkcRRds 1XoSyNn8yPyKzNnExDsXFgwUP3vrjl6VNCWmqC5KBiL8HvH7zIQ0MCPhprGQFhF1SS plP/T7P5++OtFywJfUnqymBaZ8D3G4fO+bwbZua5JBSpe/KLJIjKtKzbIsVAFz7np6 lIior2JwoFrl7dUz2QZ+JfZ9tWQY9qix5DLUzeaZnuEMCmcBDGS4xk9yenS1xlM+xp IrIQmG24p8YnQ== Date: Tue, 28 Mar 2023 13:22:05 -0700 From: Josh Poimboeuf To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] objtool: Add per-function rate limiting for unreachable warnings Message-ID: <20230328202205.cfd7hvpj74rv7ry4@treble> References: <20230328081105.GD4253@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230328081105.GD4253@hirez.programming.kicks-ass.net> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2023 at 10:11:05AM +0200, Peter Zijlstra wrote: > On Mon, Mar 27, 2023 at 09:00:47AM -0700, Josh Poimboeuf wrote: > > Unreachable instruction warnings are rate limited to once per object > > file. That no longer makes sense for vmlinux validation, which might > > have other unreachable instructions lurking in other places. Change it > > to once per function. > > Do we want a negative option to disable this? --no-ratelimit or such? Per-function rate-limiting is almost always the right thing, personally I don't envision needing to disable it. -- Josh