Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5095290rwl; Tue, 28 Mar 2023 16:22:38 -0700 (PDT) X-Google-Smtp-Source: AKy350bnABRvqFw/S0G6TQlF0GOBqw1rHEZrA8pM4DAM6eDqCdI9lU2Z7IWFZqQZs65v/GKJjHen X-Received: by 2002:a62:84d0:0:b0:627:ea7a:ff46 with SMTP id k199-20020a6284d0000000b00627ea7aff46mr17406511pfd.16.1680045758630; Tue, 28 Mar 2023 16:22:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680045758; cv=none; d=google.com; s=arc-20160816; b=bJa6Ayl6FakO4uqkwOUVjucDU9IekcrGqlAy/i0pfgbcvJuCwVY7DJVXakMo5tIt3l U6GgV9p0JSVjSiwEjdIrEk0MKNd01SWXxL8e6r2wqo8zIVLlhcQorxs7lFYNL2dAnBuI qhK+F7+cndFS18G15I2x8vUR7gKByJdakNRga5Mn+2NZysGKXKMUVRn6Cn3kQXBxfpP2 ysm4f+SZD2DT03CDGgfER5YtZps5O6aaxIo5/qMfy217PsTB8ejnk4HYjgML1pN2bhGQ lY+RuhqiioVxxfnL/COyBuXnAdAnYzG6wJ5Cwze6kByZY/7cfD8nSuoIqy1JCQubsmzL SiFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=YxtskzsVQcHb1RszTbKAaviIkrlGtjlEFKxQsRMT3nk=; b=MNJZh4+fucbX9h0M4cC6IggE0239EuY2+6VSYtEYnV9f6w/96YQna0JOePez5quZKd 9B1yvlS7prG8Bk0hwJnHCT9g4TAsR5pUzyOuxb4B/shX7V50Q6KyTLdmV4Zjv1mD0ks0 8v1RYtxilubmEs7RAO5FhQZ+5LCS0NpspOb71UxLeTL5dfTKl1eumx7xfgqXcHsxEZR4 xT3R7t9WiF9pPk3xVRla5XlxTks1PZRFYB/GseOvRBd+3VEl/fHCGdz7wDS3I5DC8rVR rph3lBRl2Swo6W/IQFoa5VFqfHyGjMBG/rGD9uvRD3kvx8hmGJ1EQnnJ9uPIldtWL6LD VOhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pzs3Gpvf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s17-20020aa78bd1000000b0062b24b48727si10705341pfd.213.2023.03.28.16.22.26; Tue, 28 Mar 2023 16:22:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pzs3Gpvf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbjC1XQt (ORCPT + 99 others); Tue, 28 Mar 2023 19:16:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjC1XQs (ORCPT ); Tue, 28 Mar 2023 19:16:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C16B72683; Tue, 28 Mar 2023 16:16:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29F29B81CC9; Tue, 28 Mar 2023 23:16:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83939C433D2; Tue, 28 Mar 2023 23:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680045403; bh=dr/aVS9Be55zvJpTsMjeCdwrQeiI1QFH6vPkt8vuTvc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pzs3GpvfhGTKR0xo3I7NciiFyh7+WvAVLl5PGMvJITmwt41luFKf2SsiIpmRXUIvw nOSK9sJMllpz8yd6i0NXERZW1H6QzrP9A45OkvSapoeJYxQkAK4LTHdBSdGJ/owvSb BujTfG4niP+DLxl227cW+eFjB1vWgGmrC5bWJEkyAq6uLnUf9un70J6ivXnVYsrLYE NwNw9oHmO7AFSme6LFvjfoyXjnLSt1UrHvvmU5HZqLvRlPv6ZWueEdjjiL89VaNrQB LpBbxxchLrRo3NeCpeZOwlFlvsmPC9hD/FPP57qJ1T74pmhzikhbtlfw2tL5xspyDj ougT6MLOuUeXw== Date: Tue, 28 Mar 2023 16:16:42 -0700 From: Jakub Kicinski To: Felix Fietkau Cc: netdev@vger.kernel.org, Jonathan Corbet , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net/core: add optional threading for backlog processing Message-ID: <20230328161642.3d2f101c@kernel.org> In-Reply-To: <20230328195925.94495-1-nbd@nbd.name> References: <20230328195925.94495-1-nbd@nbd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Mar 2023 21:59:25 +0200 Felix Fietkau wrote: > When dealing with few flows or an imbalance on CPU utilization, static RPS > CPU assignment can be too inflexible. Add support for enabling threaded NAPI > for backlog processing in order to allow the scheduler to better balance > processing. This helps better spread the load across idle CPUs. Can you share some numbers vs a system where RPS only spreads to the cores which are not running NAPI? IMHO you're putting a lot of faith in the scheduler and you need to show that it actually does what you say it will do.