Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72286603300630b890705c99b42f05a4.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230328193632.226095-3-brgl@bgdev.pl>
References: <20230328193632.226095-1-brgl@bgdev.pl> <20230328193632.226095-3-brgl@bgdev.pl>
Subject: Re: [PATCH 2/7] clk: qcom: add the GPUCC driver for sa8775p
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
        Shazad Hussain <quic_shazhuss@quicinc.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
To:     Andy Gross <agross@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Bjorn Andersson <andersson@kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Date:   Tue, 28 Mar 2023 19:15:08 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Bartosz Golaszewski (2023-03-28 12:36:27)
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 449bc8314d21..5e1919738aeb 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -437,6 +437,14 @@ config SA_GCC_8775P
>           Say Y if you want to use peripheral devices such as UART, SPI,
>           I2C, USB, UFS, SDCC, etc.
> =20
> +config SA_GPUCC_8775P
> +       tristate "SA8775P Graphics clock controller"
> +       select SA_GCC_8775P

Should select QCOM_GDSC as well.

> +       help
> +         Support for the graphics clock controller on SA8775P devices.
> +         Say Y if you want to support graphics controller devices and
> +         functionality such as 3D graphics.
> +
>  config SC_GCC_7180
>         tristate "SC7180 Global Clock Controller"
>         select QCOM_GDSC
> diff --git a/drivers/clk/qcom/gpucc-sa8775p.c b/drivers/clk/qcom/gpucc-sa=
8775p.c
> new file mode 100644
> index 000000000000..46d73bd0199b
> --- /dev/null
> +++ b/drivers/clk/qcom/gpucc-sa8775p.c
> @@ -0,0 +1,633 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights =
reserved.
> + * Copyright (c) 2023, Linaro Limited
> + */
> +
> +#include <linux/clk.h>

Is this include used? If not, remove it as this is a clk provider and
not a clk consumer.