Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 12:25:54 +0800
From:   Chester Lin <clin@suse.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        NXP S32 Linux Team <s32@nxp.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Radu Pirea <radu-nicolae.pirea@nxp.com>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v5 5/5] pinctrl: s32: separate const device data from
 struct s32_pinctrl_soc_info
Message-ID: <ZCO90vGIx+Z+J9gz@linux-8mug>
References: <20230327062754.3326-1-clin@suse.com>
 <20230327062754.3326-6-clin@suse.com>
 <CAHp75Vf_k2ZDoyHUVbD_e4droAwxVqu7HCwNrPd=X_su-c8LjQ@mail.gmail.com>
 <CACRpkda097RwHCZu+_WAJRP=MGo7g4j++WJ57P=H7xKa9j439g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkda097RwHCZu+_WAJRP=MGo7g4j++WJ57P=H7xKa9j439g@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2dtbjdLZUl1VE1qRUJQZ1hSdFR0S2d2S0Z6bmU4VFNEbTY2NWdmdlVNcDZ5?=
 =?utf-8?B?RkhHYTFqMi9aeTg4ZWkvUUE4aUVWeVN2UEFJMWJtcGJKWGZNd2NlRkRMUFZS?=
 =?utf-8?B?MHVjdkNNK1llcCtHbytIU0NJUnZGNjJoZ2lNclEzNVZIN0FobUhOeFAvZTZO?=
 =?utf-8?B?TTFsRG1WUktNSFMzaS9UcHJ0WURrV3pveE1pUENwK0hnb3ozeHQ0dUZIMk9y?=
 =?utf-8?B?NS9yZTlJN1pMdCtETCtoRVFIM0VYWitUNnNHQzdwNTJkcWYzOWRZSmNUenJX?=
 =?utf-8?B?QXNoWko3QzRqRzNmVTFqK3FlOGRyTW9STnJubi9YeEFIcFdEWVNqaklxeWs1?=
 =?utf-8?B?WW1ub3FNWlAyZHEzWVNPNWg3ZDkvQ2F4VHVNdEVZR0R2S0lZMjR4MlhiWkpq?=
 =?utf-8?B?ZlJVamhqeVN1NXVZRXpPeWdCNVYydldDb2hmQlR0UVVkZVY3WUZWRTFaVFhJ?=
 =?utf-8?B?SGtpS1N6UTR3Y1FmYkpoSXdFbFFnaCtRWDB3VkY5RDNCWDJteG90VHlPMHlo?=
 =?utf-8?B?dldYTVNGQlhyS1lwSysrYTVLRnRuYXlLcE1RL0tDOWRjRWRyOHZ1MUFsK1hX?=
 =?utf-8?B?M1VaL05naklqSWdzMklOZFFaNWZuRmoyRVE1NXNoWVBOcFQzK3lLL2MvcjVD?=
 =?utf-8?B?MUN2eG1ETmR2OXlJU3BxZFVTS2hQbzJJakhjYlh1OXhsR3E5MUxpN3h4MC9G?=
 =?utf-8?B?czF6M3p5dUNLR3p1R2RjcXROTWJ0Zk1rdGJPdGVZM1VaY1hnQ2dTV2NVbHM3?=
 =?utf-8?B?TW5ZRWRZc0tKSU1vcUpMNVVsU3dHQUl2S2JWYVBWMEZzMTdZOU9PRXlpajlz?=
 =?utf-8?B?ZG9VVUZIZUJYNUUzSXIzck9zUms4blhpTUxTUUxPS2UrczI2UU1BZXFseVVy?=
 =?utf-8?B?MFFlMzFpSzluazJ2WlZYd04vWlg1UmpqZU1GL2ZIOUhDSklRMmpPbU5wNDZF?=
 =?utf-8?B?clZ6QVZnaWcvTlQxcjJwZWF2S0NGcUlkdmQ1RnhlcFVvbnBlcXJuazRiUHF4?=
 =?utf-8?B?c0krRmgrY2txMzAxdlMrRzF3YW81WWFLSGVRS2dOd1BYTVNueWpCSGc5U2tk?=
 =?utf-8?B?OGg1Z0liTUJrNzBySG9iQWorejBzS1JSNVZ3a05LYTJldk45bXZjeUc0ajFh?=
 =?utf-8?B?ZXU3MTBJY3I4V2VYSWRMYkh2YUZ6WkUrNngzRVR2VHE4S1daTnlMazlBak95?=
 =?utf-8?B?WGtmajZqZ1RDM1FTek81bkc2bGZRWENiblZlZmtrOXB0elhncUdnUGZpQitR?=
 =?utf-8?B?aVhaeTZOREw3YjZ2OG1iek1vWW5nRmhmWkN6WWc4ZHV6QUhIYW5DaGR0WVNM?=
 =?utf-8?B?dnB6UjlOS3Jsb2tyYmxyN09VOHhuTytJUEx3bnFCd090ZUtpUWs2YUF5eXNN?=
 =?utf-8?B?aWRlTnJTWGZpaWVianFwSEh2Vnl6ODQ1SDE2TnJGUk9YMXhCWHZWZUpxYlk2?=
 =?utf-8?B?ODMwdmprN3J1RW9sYnlaTGk3Z2NvTDRKM0hQMHIxNUlXV2xBbGQyQithUlg4?=
 =?utf-8?B?Z3lPSGFwOFB3TVB2OEN4UGZsSUNuamdGVElGMWhsTXZjSGZPb0YwY0RQdGZ4?=
 =?utf-8?B?RWZHQURlMDhzVGt2Ni8rVkVETkt5R09MdkdHNVBtNnVTTzhiMnllazQwZHdO?=
 =?utf-8?B?T3NMMUNpM3dwMHdmU1hJTC9TNkR2TFNWdGNxV0RuRUV5TlAzUXFGV2N4WlpO?=
 =?utf-8?B?a0tXZXcxdHBVOHNiSXpFOEV0c3c4aUxaZ0pyZnA1T2txM0ZLVUliUzIyVFRW?=
 =?utf-8?B?V01BdXBwbUc2MHRZU2ppaEtPVWRYUGRxYnR3bCtoU0RLRWFlN1FTc1V0Wngw?=
 =?utf-8?B?cDJ4bHhGanhSY1dWQVdvYUFZRDdOeFJ1OUJHM2I0ay9JcHB3YlBRQ2JINWdG?=
 =?utf-8?B?SEFuZUFYRFRjZnFHY2c0dkU2K0hYbXd5VXhnNjlUZUROOTBoMzFIQlN6Vm55?=
 =?utf-8?B?UEpYc3hHZVlqUER4aFI1NlJ2UUNrS3F1RHZqZC9QSU1wbHB2VmR5aDdoZUYw?=
 =?utf-8?B?eFZ4T1h5bnlHUThCelJ5eTlkOVNuenRzTWFqc1lYVjhDKzF4MGFhRXhpR1NK?=
 =?utf-8?B?ZTFXWlpyQmlIdW1lMGtSd09DMTE3by9mOStZd0dMY2haQXJaZjZETzdveDdW?=
 =?utf-8?Q?aFlk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4427c0c-3d74-4671-d257-08db300db411
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 04:26:01.8550
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8mplx9UfRSIP/tlK69+oHBI9Zjp0FTA0gT83QsPYXviymuqsWhiMm4S+RtlvooVA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6981
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Linus and Andy,

On Mon, Mar 27, 2023 at 11:39:18PM +0200, Linus Walleij wrote:
> On Mon, Mar 27, 2023 at 1:59 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Mar 27, 2023 at 9:28 AM Chester Lin <clin@suse.com> wrote:
> > >
> > > The .data field in struct of_device_id is used as a const member so it's
> > > inappropriate to attach struct s32_pinctrl_soc_info with of_device_id
> > > because some members in s32_pinctrl_soc_info need to be filled by
> > > pinctrl-s32cc at runtime.
> > >
> > > For this reason, struct s32_pinctrl_soc_info must be allocated in
> > > pinctrl-s32cc and then create a new struct s32_pinctrl_soc_data in order
> > > to represent const .data in of_device_id. To combine these two structures,
> > > a s32_pinctrl_soc_data pointer is introduced in s32_pinctrl_soc_info.
> > >
> > > Besides, use of_device_get_match_data() instead of of_match_device() since
> > > the driver only needs to retrieve the .data from of_device_id.
> >
> > ...
> >
> > > -static struct s32_pinctrl_soc_info s32_pinctrl_info = {
> > > +static struct s32_pinctrl_soc_data s32_pinctrl_data = {
> >
> > I'm wondering why it's not const.
> >
> > But don't resend too quickly, let's wait for Linus to comment on this
> > and other stuff. It might be that he can amend this when applying.
> 
> I don't dare to add const here given the compiler warnings it
> can easily spawn.
> 
> Chester can you investigate if these can be static const?
> 
> You would only need to resend this patch 5/5 because I applied
> all the others to lower your patch stack.
> 
> Thanks for fixing!
> Yours,
> Linus Walleij

Thanks for reviewing this patch and Andy's suggestion looks good to me. The
s32_pinctrl_data should be const as well since the 'data' pointer in
of_device_id is declared as const.

Anyway, I have resent a revised 5/5 under the same mail thread:
https://lore.kernel.org/all/20230329041630.8011-1-clin@suse.com/T/#u

It can be compiled by the following two gcc versions without a warning on
drivers/pinctrl/nxp

- aarch64-native:
  - gcc version 7.5.0 (SUSE Linux)  <aarch64-native>

- cross-compilation on x86-64
  - gcc version 13.0.1 20230127 (experimental) [revision ca8fb0096713a8477614ef874f16ba5bf16c48bc] (SUSE Linux)

Thanks!

Regards,
Chester