Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp91708rwl; Tue, 28 Mar 2023 21:38:39 -0700 (PDT) X-Google-Smtp-Source: AKy350aLdB+Q9k6hsXXk5M0nU+5kkv0SFD0AlBkgxb8lEHvZD+gfW4xwhpqNOHKES0WjOeIqLlqi X-Received: by 2002:a17:906:9f15:b0:92f:b47c:cefc with SMTP id fy21-20020a1709069f1500b0092fb47ccefcmr15899606ejc.24.1680064719547; Tue, 28 Mar 2023 21:38:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680064719; cv=none; d=google.com; s=arc-20160816; b=QQwPsHINt4yud/NoM5Cbw0MOWaLiOFvHCbO5iX/PuQHcRy9figdKnZFyAhl6fqdIa0 O7R0Wk7luLgYdBAt6S202UJ3l/IXHG3GDFtfjTJuip/fuOgD3515Z6tUCOYsgqyFGIYy A/o0WHGWjPe8ZtMkUyohYDmEAIb8UpfBS7oLlDh3zBBv09gAx4Am5F35AeM+sxnEuRAa tnAbBQJn6PP9hh+NPA2dsfVc+1idW1ciuHrPBRhi6KDt5Au0/3t8xP4wO3aoFSsnl4Xk ZVCpRYjcuTLJC/lXAIDlYHjkZ2ArJQc9ZDGfCCyTn/m953ql+I9ZdQHksmIl2uA3Btx9 HU8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=z3XmrRWj23D8uF2mMEgEMGr/TPQEZXw7BBCYlwpQ9f0=; b=kh/16twAmL74d1dvTIwgb5cmyZmyXfywdw5RU52YzRbKxjeQhSoHI/NWP2FCP1+6KA wmfzQ+CTdV7qUlf/GaCcyHNnOf9LePPN1u2sI6uCqU7Gvbr0EDQEOEfEMP/3w7bvYK3M sWylyKS+SRzIs09p5jAIzVqruYPN+uU/HqW7YmWV9t0d+ERerbRhHbVj+lbUJ56pT412 8iYfp3krQTITDKpUnEpPQdEp/Ds2u/pFUN7tf1zF7BUXh4xqMIeqOwNPYGd5eSZ989mw BljCyjm6pij4dMac5uIZnc5XVBtJqEL9W4WgkyF4SDaYSECBXv2mnVwl9oXB8qS6ZyNx 2h/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uSzeR7sC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf19-20020a1709077f1300b009453c587583si7635309ejc.995.2023.03.28.21.38.13; Tue, 28 Mar 2023 21:38:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uSzeR7sC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbjC2EPN (ORCPT + 99 others); Wed, 29 Mar 2023 00:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbjC2EPG (ORCPT ); Wed, 29 Mar 2023 00:15:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ACBD35B5; Tue, 28 Mar 2023 21:15:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D4F5B81EA9; Wed, 29 Mar 2023 04:15:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8988C433EF; Wed, 29 Mar 2023 04:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680063302; bh=OeZwGhdh1OhMyiKBDhpSCIDowglcrCZD9EdOvHs4euc=; h=In-Reply-To:References:Subject:From:To:Date:From; b=uSzeR7sCDnhf4k0KFCoVmxreYmsgU7LkeN3MdANZ3Z++Yrl4lZBXqmcOq0/1qGoYH dnNJw5YysLkr92ae2gs7oc+qqCVBI7dZ03PvQfLpXFyPsZwuYs1JLL3SiOZ6GOeJhX ZoO9kowVg5lYCoZTWxf/Y5eLVNILED0DxVSjJlDaWC7maen+Hzg9hvnqEZWg50Mx3H 6LNpwwB8CLkazqcf8BWE4jr+qMJvW/9GWd0ts91LOffixfAdwcx6V08sZbYShdgcr1 R4qxJh6W2zkAWr5qcMxYqWFHHNmzoJWO1NriwSQOA5If3XIuJZ75AWYdljD6Qu3Evd NN9XT5jI8U1JQ== Message-ID: <7cf9452c60f2b1c764b01a15a4d5c2f0.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230310222857.315629-2-krzysztof.kozlowski@linaro.org> References: <20230310222857.315629-1-krzysztof.kozlowski@linaro.org> <20230310222857.315629-2-krzysztof.kozlowski@linaro.org> Subject: Re: [PATCH 02/16] spi: mtk-pmif: Drop of_match_ptr for ID table From: Stephen Boyd To: Alim Akhtar , Andi Shyti , AngeloGioacchino Del Regno , Broadcom internal kernel review list , Daniel Mack , Haojian Zhuang , Heiko Stuebner , Jerome Brunet , Kamal Dasu , Kevin Hilman , Krzysztof Kozlowski , Mark Brown , Martin Blumenstingl , Matthias Brugger , Neil Armstrong , Robert Jarzmik , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org Date: Tue, 28 Mar 2023 21:15:00 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject says 'spi' but it's actually 'spmi'. Quoting Krzysztof Kozlowski (2023-03-10 14:28:43) > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it is not relevant here). >=20 > drivers/spmi/spmi-mtk-pmif.c:517:34: error: =E2=80=98mtk_spmi_match_tab= le=E2=80=99 defined but not used [-Werror=3Dunused-const-variable=3D] >=20 > Signed-off-by: Krzysztof Kozlowski > --- Acked-by: Stephen Boyd