Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp104540rwl; Tue, 28 Mar 2023 21:57:59 -0700 (PDT) X-Google-Smtp-Source: AKy350ZVSVPc+XTQAXAuDIdggbEYpNRc10T0DQTlWduSNaFsxPrXB8riwyAkc0Hai96ImGegtFka X-Received: by 2002:a17:907:2cf1:b0:92e:a1d8:bf1 with SMTP id hz17-20020a1709072cf100b0092ea1d80bf1mr18254401ejc.13.1680065879256; Tue, 28 Mar 2023 21:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680065879; cv=none; d=google.com; s=arc-20160816; b=mXScOx2kAFX7AZlTTfRvSBWHPSlEWsAsuKHB19CLg+L+5EyJcAA/VuOWCDd+11NG8/ hqwciez6XrFajjYFsLFwJlKyA1/5p5XC2Zk8a8c69ZksT6dJDQLnUabIdi2MPAZkflXc vK8z3yCPg7aBAV3Oye1HKJtYUCDiaehSnC7hWfBOSsFbx+k0wGA9vSFum3omVniXtGX+ eTUoPwFbyoDx8yTLLzzRZe/zC1LnRM3AjmDUWd+foq2Lt7D+da3X1y79x7uTsO5aut3Y 0kY3pM/JBHOQZthGfsDWE6oG0xzyHdjR6Wbc9YfUEIaEYNp/mpu+wstff7QfaEzvTES+ KjWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=tjSgXnnnZCRTDJ7CrT2szUK/VfrFrf/gwHWvPOVqcmA=; b=yJJd4/2xH4X5U59WbmFblT9PJqKwjEt0ZnvoOVJH5Usw1FJT0pcoJ0nIC9XrJ2T0GM NTR0nWirjOUgWIjYEzJ5tb00hBH5wfVWd4wKx2dZP2Rkj/3BrtYgwwZ+TRcsIA79t2hJ Sp08MIxyxSHCzCA9Tt7p33kHbURVt2QFej9oRgr1rGZy5edL2QPY8Rmfc1Q0XJsoTtgi 95Hljwbbi562S0M1U5XSjqJ1xYEXDh55Y5FReG71tqC9mOdTfm5UolSy1rsyxOIhotlL L9Bg1qWVc1hVLQPDieae60elCjo8uUhM2Kyu/8kJ7EiMX1TyvgkLJCrBjRT3TzN6dj// ww9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n7hHoT9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id tx26-20020a1709078e9a00b0093348efaf0asi13390675ejc.198.2023.03.28.21.57.34; Tue, 28 Mar 2023 21:57:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n7hHoT9c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbjC2ERu (ORCPT + 99 others); Wed, 29 Mar 2023 00:17:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjC2ERs (ORCPT ); Wed, 29 Mar 2023 00:17:48 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11C95193; Tue, 28 Mar 2023 21:17:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 30CFACE1E9E; Wed, 29 Mar 2023 04:17:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EBF6C4339C; Wed, 29 Mar 2023 04:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680063464; bh=eV+z6VEaC2dINI98VszrbaiHTFz32QNR/TbnF151vTQ=; h=In-Reply-To:References:Subject:From:To:Date:From; b=n7hHoT9cl4BahD9JFvPKB/aQB761g/fnk9KOSQ4o/z3XCcbxVkzNXykCpetV4JMcb lKbnfFksoTf1RSJUMCOfr73CEq3qqeAiYcfo+/nxbj1z1H99Kn6MJB013kAVtoMaBj q6hkpyychUIseBiT9ydWEHjqWN30KUhmPOcUGU9u1tLQThnCFsu1tqpWJ/6c7AtJLc rSsNaKKxTzgFVIJ+4mFqu4ZmcrtFT/tPtmpU+nLtI20acClSmzkvUYLh31TBOS+V5i 9wiq+TfU8CzOWNnOCGS9p47Niz4LN/UokOEmy2Ffp+sqFnmgypTEgIuBbYAbmZ1Dov G8AoiXz4invKQ== Message-ID: <7e58e5c86bd602932b762f9364209e31.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230310222857.315629-2-krzysztof.kozlowski@linaro.org> References: <20230310222857.315629-1-krzysztof.kozlowski@linaro.org> <20230310222857.315629-2-krzysztof.kozlowski@linaro.org> Subject: Re: [PATCH 02/16] spi: mtk-pmif: Drop of_match_ptr for ID table From: Stephen Boyd To: Alim Akhtar , Andi Shyti , AngeloGioacchino Del Regno , Broadcom internal kernel review list , Daniel Mack , Haojian Zhuang , Heiko Stuebner , Jerome Brunet , Kamal Dasu , Kevin Hilman , Krzysztof Kozlowski , Mark Brown , Martin Blumenstingl , Matthias Brugger , Neil Armstrong , Robert Jarzmik , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org Date: Tue, 28 Mar 2023 21:17:41 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Krzysztof Kozlowski (2023-03-10 14:28:43) > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it is not relevant here). >=20 > drivers/spmi/spmi-mtk-pmif.c:517:34: error: =E2=80=98mtk_spmi_match_tab= le=E2=80=99 defined but not used [-Werror=3Dunused-const-variable=3D] >=20 > Signed-off-by: Krzysztof Kozlowski > --- I'll fix the subject. Applied to spmi-next