Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9ba3c559e2fb685c941b02fcfddaeb82aefed6f7.camel@gmail.com>
Subject: Re: [PATCH v6 5/5]  mfd: max77541: Add ADI MAX77541/MAX77540 PMIC
 Support
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mark Brown <broonie@kernel.org>,
        "Sahin, Okan" <Okan.Sahin@analog.com>, Lee Jones <lee@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Cosmin Tanislav <demonsingur@gmail.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Caleb Connolly <caleb.connolly@linaro.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        Haibo Chen <haibo.chen@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Date:   Wed, 29 Mar 2023 09:01:30 +0200
In-Reply-To: <ZCMMHl5ENSuCstFV@smile.fi.intel.com>
References: <20230307112835.81886-6-okan.sahin@analog.com>
         <20230315175223.GI9667@google.com> <20230315175257.GJ9667@google.com>
         <MN2PR03MB5168249900206433A082875EE7889@MN2PR03MB5168.namprd03.prod.outlook.com>
         <ZCLi6MB/aHIf4lMr@smile.fi.intel.com>
         <cdd53e29ca3d8dbfdfa1a2520935e2bf9418313d.camel@gmail.com>
         <d2bed74b-9eb9-45af-8f45-ad2c2889024a@sirena.org.uk>
         <fc07de9af0b691fbd3a5915c8293f0c7ad4c4e06.camel@gmail.com>
         <ZCL7J5a7UZVayQVS@smile.fi.intel.com>
         <60bbad1b38b8e3c9c3efefb0fb7b8d3cad7fa98c.camel@gmail.com>
         <ZCMMHl5ENSuCstFV@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-03-28 at 18:47 +0300, Andy Shevchenko wrote:
> On Tue, Mar 28, 2023 at 04:51:18PM +0200, Nuno S=C3=A1 wrote:
> > On Tue, 2023-03-28 at 17:35 +0300, Andy Shevchenko wrote:
> > > On Tue, Mar 28, 2023 at 04:18:30PM +0200, Nuno S=C3=A1 wrote:
> > > > On Tue, 2023-03-28 at 14:46 +0100, Mark Brown wrote:
> > > > > On Tue, Mar 28, 2023 at 03:26:44PM +0200, Nuno S=C3=A1 wrote:
> > > > >=20
> > > > > > IIRC, regmap_read() is not really reentrant and it is used
> > > > > > in
> > > > > > the
> > > > > > IIO
> > > > > > driver on the sysfs interface. So, yeah, I think you need
> > > > > > the
> > > > > > regmap
> > > > > > lock and better just leave the config as is. Yes, the lock
> > > > > > is
> > > > > > opt-
> > > > > > out
> > > > > > so let's not disable it :)
> > > > >=20
> > > > > All the regmap operations are fully thread safe.
> > > >=20
> > > > Even if 'config->disable_locking' is set? I think that is
> > > > what's
> > > > being
> > > > discussed in here...
> > >=20
> > > In case the driver has its own lock to serialize IO how on earth
> > > the
> > > regmap
> > > lock is needed. That's what I asked the author of the driver. He
> > > told
> > > the code
> >=20
> > Well, if the driver has it's own locking, then sure we do not need
> > regmap's lock...
> >=20
> > > doesn't require the regmap lock, and I tend to believe the
> > > author.
> > > So, why to
> > > keep it?
> >=20
> > However, if you look at the adc driver, I can see plain
> > regmap_read()
> > calls without any "outside" locking.
>=20
> Then author of the code should know what they are doing. Right?
>=20

In theory yes, but you know that's not always the case :)

- Nuno S=C3=A1