Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp213086rwl; Wed, 29 Mar 2023 00:11:26 -0700 (PDT) X-Google-Smtp-Source: AK7set9locBr1VZyokyGxjTJZJcqZOk5Z9x9jgSWNlvwkCuTpD8xwahApTlBkwxbPQ0BwLHyx5fX X-Received: by 2002:a05:6a20:6723:b0:da:501:55e with SMTP id q35-20020a056a20672300b000da0501055emr15800621pzh.40.1680073886036; Wed, 29 Mar 2023 00:11:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680073886; cv=none; d=google.com; s=arc-20160816; b=ZEjajyefJwhFNHIoExnKRXOgC+enBAuDYRzLWp8Z/I+w3bjuq7/M2vr7YxepqlmCvf Q0Wwr+KzPfi09Jir7jbAoBSb08OmQDgmer8Fn9RmGZp2oh83af7lR+yj3Y8BPe8tcA6J DlMZCsWoXUq8XfpYD9/q2Ex73QeG71psqZjpupaOvyIIG0jeHMm4djGWMkFoEs4+O9MT nuzqCgDJkuFXYyY9VMu9DmuNm1aSfrv2Ml83hLmXgvLbW/8adhu/w0TAsbbaPeBoLifc rlBDcMaEzcsPwuurXWdIo/IW+0AwDTQe3HsUdyepsKzkgXUGlw8NRRtLtTx3V8K+7EYC IFxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c0DagGnX42QzeNj2UXakQh0Ab7J7fUDwI+PuwWFvT1M=; b=AoMUHvklBA/VAJ9TiqP5PzNKbMzWOqVM1n1sGK88VBMCSfHgWQube51mCRLVINQC3+ CFJOVburaUVhwzzabUnrx7SnpHQVPHziSDzCvvMcN+jsUtqGH6m09L6vAYaydQv0Ctjj B4ELiwGyQJFt0p2STzTSlQ9KIZsBZqeUe5f7gt4AB9Ommc33i+C0+2ARedUjJGp8KfRu /IZwia/FA+IYr5zIBUmaP97wAsmUynaMNEKquZZnv+3u9SGvVncXC9z0wMY7mbUUDe3F JENKXuf1HIpExWnXeWLP//YcNvEt/TBo7Sjr859fKlySVUuJRKnND/Zqd/ZlWKiCRa0K V/ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CMoMVBzC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b18-20020a056a00115200b0062880abbf2esi17121607pfm.315.2023.03.29.00.11.12; Wed, 29 Mar 2023 00:11:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CMoMVBzC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbjC2HKd (ORCPT + 99 others); Wed, 29 Mar 2023 03:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbjC2HKb (ORCPT ); Wed, 29 Mar 2023 03:10:31 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67467137 for ; Wed, 29 Mar 2023 00:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c0DagGnX42QzeNj2UXakQh0Ab7J7fUDwI+PuwWFvT1M=; b=CMoMVBzCqLO5Ie7wpLeEHeRHt8 Q8nSt/jQqGM7hBcPHpO1zbV4A++/lrsC9dr1x//dvOOuvPvfj8HWikRdviH2mgr9XjvQdk7lWtB3V A4RqfKlZsb/I0i2MT4c+fiTtWbZY1PEA/s06OXzEA3btiylpIeyW0+upd9lgx3rkhKescS3bJKmy4 eeuS6jiqOhB7NA1AldYLIDtuJ/68GoCIw1inkQMffSm+n58RwjleegizG1lSQMr7Gdsd3NNPxJYsC CDX4+UgXhHWWq6sOPpRhPvXaxR7R+Nxj4EUfQYu16aH6gMtdCm56HNUpvJBEe6rpyVp5sEkrTtqlL ZqrhIvQg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1phPwn-009BuN-8A; Wed, 29 Mar 2023 07:10:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3A4C83002A3; Wed, 29 Mar 2023 09:10:14 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 181A6201D9953; Wed, 29 Mar 2023 09:10:14 +0200 (CEST) Date: Wed, 29 Mar 2023 09:10:14 +0200 From: Peter Zijlstra To: Wenyou Yang Cc: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, evan.quan@amd.com, mario.limonciello@amd.com, bp@suse.de, jpoimboe@kernel.org, kim.phillips@amd.com, tglx@linutronix.de, weiyuan2@amd.com, richardqi.liang@amd.com, ying.li@amd.com, kunliu13@amd.com, gpiccoli@igalia.com, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] cpu/smt: add a notifier to notify the SMT changes Message-ID: <20230329071014.GC7701@hirez.programming.kicks-ass.net> References: <20230329015149.870132-1-WenYou.Yang@amd.com> <20230329015149.870132-2-WenYou.Yang@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329015149.870132-2-WenYou.Yang@amd.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2023 at 09:51:48AM +0800, Wenyou Yang wrote: > Add the notifier chain to notify the cpu SMT status changes > Why!?!? What's the purpose of all this? IIRC this doesn't trigger if you manually disable all the siblings. And because you didn't tell us why you need this I can't tell you if that matters or not :/