Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp245791rwl; Wed, 29 Mar 2023 00:49:47 -0700 (PDT) X-Google-Smtp-Source: AKy350a2Z1LqaE+fgBREDhx/eV7FFzV/1mS1M65o2akVy6gx1bChxg8knxqOjzV7ZYlUsJ/ilx63 X-Received: by 2002:a17:907:20ee:b0:930:6e31:3c11 with SMTP id rh14-20020a17090720ee00b009306e313c11mr19683851ejb.70.1680076187132; Wed, 29 Mar 2023 00:49:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680076187; cv=none; d=google.com; s=arc-20160816; b=cwTb9AZSdcAqtY8nVsLz6kWDHCEOGXyZKNzBkrR4MnT0BpXAeLIXg0g1vi0JNrL/st Wburm6iOm/5xgz3c8l8RGpARukBdYCbC4dWrNNMcWN/Hd3b53dVfnL2X1vuln3O+3FjS WajbOgu0f2ZnKYXNq+QJU01xkRFZv/kaORzJPoECfgqfy+NTecyGeWiVClXmUNrGrcl4 NEsfGbOSYsl6XOBCxVQYLyfQ4k3EZ6cW2d+ZIVwNXmtP5LlxNzV+IR9wHqMYB9m/nEMc /vW9m/Da4ajdiECgsD64olUzZLa0Llw2nd6u/xuAf7DrR76XoYioUNdvdWxwFGSM6UXW qJZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=kIcX0dBKom6AOaVB5KBIqAc4COlmXL2yMEl0MUAWiKw=; b=pfl3N6dlqQhFMhY9QKoNKrW13HymWA/fV2jSrF7SoEauXgd4woxLVotn7woe3h52T5 zqedS8aUoKJS2KrfRNetDn2wizlcDA+D4BFk+ZEToJykiQFrVnr2GymcEKS4W2zXfHL9 BJo1pLrkR2u8FdEdH8gqqwiJKrczgGjQk0X88N8P+ueZJpisoW3nyUc6/cVhTC55P7cR cOAYBKyUQUodrC9CCEwWKuBrcS2feMQ3CB+FYSH0GMWt+xhuSOdxtfyQ7XLBxZGhszU1 8evSObP6AR5+kktT4Q5me11BpuVjsEi3NyUFfBFaljsBvBd9JB0UIETJ9s4yzMQQhs5Q pjyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="U7sq/FG5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a18-20020a170906191200b008df5a5088bcsi22301387eje.123.2023.03.29.00.49.22; Wed, 29 Mar 2023 00:49:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="U7sq/FG5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229513AbjC2HrS (ORCPT + 99 others); Wed, 29 Mar 2023 03:47:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjC2HrQ (ORCPT ); Wed, 29 Mar 2023 03:47:16 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15D6E211B; Wed, 29 Mar 2023 00:47:15 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32T74G4i019840; Wed, 29 Mar 2023 07:47:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=kIcX0dBKom6AOaVB5KBIqAc4COlmXL2yMEl0MUAWiKw=; b=U7sq/FG5tOvDut0tCxDGQk0jFiScF8PXpplP8oO2GYjpyLLmp0wuKTqN/PLkHP98z6Yo AAGUZxQzPiCziJFmgSA4JwBeuuRTqVWDEtk2r43qtraoQnAd/tDLOZzZmpEVhigFsmOB +E+WzHuL7ZEodTemwuKd7TFXfG6GLWsMKlobKBIbnVxQHLS3AP2mKyHJbAsrDUC8DF7J JNh6V9A49GIDbhquSUpbMEh17OdYTeamGrZupaZzSm7X/2SvAlcTISjB7CtKAku0l8YX Jx4JqR5QemlMo1gmcz7zlpjE3SZBVlFnhyHsGJiT8yidhp3p2ukZi8uBo982WDmZIZhy vQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pkx4tatdw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 07:47:06 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32T7l5ne013145 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 07:47:05 GMT Received: from hu-mojha-hyd.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 29 Mar 2023 00:47:02 -0700 From: Mukesh Ojha To: , , , CC: , , , Mukesh Ojha Subject: [PATCH v6 0/5] Refactor to support multiple download mode Date: Wed, 29 Mar 2023 13:16:47 +0530 Message-ID: <1680076012-10785-1-git-send-email-quic_mojha@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: LOpR2KRacpGMbmMVwk57Pz0_qw0BfzCh X-Proofpoint-ORIG-GUID: LOpR2KRacpGMbmMVwk57Pz0_qw0BfzCh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-29_02,2023-03-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303290063 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Intention of this series to support multiple download mode and only modify the required bits during setting tcsr register. Other download modes are minidump, full dump, both fulldump + minidump, nodump. Latest minidump kernel driver patches has been sent here https://lore.kernel.org/lkml/1679491817-2498-1-git-send-email-quic_mojha@quicinc.com/ Also, this series should be applied on https://lore.kernel.org/lkml/1678979666-551-1-git-send-email-quic_mojha@quicinc.com/ Changes in v6: - Applied suggested API change(at v4) by [dmitry.baryshkov] Changes in v5: https://lore.kernel.org/lkml/1680017869-22421-1-git-send-email-quic_mojha@quicinc.com/ - Tried to fix the issue reported by kernel test robot https://lore.kernel.org/lkml/202303280535.acb66sQT-lkp@intel.com/ - Applied some of the improvement suggested by [Bjorn.andersson] . Dropped 'both' instead support full,mini or mini,full for setting download mode to collect both minidump and full dump. . logging improvement. Changes in v4: https://lore.kernel.org/lkml/1679935281-18445-1-git-send-email-quic_mojha@quicinc.com/ - val should be shifted within the function [srinivas.kandagatla] i.e new = (old & ~mask) | (val << ffs(mask) - 1); - Added Acked-by [linus.walleij] on pinctrl change. Changes in v3 : https://lore.kernel.org/lkml/1679070482-8391-1-git-send-email-quic_mojha@quicinc.com/ - Removed [1] from the series and sent as a separate patch[2], although this series should be applied on top [2]. [1] https://lore.kernel.org/lkml/1677664555-30191-2-git-send-email-quic_mojha@quicinc.com/ [2] https://lore.kernel.org/lkml/1678979666-551-1-git-send-email-quic_mojha@quicinc.com/ - Introduce new exported symbol on suggestion from [srinivas.kandagatla] - Use the symbol from drivers/pinctrl/qcom/pinctrl-msm.c. - Addressed comment given by [dmitry.baryshkov] - Converted non-standard Originally-by to Signed-off-by. Changes in v2: https://lore.kernel.org/lkml/1677664555-30191-1-git-send-email-quic_mojha@quicinc.com/ - Addressed comment made by [bjorn] - Added download mask. - Passed download mode as parameter - Accept human accepatable download mode string. - enable = !!dload_mode - Shifted module param callback to somewhere down in the file so that it no longer need to know the prototype of qcom_scm_set_download_mode() - updated commit text. Mukesh Ojha (5): firmware: qcom_scm: provide a read-modify-write function pinctrl: qcom: Use qcom_scm_io_update_field() firmware: scm: Modify only the download bits in TCSR register firmware: qcom_scm: Refactor code to support multiple download mode firmware: qcom_scm: Add multiple download mode support drivers/firmware/Kconfig | 11 ----- drivers/firmware/qcom_scm.c | 88 ++++++++++++++++++++++++++++++---- drivers/pinctrl/qcom/pinctrl-msm.c | 11 ++--- include/linux/firmware/qcom/qcom_scm.h | 2 + 4 files changed, 86 insertions(+), 26 deletions(-) -- 2.7.4