Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp248081rwl; Wed, 29 Mar 2023 00:52:14 -0700 (PDT) X-Google-Smtp-Source: AKy350YV/UIt9F9p8Rag+CH/1Vn5ECA04mnO89zLsee4sYqlYUnO25bQGFHzjNpkAxdo93f/MwtR X-Received: by 2002:a17:90b:4d0d:b0:23d:1948:667d with SMTP id mw13-20020a17090b4d0d00b0023d1948667dmr18937312pjb.35.1680076333931; Wed, 29 Mar 2023 00:52:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680076333; cv=none; d=google.com; s=arc-20160816; b=HLGfobg5bg49okxxdSQYtza59rfK0V+xQIAL0CafAJFMq/4GAEt614zlGXJuyNYuwg 1y60Wj5jjfUItdlYZG4SLe5odUdduxJJNksO46pqrAVLJWmKwOo91VrJrMsLHMm1brGB Xs0u9k64ABMTteslUH13c1Q4rrkhcMDDTRiiHvu4k+9IcyMJEdxaZF3Bb2sXmFsHZCQa Cn3Deb2xxlzNovUaO9PG5wlhi5zDFL3T2g/AJG0EWnFPYDO3BmSe0Y22gEmFpUmyMo+7 BTnpFYa08+9DMfS8qL4i4X3yVnujliKef6KHnmBUOjMtgLXj89oM/PjbI8laaYrCgafK KFsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=DeavIEJPp0sfdmi/B+fdKHYkBNKqu0TcSUAUs1ORkv0=; b=Q7p8z91MD+oMq4LhTRCZigVYqb3qIPRltJpOtqnxTtgSENecCxx/8B5BxITe9MgOvF B1rouFuDR6SDxLsAR0jUwKEHf6s4vmQnpra89cgx+BEEtr2mHdqVDeregrRuCe4cbNNn tnoU8lWBu2N8GsVSVXsqHVi/FN1SGQLLXS/sE8R8eFSKMk32OeoCSISdLZEstQcT9FKL Uk1qWygoJNpb0CeUXMUPBRmsCk3YoYS8W4HjAWiY3wjN8+nAR97HdxShM3Ep+2hKjXnN OkWpdkRL8eTJHEQeNLqWQyhSuuMAv0T7eKRyGSI+pZDMNDbZ+2JjTzYn1o5UfibEVma0 J2cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="Ro/mg91g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020a170903228200b001a005da8b2csi32220528plh.599.2023.03.29.00.52.02; Wed, 29 Mar 2023 00:52:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="Ro/mg91g"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbjC2Hvl (ORCPT + 99 others); Wed, 29 Mar 2023 03:51:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230146AbjC2HvU (ORCPT ); Wed, 29 Mar 2023 03:51:20 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 960A04200; Wed, 29 Mar 2023 00:50:50 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32T3TDan004505; Wed, 29 Mar 2023 07:50:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=DeavIEJPp0sfdmi/B+fdKHYkBNKqu0TcSUAUs1ORkv0=; b=Ro/mg91gCRcHn0l6bjigIcXydkZ3JU0OmCVCyKscHUUGm+d4RKHxNoWiiP3MUw1eR5TJ +sW3nP6ckkczR0kMh8N8tEbkDpQ29Hm+r9DObeq3NZ/8gV/eXEadZaozOmzXMcOdDdCy sdB+OH9gfzNyXS6UxBosSANNIz4JQu04yfLFKFK10/Sd2xtHksBUkfFn/sXM/hF6i5bK uMPFjck6GZ+pCzbn9YedtqddXYMCC0vlhCQ4Ze0V9Egxu1aOWqQmbjiDfQwKRDoTwYpU wV2u39TcRtQYCglptWjXcTApT1O35toenYadNEZjwsziwpwAyasKzM8cf2C7jx5hmjdB ig== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pkx4tatmv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 07:50:43 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32T7ogVn025511 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Mar 2023 07:50:42 GMT Received: from [10.252.221.243] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 29 Mar 2023 00:50:38 -0700 Message-ID: <3f7a901f-4deb-1855-4f8c-9a7c3015d641@quicinc.com> Date: Wed, 29 Mar 2023 13:20:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v3 18/18] arm64: dts: qcom: sa8775p-ride: add PMIC regulators Content-Language: en-US To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski CC: , , , , Bartosz Golaszewski References: <20230327125316.210812-1-brgl@bgdev.pl> <20230327125316.210812-19-brgl@bgdev.pl> From: Shazad Hussain In-Reply-To: <20230327125316.210812-19-brgl@bgdev.pl> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: V07c5niNn2cG39Gd4yrIMGunaaXy8cM3 X-Proofpoint-ORIG-GUID: V07c5niNn2cG39Gd4yrIMGunaaXy8cM3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-29_02,2023-03-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303290063 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/27/2023 6:23 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add PMIC regulators for sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 233 ++++++++++++++++++++++ > 1 file changed, 233 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index a0d2024a69df..fdd229d232d1 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -5,6 +5,8 @@ > > /dts-v1/; > > +#include > + > #include "sa8775p.dtsi" > #include "sa8775p-pmics.dtsi" > > @@ -25,6 +27,237 @@ chosen { > }; > }; > > +&apps_rsc { > + regulators-0 { > + compatible = "qcom,pmm8654au-rpmh-regulators"; > + qcom,pmic-id = "a"; > + > + vreg_s4a: smps4 { > + regulator-name = "vreg_s4a"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1816000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s5a: smps5 { > + regulator-name = "vreg_s5a"; > + regulator-min-microvolt = <1850000>; > + regulator-max-microvolt = <1996000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s9a: smps9 { > + regulator-name = "vreg_s9a"; > + regulator-min-microvolt = <535000>; > + regulator-max-microvolt = <1120000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l4a: ldo4 { > + regulator-name = "vreg_l4a"; > + regulator-min-microvolt = <788000>; > + regulator-max-microvolt = <1050000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l5a: ldo5 { > + regulator-name = "vreg_l5a"; > + regulator-min-microvolt = <870000>; > + regulator-max-microvolt = <950000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l6a: ldo6 { > + regulator-name = "vreg_l6a"; > + regulator-min-microvolt = <870000>; > + regulator-max-microvolt = <970000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l7a: ldo7 { > + regulator-name = "vreg_l7a"; > + regulator-min-microvolt = <720000>; > + regulator-max-microvolt = <950000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l8a: ldo8 { > + regulator-name = "vreg_l8a"; > + regulator-min-microvolt = <2400000>; Hi Bart, Internally with PMIC2.0 i.e K2 upgraded board we were seeing target crash when kernel votes for 2.4V with fault monitors enabled in K2. So let's keep the recommended value <2504000> for ldo8. -Shazad > + regulator-max-microvolt = <3300000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l9a: ldo9 { > + regulator-name = "vreg_l9a"; > + regulator-min-microvolt = <2970000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + }; > + > + regulators-1 { > + compatible = "qcom,pmm8654au-rpmh-regulators"; > + qcom,pmic-id = "c"; > + > + vreg_l1c: ldo1 { > + regulator-name = "vreg_l1c"; > + regulator-min-microvolt = <1140000>; > + regulator-max-microvolt = <1260000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l2c: ldo2 { > + regulator-name = "vreg_l2c"; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <1100000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l3c: ldo3 { > + regulator-name = "vreg_l3c"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1300000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l4c: ldo4 { > + regulator-name = "vreg_l4c"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1300000>; > + regulator-initial-mode = ; > + /* > + * FIXME: This should have regulator-allow-set-load but > + * we're getting the over-current fault from the PMIC > + * when switching to LPM. > + */ > + }; > + > + vreg_l5c: ldo5 { > + regulator-name = "vreg_l5c"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1300000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l6c: ldo6 { > + regulator-name = "vreg_l6c"; > + regulator-min-microvolt = <1620000>; > + regulator-max-microvolt = <1980000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l7c: ldo7 { > + regulator-name = "vreg_l7c"; > + regulator-min-microvolt = <1620000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l8c: ldo8 { > + regulator-name = "vreg_l8c"; > + regulator-min-microvolt = <2400000>; > + regulator-max-microvolt = <3300000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l9c: ldo9 { > + regulator-name = "vreg_l9c"; > + regulator-min-microvolt = <1650000>; > + regulator-max-microvolt = <2700000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + }; > + > + regulators-2 { > + compatible = "qcom,pmm8654au-rpmh-regulators"; > + qcom,pmic-id = "e"; > + > + vreg_s4e: smps4 { > + regulator-name = "vreg_s4e"; > + regulator-min-microvolt = <970000>; > + regulator-max-microvolt = <1520000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s7e: smps7 { > + regulator-name = "vreg_s7e"; > + regulator-min-microvolt = <1010000>; > + regulator-max-microvolt = <1170000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s9e: smps9 { > + regulator-name = "vreg_s9e"; > + regulator-min-microvolt = <300000>; > + regulator-max-microvolt = <570000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l6e: ldo6 { > + regulator-name = "vreg_l6e"; > + regulator-min-microvolt = <1280000>; > + regulator-max-microvolt = <1450000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l8e: ldo8 { > + regulator-name = "vreg_l8e"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1950000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + }; > +}; > + > &i2c18 { > clock-frequency = <400000>; > pinctrl-0 = <&qup_i2c18_default>;