Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp292367rwl; Wed, 29 Mar 2023 01:42:37 -0700 (PDT) X-Google-Smtp-Source: AKy350a75JF6S3aFCbxh8T4Cc6xoSeZssvCw93IN4bxoxbdYNoxdb+bFgG/p7p8i84WdxYc2c6xd X-Received: by 2002:aa7:968b:0:b0:627:e61e:1ae with SMTP id f11-20020aa7968b000000b00627e61e01aemr17354316pfk.12.1680079356706; Wed, 29 Mar 2023 01:42:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680079356; cv=none; d=google.com; s=arc-20160816; b=Rbpp6tpS0hACYW71H0AlhUGNpaDofU3rt7shWBwZOVO5vQRXZ75q9+3L2Q6qXeF7Xn onLblsxFqurxXMXlBqLmBnq0m4lPP1uh2WxnrNL4us699ajkpTxK7i6wltbw9U2CFizA 30BciO/JUWKdKQBEs3QPUf1COqalb2wIXDn/0JgqVFGtx9C5M1bL6E3srd3R2UAnssnT UbRorRak2NzVJ3g6I1jx54eaQqnDPSdo+5JUBKU7P6YSXE/uODIARJkl2aZKId62zIGn +a7cjUrszFmb02lSL2Ymwc4n9mDC6XfC2bQJbjH4gWoTVyg/ZY0tx2fNZcFMdB7gQ279 VG7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LL/sWQwDg4vJiqXxhuyAwctaH9txvoTopFpNPSWv9Vk=; b=OgbVt6jAI5xyerEoh7H4kRi5sp0GRcKFDpLMaJulivjvTaOFQ+qSTJTEK6ggHqfhXX +yrL8zZpJV/fNlvPnGr0VNICUKRadSxCte2HXQKrPeWqGBu4J1LhCESSanYl50cRiFvP iHgs/gS16RQeALmTX+VchdoV0h8gISZI8bq5rOlNEJ70RYLWvq9S/2OFH+pDWnhXvrbQ arV6zjdN0SgMI2UMVB6z4V3Vhzh3G326zyUaaDu6DM2juiV0Hxwyp4TK9OQpCqZ25i81 CUimYoxUk2rjMkhtcXOzrjvCv10iY3O3nsZnw0UcnzqDCMEWtncC2BFHXCrEOSG6Pg2R G/0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xxft1Pea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k62-20020a638441000000b004fb961e0592si31424747pgd.565.2023.03.29.01.42.25; Wed, 29 Mar 2023 01:42:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xxft1Pea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230105AbjC2IiS (ORCPT + 99 others); Wed, 29 Mar 2023 04:38:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229787AbjC2IiR (ORCPT ); Wed, 29 Mar 2023 04:38:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE1D71FE7; Wed, 29 Mar 2023 01:37:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14CDB61B84; Wed, 29 Mar 2023 08:37:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9465C433D2; Wed, 29 Mar 2023 08:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680079074; bh=9ifbxrOQWPIeIXQUfOAAtE87FHbtT0f+fZkTonCJ/Us=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xxft1PeaaYNLisckSI8Z/hoioHg82A5kC7yJu2lWb4T9zohW1rdetadLv5/uVFXyn pqwA8YnR5QTfQHI+C67SG25cxxS9fFovQ4g/CEVRTgUTJfvQUeiMRHKJ0QIcfAoAw0 3riuWImoqblZDWEA0wo8uKQoavlyRxAbAvFJSuqE= Date: Wed, 29 Mar 2023 10:37:51 +0200 From: Greg KH To: Pawel Laszczak Cc: peter.chen@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] usb: cdnsp: Fixes issue with redundant Status Stage Message-ID: References: <20230321124053.200483-1-pawell@cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230321124053.200483-1-pawell@cadence.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2023 at 08:40:53AM -0400, Pawel Laszczak wrote: > In some cases, driver trees to send Status Stage twice. > The first one from upper layer of gadget usb subsystem and > second time from controller driver. > This patch fixes this issue and remove tricky handling of > SET_INTERFACE from controller driver which is no longer > needed. > > cc: > Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") > Signed-off-by: Pawel Laszczak > > --- > Changelog: > v2: > - removed Smatch static checker warning This is already in 6.3-rc4, right? thanks, greg k-h