Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp296252rwl; Wed, 29 Mar 2023 01:47:20 -0700 (PDT) X-Google-Smtp-Source: AK7set+Xdx1MJpOvvTaFtDshYYO8Mgx5SJcvbSWMTq/NFZdqxn1S/Kvbr2y40hxvrNFYWefWeJjY X-Received: by 2002:a05:6a20:4e1a:b0:d7:34a1:85b9 with SMTP id gk26-20020a056a204e1a00b000d734a185b9mr14702875pzb.7.1680079640611; Wed, 29 Mar 2023 01:47:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680079640; cv=none; d=google.com; s=arc-20160816; b=U+YO5CG7s16DKGxHrrfqVSbbqM0mxpTo7fPc6MCur4uEiOJDLhfzN1Zysk4VGQWfwe sHwICkhY7d+NDpCIYrvWxsITh5aSrx07TY6rO37BcJVttQ0MWjz25A5xRsr2GyK31a7Z KYncuGBa8T1TYDI6QGkWcrUwrTcCxs5rnCsxHy6RsTt8mhLm+fKYnpI/nDIGUK/PSJer OXSLKDTSHR6cTUg81fydVcQP5VqhwBPNMPUZ0fbAP7o/M2rVaw0n8h2lcw7kNWL8i+Bj Lcsl0/gHxFqRkgFXQQuFQwxPzrUkjOtyYxtE/7EL5d//NqYszoR9lkjvlSXWF9aKDffh qF2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=11JaD7hdMGYDMEVM2bxoT0TPTbslQdWxsEeb3qIPYls=; b=J8OHdd5EIrZoS4BQWCHo8koAc/ypHoFY/7VlGWuISV0SKmndxiPyVIyvyslzpWZAhr 1gTmKZr91qWZfhHVCmOyTbJqhghT6SUViHKZtqJuNupdykhpwKN+PQD/tLLOoG/Akqc5 O/vHdRchCtQMUAffWyhtwiVc9pLm7N+41e5EAYLpAsA/+H6YYPLKuKG9xePQNylD5iF6 P1jRFipYcaTmUcNCtIOB+LmY5vtYSzQZ46z+BI0MYTdf9vxHMbp1Ovmkw8GGPHqLUiA6 SPSQFACqCQ4PqR87igndNIYxLvuBd3UcVKsn6YyZPXOd5CUu+AkzjvHpBesHgflZDFkW tx/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="F/o42EqN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l21-20020a056a00141500b005a71564af37si31234999pfu.362.2023.03.29.01.47.08; Wed, 29 Mar 2023 01:47:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="F/o42EqN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231211AbjC2Iou (ORCPT + 99 others); Wed, 29 Mar 2023 04:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbjC2Ios (ORCPT ); Wed, 29 Mar 2023 04:44:48 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E43B41FEE for ; Wed, 29 Mar 2023 01:44:46 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id b18so18396595ybp.1 for ; Wed, 29 Mar 2023 01:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680079486; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=11JaD7hdMGYDMEVM2bxoT0TPTbslQdWxsEeb3qIPYls=; b=F/o42EqN0ifcxbRNd2+xZEitnwqM3+QHnI4io7mZ8NINwIjSuv6zRlWQKAnB0xn8JZ xqC9xpLrnqHJ1583+emjfoQUQIvaptA5QNA3Ve/9P21GdEOPBwhecYZ7ZrBrmXgHxd0X 34pz6cHbfQzaSiwaRhsvYkuq6D7Mj3d5y2cpHJKCXJRe0Pob7g90/kVZQjgzxK0NjIiQ bPA+AXBN/E8AU0UzMjylFIuBEqTe2EBiaEnywlhplY+UDDgQkFQEP9iIrjoQt0w6pVdc gpajMqQnK/xBB/d1YndivVpogE0QOTwVTQK+djV+pW+UqNgLn9631XK5Rk2Ae6NdUqu7 et8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680079486; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=11JaD7hdMGYDMEVM2bxoT0TPTbslQdWxsEeb3qIPYls=; b=nKtip0Ml5cxi4KSEL/8wHnWM3mtH4dlwU7mvZ/fh1ywzdFF0F6LSDejlhGnZO2ntDQ hP/Mvp4TakAZv+ZWYkcGbNg6NTf200pFi773xsriEcgmbQu64DK/ZwtO+smKu4maBaX7 TB9ErizssPZkr5FfnjgwFi4z5AH/R8qfSoDbg7X3VZ5kFOFG00iVM7W0GHhyBT5PUjTA cn1W441m7vfaqZG1bevkojehYRgpuOddDAWmmkXJto9SvSS3XhvppwueB3vnJ9m2aGFO mA0gn5DBVQ6wJv2a173VhH9SqiiKBB6h/sLshhEYkO71P+shcTpGBIXSQUCj+ln2rExZ XlBA== X-Gm-Message-State: AAQBX9fKjjXIFJwmwy0HCpyeP5yZuhOv/Sg69Yx34k7ldj4Zf4WKGPrz Vn2o9NxIe/uQwZv/Z/ocuGw+APA4QNM4E/haivp3iQ== X-Received: by 2002:a25:8712:0:b0:b74:3236:2fac with SMTP id a18-20020a258712000000b00b7432362facmr11757896ybl.4.1680079485954; Wed, 29 Mar 2023 01:44:45 -0700 (PDT) MIME-Version: 1.0 References: <20230323205733.20763-1-asmaa@nvidia.com> In-Reply-To: <20230323205733.20763-1-asmaa@nvidia.com> From: Linus Walleij Date: Wed, 29 Mar 2023 10:44:34 +0200 Message-ID: Subject: Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits To: Asmaa Mnebhi Cc: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2023 at 9:57=E2=80=AFPM Asmaa Mnebhi wro= te: > If the "ngpios" property is specified, bgpio_bits is calculated > as the round up value of ngpio. At the moment, the only requirement > specified is that the round up value must be a multiple of 8 but > it should also be a power of 2 because we provide accessors based > on the bank size in bgpio_setup_accessors(). > > Signed-off-by: Asmaa Mnebhi Neat fixup, Reviewed-by: Linus Walleij Yours, Linus Walleij