Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "peter.chen@kernel.org" <peter.chen@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2] usb: cdnsp: Fixes issue with redundant Status Stage
Thread-Topic: [PATCH v2] usb: cdnsp: Fixes issue with redundant Status Stage
Thread-Index: AQHZW/J1HcM0SYCPZESHq1PJrSRph68Re5qAgAADfbA=
Date:   Wed, 29 Mar 2023 08:52:43 +0000
Message-ID: <BYAPR07MB538165F56DB6C42E6732BB34DD899@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20230321124053.200483-1-pawell@cadence.com>
 <ZCP435eCZhIIxesr@kroah.com>
In-Reply-To: <ZCP435eCZhIIxesr@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Eq0IJyJgmJXhngBeh7+s0Zl2YA7yXxsD3+0ZJs2AkaRCtXgQkKO7+OGXVQzQ?=
 =?us-ascii?Q?KMJvgFLwWGwhrBu9WYXr1mqnj91z+ladx04032ASB9emj7kcwMvbe2Th6aes?=
 =?us-ascii?Q?Jqk34flX3OicgnyXDAHNSh8Q8Pw7k7nBEz5BlCCXSvEb2OV9Sn3zFjWs/bUh?=
 =?us-ascii?Q?i+EiMqTWvQ7uLVUjzFFCzjqwJsszunnkLsVAvRr6s/4ZHeemkJppaAH0xeMU?=
 =?us-ascii?Q?jAyOoEmK0U/N8w8H12MMwAUiy9PPjChk6bZw3NUwD7QV49r5d04eKEIPq1A2?=
 =?us-ascii?Q?KMGet0WRzk7tQNF8tim8ko53Lyi+b8SXlVzh2PSSCUEtGTiN9TxXwfIoy5zN?=
 =?us-ascii?Q?XLWTThmiYATS9HWkpA/Wg4Z0y2y9Wi6Ao9N8lNxLQUyxD1csur3bNuqlj3p4?=
 =?us-ascii?Q?nRAujR5aLksp8DfORVm/MJloHoR5HV4NaSa/T3+HQzNAm3PHLjTIyjdU/sX6?=
 =?us-ascii?Q?gVdYJWSNRVjDt1AMmFSfqfwaaplZLjINp8vQZl9/7w/geXkIQ0WBvSmzlGMl?=
 =?us-ascii?Q?BgXtB4AQkZq7/J2uXU9zTKIclnGzkmek8anT90mf5QVk/zM44f4vdqlPx/pU?=
 =?us-ascii?Q?+HYzvK4I+//AvF/I+k5WEm+LJcY+DY7dvkqg2N2LmofpOsle9XGvZOt3mkf3?=
 =?us-ascii?Q?etY1KDHq8zqRNvRXZFFVNzHac1zu+NPkDF+WJbHP2xf1sOi8U6iVfySx44Mu?=
 =?us-ascii?Q?GxMs5H8Y3PAdFDMf0O9KUlb9575YB9aa5RaHyAJIGsgSIl8/RrFTXHHMh7xw?=
 =?us-ascii?Q?aBa+cVsNkrVfvmRKVS65pSsCmDwj68znZid+nKyVM38cw09YK2wYDPXcsYu2?=
 =?us-ascii?Q?6CTQU7yLqsxJbPpNX5qtzuCqheeWmg5wOpjvqG7n7D4hrBxLg5Q0w97Zd9UH?=
 =?us-ascii?Q?EhyDNDl2UiYVkE5xZ+o93eqfkptQt3Gzlj02yqvSQp87yyFMmkQNmtXzPksu?=
 =?us-ascii?Q?8W55qpKK11xC74ndq7aPpsRXaHllA8DQLiACDBx2Kv9vbHQNqiH/i4eXegSj?=
 =?us-ascii?Q?ZewfRahczeE/EnLX+7BfcpnKrXQpNKrwNZEc8AFLHqTL5RyRJsQ6Njyh+SkL?=
 =?us-ascii?Q?u1e9mCJnHGM4HgNwhgDJrSf+jECVi2xEuDY2p9Fv1JkjWgiqltAn9CUTsyEh?=
 =?us-ascii?Q?21vl879SVdCEIzTpFRtasSNafh/C0qUbZMUZSw1BgPBT81YgPejevpNrZIdU?=
 =?us-ascii?Q?5W6hpK5so5B81EF/tGltbbOLC+ejMr7RjlyfE/dUf3sUT9PZVftfrUeazzHs?=
 =?us-ascii?Q?Ep2V6jPEn2WBuqirn1UC4GWbyAOHsENeC943P8H62/eAV8JDqtRT/Ho9gVSp?=
 =?us-ascii?Q?HMXQZxqZfmyqCytC85zg2z9ghfYF//NSJdMEuYP8pJywFqe7uDwzYaEe0/c2?=
 =?us-ascii?Q?n/v2uX1eo4qjLlnFuuzxee0IOBj3T0Jkio4EEblto25mSncVwOaaMSm8zpAB?=
 =?us-ascii?Q?Vt7OgDroIchya2fGxVONdczVYH0sTfcFuWSWvt2ng716j7K1/DKiXJC+7bV/?=
 =?us-ascii?Q?NYOyxtN3YZaTfDjrljE4WKOPIQTQfSieT2dinRhBJv2bd2SHooLI986vhIw6?=
 =?us-ascii?Q?fjykxRB7yJ84ryrJDsWsD/IruD1wEeD8/gOVN37u?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d334fef-3d38-4f4c-1f19-08db3032f5f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2023 08:52:43.5619
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZFdn1ino23MikNteiZ4vxJbKKrDnXw8WVlYkSeRSLFMdFVHh5SeBHgPD+QsiUh7QY869KHAAAzpuH7YiqfoMO8I2zI6qhW545fP4aUS4/zE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR07MB8003
X-Proofpoint-GUID: 0eTqa7pQ1SxSxENyinCZKZc21PuxJ_lm
X-Proofpoint-ORIG-GUID: 0eTqa7pQ1SxSxENyinCZKZc21PuxJ_lm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-29_02,2023-03-28_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 phishscore=0
 impostorscore=0 adultscore=0 priorityscore=1501 mlxlogscore=438
 suspectscore=0 clxscore=1011 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2303200000 definitions=main-2303290073
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>On Tue, Mar 21, 2023 at 08:40:53AM -0400, Pawel Laszczak wrote:
>> In some cases, driver trees to send Status Stage twice.
>> The first one from upper layer of gadget usb subsystem and second time
>> from controller driver.
>> This patch fixes this issue and remove tricky handling of
>> SET_INTERFACE from controller driver which is no longer needed.
>>
>> cc: <stable@vger.kernel.org>
>> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence
>> USBSSP DRD Driver")
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>
>> ---
>> Changelog:
>> v2:
>> - removed Smatch static checker warning
>
>This is already in 6.3-rc4, right?
>

v1 is in 6.3-rc4.

v2 fix the following issue:=20
The patch 5bc38d33a5a1: "usb: cdnsp: Fixes issue with redundant Status Stag=
e" from Mar 7, 2023, leads to the following Smatch static checker warning:

	drivers/usb/cdns3/cdnsp-ep0.c:470 cdnsp_setup_analyze()
	error: uninitialized symbol 'len'.=20

Regards,
Pawel