Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp312585rwl; Wed, 29 Mar 2023 02:05:13 -0700 (PDT) X-Google-Smtp-Source: AK7set+MkEunzHyIr2bHeq/zWV4ZuhI+P+TfPmUwvxkkjiB2T2g4oOCY4FrnGLzDaQvygdMoVEJK X-Received: by 2002:a05:6a20:2a0a:b0:db:5ff5:8f21 with SMTP id e10-20020a056a202a0a00b000db5ff58f21mr15011543pzh.15.1680080713332; Wed, 29 Mar 2023 02:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680080713; cv=none; d=google.com; s=arc-20160816; b=rdt/Q7OZs6nD15FOhMpmE7FD1cEC3MiYO78YxxzaArxQSjgr44I/g+scIpjmJDw1AH 5ijXch/6mdbaOA9WeAbW1hd4xkuxV5Qtq1wyQrQNEasKiwElOMZFs0iKf91zEBB+OZ+g ClzBQP9wMRLRfUak3LUpZFrqCPC+TYE6p3yFRq/kKHf48FPunLl5xg/3ZEKyGp5TsQYq jrENjeF3PTOPR69+IYH23fLd7wmSNFVBmX4VlcEKjgRSqDEJ/CG1QBII3HxSggQ3Y9H7 ezlbUhRwXRGei5PevS0Zex+wj7XE52NKqf9/3+1kF2cNdtYjVdlSjRpE7E/pvadybVA0 jr6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature:dkim-signature; bh=WI8BEur271kmRLX+iQ3dCgc++8Y7H/Sb22u2MuBKC3U=; b=nI3C4DcbRpxh8ZytxwlRY4crGaeOf2YkQKnHWZC+dc0YHE4GPAG/VsO70uJZ5HKymY DVv73+yiLqftAwz/f3SHVS/UAi+AVoEYsiXLM1WtYSwGOGNarbFI3QuY8o6GVhngbQdd x65RgfddRyHzXgVeK4hJJbzQ75KId6ILxcBYHrZ81OdYx+UY7OY2G4NqqRMbSqlCDef5 311ZzyC8rBKYbaSkod1jqIJB6Z1Ajtaw4H1GLT6XZORIUOQ251swdkj95ttx8RlKRAQX ULpogfebo3VrZB878IA5HtFS6cpytRqWXM0qEHiA1WuoHH8qz78Eakwc9FcYAy6J+W2y R+AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QSPIpQ5Y; dkim=neutral (no key) header.i=@suse.de header.b=Z1HP6E2s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q192-20020a632ac9000000b004fb2685a0d4si31770998pgq.621.2023.03.29.02.05.01; Wed, 29 Mar 2023 02:05:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QSPIpQ5Y; dkim=neutral (no key) header.i=@suse.de header.b=Z1HP6E2s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbjC2JEm (ORCPT + 99 others); Wed, 29 Mar 2023 05:04:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbjC2JEi (ORCPT ); Wed, 29 Mar 2023 05:04:38 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E0CB4C26 for ; Wed, 29 Mar 2023 02:04:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E3F5E1FDEE; Wed, 29 Mar 2023 09:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680080657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WI8BEur271kmRLX+iQ3dCgc++8Y7H/Sb22u2MuBKC3U=; b=QSPIpQ5YRhu893vZR0iyN3n0CXQDjeYSRjqwnfEJqEkpgg6IHe01OYUU2E2iOiI4rBIKa2 xMmPcsYe4mF3XqlDRB18M0ZLuffljo8b1I1AeYjv+ZgFtRB2qMH5Ms5FQdrqqrkbLL1ed1 Hgr3gF/TKhxIlx6ETbIMsW80dIMWaww= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680080657; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WI8BEur271kmRLX+iQ3dCgc++8Y7H/Sb22u2MuBKC3U=; b=Z1HP6E2sFLC8jHRsyFCgM3+K2WnPZN8MticJlPvngve1MhEsveBn3+zQuqqld4AhG08700 7okLTzBp+j04HDBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF2A2138FF; Wed, 29 Mar 2023 09:04:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8lLbKRH/I2SrdwAAMHmgww (envelope-from ); Wed, 29 Mar 2023 09:04:17 +0000 Message-ID: Date: Wed, 29 Mar 2023 11:04:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause Content-Language: en-US To: Sui Jingfeng <15330273260@189.cn>, Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , suijingfeng , liyi , Lucas De Marchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230325074636.136833-1-15330273260@189.cn> From: Thomas Zimmermann In-Reply-To: <20230325074636.136833-1-15330273260@189.cn> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------W5PV5cs8SW7uIpRGdJnqPZ9g" X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------W5PV5cs8SW7uIpRGdJnqPZ9g Content-Type: multipart/mixed; boundary="------------7A3L9aq7RwQin8oMsHpBOdqi"; protected-headers="v1" From: Thomas Zimmermann To: Sui Jingfeng <15330273260@189.cn>, Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , suijingfeng , liyi , Lucas De Marchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause References: <20230325074636.136833-1-15330273260@189.cn> In-Reply-To: <20230325074636.136833-1-15330273260@189.cn> --------------7A3L9aq7RwQin8oMsHpBOdqi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 KGNjJ2luZyBMdWNhcykNCg0KSGkNCg0KQW0gMjUuMDMuMjMgdW0gMDg6NDYgc2NocmllYiBT dWkgSmluZ2Zlbmc6DQo+ICAgVGhlIGFzc2lnbm1lbnQgYWxyZWFkeSBkb25lIGluIGRybV9j bGllbnRfYnVmZmVyX3ZtYXAoKSwNCj4gICBqdXN0IHRyaXZhbCBjbGVhbiwgbm8gZnVuY3Rp b25hbCBjaGFuZ2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBTdWkgSmluZ2ZlbmcgPDE1MzMw MjczMjYwQDE4OS5jbj4NCj4gLS0tDQo+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9mYmRldl9n ZW5lcmljLmMgfCA1ICsrLS0tDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr KSwgMyBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2ZiZGV2X2dlbmVyaWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJkZXZfZ2VuZXJp Yy5jDQo+IGluZGV4IDRkNjMyNWU5MTU2NS4uMWRhNDhlNzFjN2YxIDEwMDY0NA0KPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiZGV2X2dlbmVyaWMuYw0KPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZiZGV2X2dlbmVyaWMuYw0KPiBAQCAtMjgyLDcgKzI4Miw3IEBAIHN0 YXRpYyBpbnQgZHJtX2ZiZGV2X2RhbWFnZV9ibGl0KHN0cnVjdCBkcm1fZmJfaGVscGVyICpm Yl9oZWxwZXIsDQo+ICAgCQkJCSBzdHJ1Y3QgZHJtX2NsaXBfcmVjdCAqY2xpcCkNCj4gICB7 DQo+ICAgCXN0cnVjdCBkcm1fY2xpZW50X2J1ZmZlciAqYnVmZmVyID0gZmJfaGVscGVyLT5i dWZmZXI7DQo+IC0Jc3RydWN0IGlvc3lzX21hcCBtYXAsIGRzdDsNCj4gKwlzdHJ1Y3QgaW9z eXNfbWFwIG1hcDsNCj4gICAJaW50IHJldDsNCj4gICANCj4gICAJLyoNCj4gQEAgLTMwMiw4 ICszMDIsNyBAQCBzdGF0aWMgaW50IGRybV9mYmRldl9kYW1hZ2VfYmxpdChzdHJ1Y3QgZHJt X2ZiX2hlbHBlciAqZmJfaGVscGVyLA0KPiAgIAlpZiAocmV0KQ0KPiAgIAkJZ290byBvdXQ7 DQo+ICAgDQo+IC0JZHN0ID0gbWFwOw0KPiAtCWRybV9mYmRldl9kYW1hZ2VfYmxpdF9yZWFs KGZiX2hlbHBlciwgY2xpcCwgJmRzdCk7DQo+ICsJZHJtX2ZiZGV2X2RhbWFnZV9ibGl0X3Jl YWwoZmJfaGVscGVyLCBjbGlwLCAmbWFwKTsNCg0KSSBzZWUgd2hhdCB5b3UncmUgZG9pbmcg YW5kIGl0J3MgcHJvYmFibHkgY29ycmVjdCBpbiB0aGlzIGNhc2UuDQoNCkJ1dCB0aGVyZSdz IGEgbGFyZ2VyIGlzc3VlIHdpdGggdGhpcyBpb3N5cyBpbnRlcmZhY2VzLiBTb21ldGltZXMg dGhlIA0KYWRkcmVzcyBoYXMgdG8gYmUgbW9kaWZpZWQgKHNlZSBjYWxscyBvZiBpb3N5c19t YXBfaW5jcigpKS4gVGhhdCBjYW4gDQpwcmV2ZW50IGluY29ycmVjdCB1c2VzIG9mIHRoZSBt YXBwaW5nIGluIG90aGVyIHBsYWNlcywgZXNwZWNpYWxseSBpbiANCnVubWFwIGNvZGUuDQoN CkkgdGhpbmsgaXQgd291bGQgbWFrZSBzZW5zZSB0byBjb25zaWRlciBhIHNlcGFyYXRlIHN0 cnVjdHVyZSBmb3IgdGhlIEkvTyANCmxvY2F0aW9uLiBUaGUgYnVmZmVyIGFzIGEgd2hvbGUg d291bGQgc3RpbGwgYmUgcmVwcmVzZW50ZWQgYnkgc3RydWN0IA0KaW9zeXNfbWFwLiAgQW5k IHRoYXQgbmV3IHN0cnVjdHVyZSwgbGV0J3MgY2FsbCBpdCBzdHJ1Y3QgaW9zeXNfcHRyLCAN CndvdWxkIHBvaW50IHRvIGFuIGFjdHVhbCBsb2NhdGlvbiB3aXRoaW4gdGhlIGJ1ZmZlcidz IG1lbW9yeSByYW5nZS4gQSANCmZldyBsb2NhdGlvbnMgYW5kIGhlbHBlcnMgd291bGQgbmVl ZCBjaGFuZ2VzLCBidXQgdGhlcmUgYXJlIG5vdCBzbyBtYW55IA0KY2FsbGVycyB0aGF0IGl0 J3MgYW4gaXNzdWUuICBUaGlzIHdvdWxkIGFsc28gYWxsb3cgZm9yIGEgZmV3IGRlYnVnZ2lu ZyANCnRlc3RzIHRoYXQgZW5zdXJlIHRoYXQgaW9zeXNfcHRyIGFsd2F5cyBvcGVyYXRlcyB3 aXRoaW4gdGhlIGJvdW5kcyBvZiBhbiANCmlvc3lzX21hcC4NCg0KSSd2ZSBsb25nIGNvbnNp ZGVyZWQgdGhpcyBpZGVhLCBidXQgdGhlcmUgd2FzIG5vIHByZXNzdXJlIHRvIHdvcmsgb24g aXQuIA0KTWF5YmUgbm93Lg0KDQpCZXN0IHJlZ2FyZHMNClRob21hcw0KDQo+ICAgDQo+ICAg CWRybV9jbGllbnRfYnVmZmVyX3Z1bm1hcChidWZmZXIpOw0KPiAgIA0KDQotLSANClRob21h cyBaaW1tZXJtYW5uDQpHcmFwaGljcyBEcml2ZXIgRGV2ZWxvcGVyDQpTVVNFIFNvZnR3YXJl IFNvbHV0aW9ucyBHZXJtYW55IEdtYkgNCk1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVy ZywgR2VybWFueQ0KKEhSQiAzNjgwOSwgQUcgTsO8cm5iZXJnKQ0KR2VzY2jDpGZ0c2bDvGhy ZXI6IEl2byBUb3Rldg0K --------------7A3L9aq7RwQin8oMsHpBOdqi-- --------------W5PV5cs8SW7uIpRGdJnqPZ9g Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmQj/xEFAwAAAAAACgkQlh/E3EQov+BS YA//XXA6CtpPaytAR+InGtHdcCPLHErAhJuRaY9Ze5A9iu3AxbJiNN2HdMFrOa9E2nBuYN9koOgN D33d1VwY+TvDSVZnR5A3n6jZrfGwCH2kdlr8kC1WJ29UGsJ+AnoSs1WgBifV5FoYkI80L+nmrEg2 2rIvFMAlraYnjWtTjDLXDy2zWx3Ju4f90EmOFLTyFSA6SNrlRdyaapu74z0d77wUxuwLbHQoHYIL QQFTztg5pDcYyoWbBrk0bsi1SdN4YDsiZvDhWQzTyFBtTe7R93hegBFUWejtgcHD5LqPOFkXoPrT BQV3kk03Uweu2xlEfHdonc0t7vLq/0lljES9G8igNJhY2TkOAy0Hm3nScYTsxMASGndyZaKbBJ/q bPlHVa6mf96oF7FC+Vc+AKdHH/sbQa6+4iAknlDBep5wY72F2HnlbIj11RHa0vpyKim5PlVq1vF7 3LsoGwGo+xmG2qokh9E2dEQTCq/lmBJZay8JKc6CLsFo1KGBDBqRzC/yUhwQLG/n5oRY8ARe6hUo YFcrXpbhXfocMNf6LX4/qYrV6UYpxnAQpyzbkHf86ggz07DaTI+D6YmLKjU5NvEW76finBkN1Mqk ZI/+zH2e+STwBsMCtXbxw/AtbdlMXyNK2TWARRz1EP6NC/4oORe3Yt+u9PHvDTzjS8zbayvE7PJ8 ORg= =vXk4 -----END PGP SIGNATURE----- --------------W5PV5cs8SW7uIpRGdJnqPZ9g--