Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5a31f75-eb93-0ff2-cd5b-19cdec58e103@wolfvision.net>
Date:   Wed, 29 Mar 2023 12:08:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 7/7] dt-bindings: display: add panel-timing property to
 sitronix,st7789v
To:     Maxime Ripard <maxime@cerno.tech>
Cc:     Rob Herring <robh@kernel.org>,
        Gerald Loacker <gerald.loacker@wolfvision.net>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
References: <20230314115644.3775169-1-gerald.loacker@wolfvision.net>
 <20230314115644.3775169-8-gerald.loacker@wolfvision.net>
 <20230316215735.GA3940832-robh@kernel.org>
 <dd26836f-d54c-65d1-0acc-8a09745bb066@wolfvision.net>
 <20230329091636.mu6ml3gvw5mvkhm4@penduick>
Content-Language: en-US
From:   Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <20230329091636.mu6ml3gvw5mvkhm4@penduick>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFRURHNNU29Lc2gyZGdFM2Q5K3pUNjRMV1pFZlpiMHMzbVJQQ0FqV2JIM0ls?=
 =?utf-8?B?YU5BMnhjVFBtWnJEZFdrZXg2KzZjSkp4aUV4SjhNaC80WU9Zc0w2MWgvZW1D?=
 =?utf-8?B?cGp2YndVbm1kMFVRY0FiMll4cElVN1l3UFplcWp2WUFsWDRwN1ZCNFdqR29J?=
 =?utf-8?B?b2FMYzhvMUVlMUF1V2VKUU9vcHVjcFliNVNMdHl1SzhkTVpKNzc2bWJFeVd1?=
 =?utf-8?B?NGM5MDNkaS95VGpCTlNPMWVoQnhvTEhocVkxRGVhYmx0MzNEN214ZEc3Sm5M?=
 =?utf-8?B?L0laNjVuM0l6cXlaWnp3RkhoSGNNOFAvbE5tQXphWm5jbkxtcWR0OWFOd3FB?=
 =?utf-8?B?ZDgrWXdBa2M4bGlRdUpBbkdRUVNuamNRMEJFUDNtRlVtMElJMWY0aE9md0RR?=
 =?utf-8?B?L3NCelZrRWswWVVHeVNlWmhvRHFEbDdTdlZxd2toelNRbFR5SkV6bkQ4R0hq?=
 =?utf-8?B?OXp1TTBYRWlSN1laanVCNFh6WlBZMVMrZklleHYwMzBwWVltcFNQRCtINlNW?=
 =?utf-8?B?Q1NKcDE0YlhDRm9FYnpwbUxIdXhYbFJ5Y3dnd29FY3ZHdFNCNzBmWUp2Tzcy?=
 =?utf-8?B?NXR3UTlMVWtXRTFBWGd0K3pLc283L2VnQmNKWXZqMTNac1lGa0JqN1B3ZzZZ?=
 =?utf-8?B?OGl6clRiWVd5aDhBZmVtSGNuaG9Od0sxSnk5Q0luTVJnR0ZqWXI4SmVET0d3?=
 =?utf-8?B?MVZRV240cG1FanhFRzJVL3F4QURma25TZTBCQnpDTkE5S1JwejBlWWFBR09m?=
 =?utf-8?B?c3hyWVl3WHFHdElDOUtpcW9oR0xvMkUxVXJrQUlLYnM1cElLWXdleVZZbTN0?=
 =?utf-8?B?NHJuaDJIK1QzVkdjclVVb1k1Ykd3RGdwQjljMWxtci9MRWVKS3NzVE9MOFF5?=
 =?utf-8?B?YURRaDJHZWRLQW5zOWNzV1NSWlBNTTZEQlhob2ZVS1ZUcGYwQzNqbTJ4SW9u?=
 =?utf-8?B?dVhSTW1hUzRlWWovNW0yRktOVkp2WEhHSk4ydUUzU01VQ2hjQlB3RzNsVzVl?=
 =?utf-8?B?Z2J4ZTFFaFJzZ0J4ak4vdW16djBkbnJuY0REMml4ZUhVV2JBTk0wR1BnY2Vq?=
 =?utf-8?B?cHAxMWZnQ1JJSWdyamhLdUNyT1RUeTMzSUNRVElNMWxwb2lHNytvNmFaQXpy?=
 =?utf-8?B?ckh5YTY1MkpwN001UmJmKy9YS2JEb1B3aDFwTDVsbmx5STl0YkV4NUw0dmx5?=
 =?utf-8?B?bFZmSVIzNkZ0REJ0UTdRU1ZZbi9QSEdVWmhXWmlIdFdnYjZEQWRpV0tLS0xi?=
 =?utf-8?B?K0NkZXBKcW5jaTQwOWNvN2NVT0k3WTkwdm82bU54NUVRVThyM05vdFlHWEVL?=
 =?utf-8?B?MkgrZk9Vc2RVZkdsTmI1bEFuNDA5TzhveFRERy9yZmxzQUcycGN5NTMvYzR4?=
 =?utf-8?B?Tlk0SllPMHBhOTJKVjhrTERMeS9NcmxRTVZJUGhmZ0pBUkRmOUozK2RqRjcz?=
 =?utf-8?B?ZDFUcmVIclMzR1orVEZoZUFDUEovQXBwTTU2UEphUG5KS0NlOTJMVWlJZS9Q?=
 =?utf-8?B?WG4rWElEbjNYeTNIM0hhV3JKdnJSZkJmbDlIejJOckFiL2JwbVNWYXpYaWx6?=
 =?utf-8?B?emM1c1kxOU1VME5kNGZUbWNvVXdmcVlxazdTSmNMaWpqTVZwckJuQmdpaEJs?=
 =?utf-8?B?bUk4a3pncWhwcmNIVzB3dWVCcGVvUUx3dWFJeUZQc3RTMUlmVm5zUnhab21J?=
 =?utf-8?B?K3FMNENrOVdQWDNITm9xcFlSanNDWUhuS2QzQkN5U0xZcFVseSsvNE15Mlpy?=
 =?utf-8?B?RkQ1aVlYM25tYlZKNDVEbjNRNWR3Nms4SURwaXU5cTE3YmxUNHRyc1F1eE5I?=
 =?utf-8?B?LzRURlYzU01rT0ZSTUQ5SjJqZ3AzR2NGMkZMbkVDalRScDUyMGlFNzViYVhl?=
 =?utf-8?B?UzVxdmdGbnU3Y1E1N2tmTWgybDNpbVpvRlBOcVdmckFpdEtTd244RDc5aFZX?=
 =?utf-8?B?ZzBReml0WWg5RUR1QUVzVWYzbFpDYVZuRVBPUVZnMTRyRFZ4V2orVG40WjNM?=
 =?utf-8?B?QzBVQ3ZWWDR4K1YveHczR0c1eXB3UGxmRnZFeVlqS3NGYVZrbFRDbHFOM0Js?=
 =?utf-8?B?aWl6SEsxR3hrT2ZsYi9LTXBNZFlzSTBCdGdnMkZyY1E3dFpIaEl0bHRldkNX?=
 =?utf-8?B?R0gzVGRteDhSS21QZFN2NERkRm5aVS9URmRZelVPT0dSa1VGY0dJRmNKWGl3?=
 =?utf-8?B?Vmc9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 35aa7471-7e3b-4251-23a8-08db303d99cd
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 10:08:53.5689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bMCTc5/cyzw9HBLGzmFStNyHcwUQvbCAo4DShgmwsPKusWHZ1/yk/p0iul8gMAr0dazfrkTTOw+rPugl1Fc5qRXSHdmfcZ2qPjZh4q1wAl4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9651
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Maxime,

On 3/29/23 11:16, Maxime Ripard wrote:
> On Thu, Mar 16, 2023 at 11:29:53PM +0100, Michael Riesch wrote:
>> Hi Rob,
>>
>> On 3/16/23 22:57, Rob Herring wrote:
>>> On Tue, Mar 14, 2023 at 12:56:44PM +0100, Gerald Loacker wrote:
>>>> The sitronix-st7789v driver now considers the panel-timing property.
>>>
>>> I read the patch for that and still don't know 'why'. Commit messages 
>>> should answer why.
>>>
>>>> Add the property to the documentation.
>>>
>>> We generally don't put timings in DT for panels. Why is this one 
>>> special?
>>
>> For now, having the timings in the device tree allows for setting the
>> hsync/vsync/de polarity.
>>
>> As a next step, we aim to implement the partial mode feature of this
>> panel. It is possible to use only a certain region of the panel, which
>> is helpful e.g., when a part of the panel is occluded and should not be
>> considered by DRM. We thought that this could be specified as timing in DT.
>>
>> (The hactive and vactive properties serve as dimensions of this certain
>> region, of course. We still need to specify somehow the position of the
>> region. Maybe with additional properties hactive-start and vactive-start?)
>>
>> What do you think about that?
> 
> I don't see why we would need the device tree to support that. What you
> described is essentially what overscan is for HDMI/analog output, and we
> already have everything to deal with overscan properly in KMS.

Thanks for your response, but I am afraid I don't quite follow.

How are we supposed to expose control over the hsync/vsync/data enable
polarity? I only know that the display controller and the panel need to
agree on a setting that works for both. What is the canonical way to do
this?

A different question is the partial mode, for which (IIUC) you suggest
the overscan feature. As I have never heard of this before, it would be
very nice if you could point me to some examples. Where would the
effective resolution be set in this case?

We thought that this should enter the device tree as in our case the
display is partially occluded due to hardware constraints. For the user
there is only one reasonable configuration.

Alternatively, we could follow a different approach and handle a
separate compatible in the panel driver. Would this be acceptable for
mainline inclusion?

Best regards,
Michael