Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 13:27:27 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        dmaengine@vger.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: mv_xor_v2: Fix an error code.
Message-ID: <16cfc681-7a08-4160-bd69-4c8b59774688@kili.mountain>
References: <201170dff832a3c496d125772e10070cd834ebf2.1679814350.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201170dff832a3c496d125772e10070cd834ebf2.1679814350.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk

On Sun, Mar 26, 2023 at 09:06:37AM +0200, Christophe JAILLET wrote:
> If the probe is deferred, -EPROBE_DEFER should be returned, not
> +EPROBE_DEFER.
> 
> Fixes: 3cd2c313f1d6 ("dmaengine: mv_xor_v2: Fix clock resource by adding a register clock")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/dma/mv_xor_v2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index 89790beba305..0991b8265829 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -752,7 +752,7 @@ static int mv_xor_v2_probe(struct platform_device *pdev)
>  
>  	xor_dev->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (PTR_ERR(xor_dev->clk) == -EPROBE_DEFER) {
> -		ret = EPROBE_DEFER;
> +		ret = -EPROBE_DEFER;
>  		goto disable_reg_clk;

Heh.  Looking through the Smatch results, I don't think this actually
affects runtime because driver_probe_device() checks for both positive
and negatives.  People shouldn't be returning positives, of course, but
it appears there is a work around for bugs built in already.

regards,
dan carpenter