Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 13:43:33 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org, vigneshr@ti.com,
        srk@ti.com, r-gunasekaran@ti.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: tps6598x: make interrupts optional
Message-ID: <ZCQWVfyVVecCYHDb@kuha.fi.intel.com>
References: <20230324131853.41102-1-rogerq@kernel.org>
 <20230324133741.43408-1-rogerq@kernel.org>
 <271f0be0-9cb2-0c74-c112-33020e9a7342@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <271f0be0-9cb2-0c74-c112-33020e9a7342@kernel.org>
Precedence: bulk

On Wed, Mar 29, 2023 at 10:05:33AM +0300, Roger Quadros wrote:
> Hi Heikki & Rob,
> 
> On 24/03/2023 15:37, Roger Quadros wrote:
> > The driver can poll for interrupt status so interrupts
> > can be optional. It is still recommended to use the
> > interrupt line. Polling should only be used for debug
> > and prototyping.
> > 
> > Signed-off-by: Roger Quadros <rogerq@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > index 348a715d61f4..8c2db282735a 100644
> > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > @@ -35,8 +35,6 @@ properties:
> >  required:
> >    - compatible
> >    - reg
> > -  - interrupts
> > -  - interrupt-names
> >  
> >  additionalProperties: true
> >  
> 
> We need this patch as well along with the driver changes [1]
> Could you please Ack. Thanks!

I can give my ack FWIW, but we should still wait for Rob.

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

thanks,

-- 
heikki