Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 13:55:05 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        dmaengine@vger.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: mv_xor_v2: Fix an error code.
Message-ID: <73af278e-1fc7-43fb-87b9-f107ae533266@kili.mountain>
References: <201170dff832a3c496d125772e10070cd834ebf2.1679814350.git.christophe.jaillet@wanadoo.fr>
 <e53e6f9a-09a9-42e4-8e81-dfe2ad2813ad@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e53e6f9a-09a9-42e4-8e81-dfe2ad2813ad@kili.mountain>
Precedence: bulk

A bunch of false positives could be silenced by changing the assign
and return hooks to check for unsigned types:

static void match_assign(struct expression *expr)
{
        if (expr_unsigned(expr->left))
                return;
        warn_on_positive_error(expr->right);
}

static void match_return(struct expression *expr)
{
        struct symbol *type;

        type = cur_func_return_type();
        if (type_unsigned(type))
                return;

        warn_on_positive_error(expr);
}

regards,
dan carpenter