Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e60d5073-b7bb-f475-8ce5-fa04ac0926f5@linux.alibaba.com>
Date:   Wed, 29 Mar 2023 20:03:08 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH RFC 3/4] driver/perf: Add identifier sysfs file for Yitian
 710 DDR
To:     Shuai Xue <xueshuai@linux.alibaba.com>,
        John Garry <john.g.garry@oracle.com>,
        Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1679885172-95021-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1679885172-95021-4-git-send-email-renyu.zj@linux.alibaba.com>
 <7060f009-2964-30af-3d12-2bb3e21b6c1e@linux.alibaba.com>
From:   Jing Zhang <renyu.zj@linux.alibaba.com>
In-Reply-To: <7060f009-2964-30af-3d12-2bb3e21b6c1e@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/3/29 下午3:55, Shuai Xue 写道:
> 
> 
> On 2023/3/27 AM10:46, Jing Zhang wrote:
>> To allow userspace to identify the specific implementation of the device,
>> add an "identifier" sysfs file.
>>
>> The perf tool can match the Yitian 710 DDR metric through the identifier.
>>
>> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>
>> ---
>>  drivers/perf/alibaba_uncore_drw_pmu.c | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
>> index a7689fe..6639a57 100644
>> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
>> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
>> @@ -236,10 +236,37 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev,
>>  	.attrs = ali_drw_pmu_cpumask_attrs,
>>  };
>>  
>> +static ssize_t ali_drw_pmu_identifier_show(struct device *dev,
>> +					struct device_attribute *attr,
>> +					char *page)
>> +{
>> +	return sysfs_emit(page, "%s\n", "ali_drw_yitian710");
> 
> Is it possible to rename identifier as "ali_drw_pmu"? I don't think we need only
> limit alibaba_uncore_drw_pmu to Yitian710 SoC here.
> 

Ok, I will rename it as "ali_drw_pmu".

Thanks,
Jing

> Thank you.
> Shuai
> 
>> +}
>> +
>> +static umode_t ali_drw_pmu_identifier_attr_visible(struct kobject *kobj,
>> +						struct attribute *attr, int n)
>> +{
>> +	return attr->mode;
>> +}
>> +
>> +static struct device_attribute ali_drw_pmu_identifier_attr =
>> +	__ATTR(identifier, 0444, ali_drw_pmu_identifier_show, NULL);
>> +
>> +static struct attribute *ali_drw_pmu_identifier_attrs[] = {
>> +	&ali_drw_pmu_identifier_attr.attr,
>> +	NULL,
>> +};
>> +
>> +static const struct attribute_group ali_drw_pmu_identifier_attr_group = {
>> +	.attrs = ali_drw_pmu_identifier_attrs,
>> +	.is_visible = ali_drw_pmu_identifier_attr_visible,
>> +};
>> +
>>  static const struct attribute_group *ali_drw_pmu_attr_groups[] = {
>>  	&ali_drw_pmu_events_attr_group,
>>  	&ali_drw_pmu_cpumask_attr_group,
>>  	&ali_drw_pmu_format_group,
>> +	&ali_drw_pmu_identifier_attr_group,
>>  	NULL,
>>  };
>>