Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp549905rwl; Wed, 29 Mar 2023 05:43:05 -0700 (PDT) X-Google-Smtp-Source: AKy350Yz34sUze0aipAQi3b8pXZJVwrs3aHxGEFVlB6ixlKklh72MTtNAZNot50N1RTY+uenluEe X-Received: by 2002:a17:907:6b06:b0:93f:50c7:2f5f with SMTP id rm6-20020a1709076b0600b0093f50c72f5fmr15043275ejc.63.1680093785326; Wed, 29 Mar 2023 05:43:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680093785; cv=none; d=google.com; s=arc-20160816; b=geJiD8t/ujuUH8kLSiUUDIQdUuVH+umKBSqTkdAaUeuMUmtwYm65/yc1zvLXd9zJP6 KGepXf4XsHzrPf6zAAPrdiFD2dYAHhGdWbK/QoXroeVdH3l4TBVEuiLIK7qiMSjK8BdX ozQ93rG//4QdBRX/mV7phJckcLP/wD2BfrCse4Nb/89yQKC2R2zQJPaNYwMQXxGivYi7 hsdmvz+nTA5T3bC6IRND+FRK2nFuByx4/MGj6nqcIZOXJrWquCO6ddHTrlnihxAY3xWm snr2Cx0pmeZfJkM6NfQEnBEZ8i2fmoF+7pvU0UnUJAGO3P2Ok/B7J6eWbpiYtKXtAj8S exgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=gHb6wEI0W+Q8XNFleXC4qtIxQ5KFkUssnbzkaSWTwt0=; b=kkVHY2ReSEmcqRSjW2Z0kDVtxDCIkbOogIXuBwiZFLIwwTE3FARrjlHPKCuXjNuMpv PH79E0NLZ0P8U3dm2uCygsjKHdtpKbmeWR9pB4qglab74RgHnsPu2U7R//Xa4xyrIoOq QuIWz8r5v2+B02tKTn9H9mlahJz9WAqphafAKcJ5tZsIIsLyeI+rGPHRGLFNJoK5eSbI 13rgVz36U7/1jaZYhlDZwutnfdmxL+zlneI2Nu6UIAi9pi2JMsQKlbdWxzvG2BF7MoJQ lxyzE5VFIK7EZtZG63QS5uZpBHpHqJOh7SOh7vf3SInO5YWlRJ4i74sZq+riw4Zdrt9e bx7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b="HG/XVNTl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o1-20020aa7d3c1000000b005021f0d5755si13725521edr.668.2023.03.29.05.42.40; Wed, 29 Mar 2023 05:43:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b="HG/XVNTl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbjC2Mhs (ORCPT + 99 others); Wed, 29 Mar 2023 08:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjC2Mhr (ORCPT ); Wed, 29 Mar 2023 08:37:47 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7991E40CB for ; Wed, 29 Mar 2023 05:37:45 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id r11so62635118edd.5 for ; Wed, 29 Mar 2023 05:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1680093464; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gHb6wEI0W+Q8XNFleXC4qtIxQ5KFkUssnbzkaSWTwt0=; b=HG/XVNTljst0PoADYJ9a1oe2fUatY94AsdKpMHxxOpv6UuoHB6hvijDjhYLE9/25rs 152++Pjka5+uGRovDxe9lV+rhf8++TfTk52B//EwPFKlZ8SzAWjTwNLluSshW2RDWPnd srv2pNMrlqDFWWsC173i94ItNlYGVLs5iGdN6EW6KPfp4NGuo04lpjR216LCgKHkG6hm tt8ytMaBacnj2KHpooUNXKvXT476qhRY2eCUHq0XSDr3E6V5f2UW8KmHuS4qM5P/vnYo c7iIw+AdSJaMxFaBxtnvEUmWHYQAhPvuAHIixL2EwShp2QWod24RpXn2eN7OXg5nz4PP a8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680093464; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gHb6wEI0W+Q8XNFleXC4qtIxQ5KFkUssnbzkaSWTwt0=; b=Bs61N+NUDAgmBG2yKfhalTCY0dJumUmOBq95hoER1IJliiX3o6jDWY6iXGLKSPWEhs LcfQzpu/MQuif3JwQCjOkFxI/ygtFon4ruUdSo0PgzB+FR0reB6k+d43PoTXTsZwYvCP 4pB2ei8zv13UcpREMCrAYCqq+cyxifreKcpznpHb9+WMklQi3zEp5+5HMli02vYLZ4r4 VM7/bjhaZ6BrcV/dtvvZnZipdjwhWpwyCktXlBhJJ9N1cZVISS8JrmWseW1D7tK4OdxJ oYfHj+mukzCvSW7ApF0DvWQqcS+gr9ekjKGqRw+hpu5i7eAJgX0GP8WmHLbcpBF8JCbl /LXw== X-Gm-Message-State: AAQBX9d87ZPd4AZeH99tpZPm8WxyZhrNeY2nSv7dItkKMjbuqTQlONlu 1EPnjHj/Pn9dUSeF8pgzWstyu0TDHXX4RclWGwi5/A== X-Received: by 2002:a17:907:d687:b0:93d:a14f:c9b4 with SMTP id wf7-20020a170907d68700b0093da14fc9b4mr9691718ejc.2.1680093463969; Wed, 29 Mar 2023 05:37:43 -0700 (PDT) MIME-Version: 1.0 References: <20221129161134.2672474-1-Naresh.Solanki@9elements.com> <20221129161134.2672474-5-Naresh.Solanki@9elements.com> <20221129163427.dxnqfay6ur6mvivu@pengutronix.de> <77c5a9e2-ce25-df19-1eba-ba4808bbeb9d@9elements.com> In-Reply-To: <77c5a9e2-ce25-df19-1eba-ba4808bbeb9d@9elements.com> From: Naresh Solanki Date: Wed, 29 Mar 2023 18:07:34 +0530 Message-ID: Subject: Re: [PATCH v8 4/4] hwmon: (max6639) Add pwm support To: Guenter Roeck , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Rob Herring Cc: devicetree@vger.kernel.org, Jean Delvare , Thierry Reding , linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Patrick Rudolph , linux-pwm@vger.kernel.org, kernel@pengutronix.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Guenter, I need your inputs & direction on the next step for max6639 driver. I'm willing to work & implement changes. Thank you for your time and consideration. Regards, Naresh Solanki Regards, Naresh Solanki 9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Bochum, Germany Email: naresh.solanki@9elements.com Mobile: +91 9538631477 Sitz der Gesellschaft: Bochum Handelsregister: Amtsgericht Bochum, HRB 17519 Gesch=C3=A4ftsf=C3=BChrung: Sebastian Deutsch, Eray Basar Datenschutzhinweise nach Art. 13 DSGVO On Tue, 6 Dec 2022 at 23:15, Naresh Solanki wrote: > > Hi Guenter, Rob > > On 29-11-2022 10:11 pm, Guenter Roeck wrote: > > On 11/29/22 08:34, Uwe Kleine-K=C3=B6nig wrote: > >> On Tue, Nov 29, 2022 at 05:11:34PM +0100, Naresh Solanki wrote: > >>> Add pwm support for max6639. Also configure pwm fan speed based on pw= m > >>> provided in DT. > >> > >> Did you do anything to resolve the questions I had in reply to v5? If > >> yes, I must have missed it. > >> > > > > I don't see a response to my concerns either, especially regarding fan = mode > > (dc vs. pwm) in the bindings. For that reason, I won't even look at the > > series. > Best I can think of regulator with voltage control. Because as per my > understanding, DC control fan essentially control DC voltage on negative > pin of fan. > > > Regards, > Naresh > > > > Guenter > > > >> Note that maintainer time is scarce and with sending new versions of a > >> patch with no sign that you improved in the aspects that were critized > >> before, you're burning that scarce time and loosing the good will of t= he > >> responsible maintainers. > >> > >> Best regards > >> Uwe > >> > >