Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp557187rwl; Wed, 29 Mar 2023 05:47:57 -0700 (PDT) X-Google-Smtp-Source: AK7set+uLzfO+1O/A1QqHGPc96b22CbI29RUZTPDWPpBXf9tTeu4JowwfugfjF0wLpdfIrviLuO5 X-Received: by 2002:a05:6a20:b2f:b0:dd:44a8:9d2b with SMTP id x47-20020a056a200b2f00b000dd44a89d2bmr15531599pzf.1.1680094077133; Wed, 29 Mar 2023 05:47:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680094077; cv=none; d=google.com; s=arc-20160816; b=qvuxYrE0YLEyS/CRJYPXBpgHorG2BAyKPY71WjlwRDA+JwamSE7lyKsahqiUzOw023 Z10sXHtkA/ySBqKxJhJlDVkrdqZS0yp2DRmLqC5djJKDMfIuWjLFIe0uKNAO15waQviI eVROF60/LfWoCc/hQ1Hon9p7omSKkaHn5SzoRGk+zOX3nf1ag323Z39uJVMqoEa3Iukf jUhApUSi0i288bzVTafaabJzvVGQQjYBssEn9Dl+RoL3D6V3GxxKn9/BaJDcpprMjhWy GHv9JkJgspiQ6fxJ294lLwV/ZqbuZ9Hg4bpO/WbbjXLHcIJdAqzdeQIkBHKugZIVK/UN sfVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=T30HSIhFB4AlhJqlS87v+e+jz8AQ9i+9xzd78l4WP14=; b=zM92GBU78e1FNvj0djueGo9N3gv2k0ZyxMjYSy1MxbjACYBeCSI/+JMK063WVCr0Wy FOJ7HkkDN6TcmB6CUNcqi+GXpG65essaARWcCrZH/+F+NPKfwhALF8na0cv3uKZwhm7k 8ypFc7So4UCf36R/ExJKkzPX8CD+vg+Grsweb6qetttjMiWwGcROXS+x593qQIIK3mXc 02waSczW+pc3EcF/W1IE3wzf0AQ0P+IEFggyi+wIJ+Y8YglIvsclep8wMWgf9tYZsKuB t36u/6mPaz2nJ6TeWh5iukgSQZvF3bL2VnhSiF9izJEj7Rk7Ad1V2gvbbufh4OUfoQ43 522A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=GPC3aUaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020a056a00162700b0058bbe6710absi30102800pfc.261.2023.03.29.05.47.45; Wed, 29 Mar 2023 05:47:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=GPC3aUaY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229909AbjC2Mpp (ORCPT + 99 others); Wed, 29 Mar 2023 08:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjC2Mpo (ORCPT ); Wed, 29 Mar 2023 08:45:44 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD1B7422C; Wed, 29 Mar 2023 05:45:41 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32TCjDLQ080552; Wed, 29 Mar 2023 07:45:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680093913; bh=T30HSIhFB4AlhJqlS87v+e+jz8AQ9i+9xzd78l4WP14=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=GPC3aUaYyaWAZhuOD7HZG/+B5bc5wcYwzLP0bFPi0odKQL2kUeSZZc72Y9Y6q8bGc dX0Zj3O4YVnxah2C0VuoTlfhWQLAK7lKRH/JJnPP8o5dgn2VFZLtXivitPrs/+fJ2i 4iOfhgNCvngYMRVxLhB/d12zV9UmN1FYazFePGOU= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32TCjD3f014102 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Mar 2023 07:45:13 -0500 Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 29 Mar 2023 07:45:12 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 29 Mar 2023 07:45:12 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32TCjCsQ036808; Wed, 29 Mar 2023 07:45:12 -0500 Date: Wed, 29 Mar 2023 07:45:12 -0500 From: Nishanth Menon To: Apurva Nandan CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , , , Subject: Re: [PATCH v2] arm64: dts: ti: k3-j784s4-evm: Add OSPI0 flash support Message-ID: <20230329124512.bjxuywwqrvwe2h5l@translate> References: <20230329060057.13654-1-a-nandan@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230329060057.13654-1-a-nandan@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11:30-20230329, Apurva Nandan wrote: > Add support for OSPI flash connected to OSPI0 instance through FSS. > Also enumerate OSPI1 instance in MCU DTSI. > > Signed-off-by: Apurva Nandan > --- > > Changelog: > - Fixed address 0x0 to 0x00 > - Fixed dtbs_check errors (removed syscon and created simple bus) > - Fixed whitespace error > > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 45 +++++++++++++++++++ > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 41 +++++++++++++++++ > 2 files changed, 86 insertions(+) Please split this patch up as SoC and board dts changes. > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > index b9e23697a63b..cc8c2dda7bd2 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > @@ -141,12 +141,57 @@ J784S4_IOPAD(0x020, PIN_INPUT, 7) /* (AJ35) MCAN15_RX.GPIO0_8 */ > }; > }; > > +&wkup_pmx0 { > + mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-pins-default { > + pinctrl-single,pins = < > + J784S4_WKUP_IOPAD(0x000, PIN_OUTPUT, 0) /* (E32) MCU_OSPI0_CLK */ > + J784S4_WKUP_IOPAD(0x02c, PIN_OUTPUT, 0) /* (A32) MCU_OSPI0_CSn0 */ > + J784S4_WKUP_IOPAD(0x00c, PIN_INPUT, 0) /* (B33) MCU_OSPI0_D0 */ > + J784S4_WKUP_IOPAD(0x010, PIN_INPUT, 0) /* (B32) MCU_OSPI0_D1 */ > + J784S4_WKUP_IOPAD(0x014, PIN_INPUT, 0) /* (C33) MCU_OSPI0_D2 */ > + J784S4_WKUP_IOPAD(0x018, PIN_INPUT, 0) /* (C35) MCU_OSPI0_D3 */ > + J784S4_WKUP_IOPAD(0x01c, PIN_INPUT, 0) /* (D33) MCU_OSPI0_D4 */ > + J784S4_WKUP_IOPAD(0x020, PIN_INPUT, 0) /* (D34) MCU_OSPI0_D5 */ > + J784S4_WKUP_IOPAD(0x024, PIN_INPUT, 0) /* (E34) MCU_OSPI0_D6 */ > + J784S4_WKUP_IOPAD(0x028, PIN_INPUT, 0) /* (E33) MCU_OSPI0_D7 */ > + J784S4_WKUP_IOPAD(0x008, PIN_INPUT, 0) /* (C34) MCU_OSPI0_DQS */ > + J784S4_WKUP_IOPAD(0x03c, PIN_OUTPUT, 6) /* (C32) MCU_OSPI0_CSn3.MCU_OSPI0_ECC_FAIL */ > + J784S4_WKUP_IOPAD(0x038, PIN_OUTPUT, 6) /* (B34) MCU_OSPI0_CSn2.MCU_OSPI0_RESET_OUT0 */ > + >; > + }; > +}; > + > &main_uart8 { > status = "okay"; > pinctrl-names = "default"; > pinctrl-0 = <&main_uart8_pins_default>; > }; > > +&fss { > + status = "okay"; > +}; > + > +&ospi0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mcu_fss0_ospi0_pins_default>; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0x0>; > + spi-tx-bus-width = <8>; > + spi-rx-bus-width = <8>; > + spi-max-frequency = <25000000>; > + cdns,tshsl-ns = <60>; > + cdns,tsd2d-ns = <60>; > + cdns,tchsh-ns = <60>; > + cdns,tslch-ns = <60>; > + cdns,read-delay = <4>; > + #address-cells = <1>; > + #size-cells = <1>; > + }; > +}; > + > &main_i2c0 { > status = "okay"; > pinctrl-names = "default"; > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > index 64bd3dee14aa..f825a8e4b452 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi > @@ -309,4 +309,45 @@ cpts@3d000 { > ti,cpts-periodic-outputs = <2>; > }; > }; > + > + fss: bus@47000000 { > + compatible = "simple-bus"; > + reg = <0x00 0x47000000 0x00 0x100>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + ospi0: spi@47040000 { > + compatible = "ti,am654-ospi", "cdns,qspi-nor"; > + reg = <0x00 0x47040000 0x00 0x100>, > + <0x05 0x0000000 0x01 0x0000000>; > + interrupts = ; > + cdns,fifo-depth = <256>; > + cdns,fifo-width = <4>; > + cdns,trigger-address = <0x0>; > + clocks = <&k3_clks 161 7>; > + assigned-clocks = <&k3_clks 161 7>; > + assigned-clock-parents = <&k3_clks 161 9>; > + assigned-clock-rates = <166666666>; > + power-domains = <&k3_pds 161 TI_SCI_PD_EXCLUSIVE>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > + ospi1: spi@47050000 { > + compatible = "ti,am654-ospi", "cdns,qspi-nor"; > + reg = <0x00 0x47050000 0x00 0x100>, > + <0x07 0x0000000 0x01 0x0000000>; > + interrupts = ; > + cdns,fifo-depth = <256>; > + cdns,fifo-width = <4>; > + cdns,trigger-address = <0x0>; > + clocks = <&k3_clks 162 7>; > + power-domains = <&k3_pds 162 TI_SCI_PD_EXCLUSIVE>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + }; > }; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D