Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 07:48:21 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Apurva Nandan <a-nandan@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-j721e-main: Switch MAIN R5F
 clusters to Split-mode
Message-ID: <20230329124821.snts4npowkwjow3d@fifteen>
References: <20230329063728.14126-1-a-nandan@ti.com>
 <20230329063728.14126-2-a-nandan@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230329063728.14126-2-a-nandan@ti.com>
Precedence: bulk

On 12:07-20230329, Apurva Nandan wrote:
> From: Suman Anna <s-anna@ti.com>
> 
> J721E SoCs have two R5F clusters in the MAIN domain, and both of these
> are configured for LockStep mode at the moment. Switch both of these R5F
> clusters to Split mode by default to maximize the number of R5F cores.
> The MCU R5F cluster continues to be in the preferred LockStep mode.
> 
> Note that this configuration is the default for remoteproc mode (kernel
> driver boots the R5F processors). These will be overridden for early-booted
> remoteprocs through the corresponding IPC-only support in the K3 R5F
> remoteproc driver.
> 

This looks like a firmware specific behavior, best done in overlay along
with any custom memory map controls you may have to do for that specific
firmware.

If this is indeed a fixes, the commit message needs to clearly indicate
why this is a fix and use the Fixes tag to propogate the fixes.

> Signed-off-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)


> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index c935622f0102..31dadbdc0d5a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -1722,7 +1722,7 @@ watchdog1: watchdog@2210000 {
>  
>  	main_r5fss0: r5fss@5c00000 {
>  		compatible = "ti,j721e-r5fss";
> -		ti,cluster-mode = <1>;
> +		ti,cluster-mode = <0>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		ranges = <0x5c00000 0x00 0x5c00000 0x20000>,
> @@ -1762,7 +1762,7 @@ main_r5fss0_core1: r5f@5d00000 {
>  
>  	main_r5fss1: r5fss@5e00000 {
>  		compatible = "ti,j721e-r5fss";
> -		ti,cluster-mode = <1>;
> +		ti,cluster-mode = <0>;
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		ranges = <0x5e00000 0x00 0x5e00000 0x20000>,
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D