DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; b=vQxDd7BjYBGwlb8EVkfk3hiBFtri/MYJzqEE+A1hkzna1tIkmoD4kOE5YwDddQHAZxq5u6LW5aLHkH1jnDxrG69xHqb9b8EiZeNCJHGsVp1fRbaqBvX++7IEnOyCqg6y;
Date: Fri, 21 Sep 2007 09:40:53 -0500
From: Matt Domsch <Matt_Domsch@dell.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
       Frank Cusack <fcusack@fcusack.com>, linux-ppp@vger.kernel.org
Subject: Re: [PATCH] ppp_mppe: Don't put InterimKey on the stack
Message-ID: <20070921144053.GA28101@auslistsprd01.us.dell.com>
References: <46F3D049.4080006@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <46F3D049.4080006@redhat.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 868
Lines: 24

On Fri, Sep 21, 2007 at 04:08:09PM +0200, Michal Schmidt wrote:
> Hello,
> 
> The interrupt stack can be in the __START_KERNEL_map region in which
> virt_to_page will not work. This caused ppp_mppe to crash on CentOS 5 on x86_64
> (http://bugs.centos.org/view.php?id=2076).
> 
> The fix is to avoid copying the interim key. We can simply use it in its
> original place, which is kmalloc'd.

Needs a Signed-off-by: line, but otherwise, looks good, and even saves
some stack space.  Thanks for tracking this down.

-Matt

-- 
Matt Domsch
Linux Technology Strategist, Dell Office of the CTO
linux.dell.com & www.dell.com/linux
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/