Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp598741rwl; Wed, 29 Mar 2023 06:15:26 -0700 (PDT) X-Google-Smtp-Source: AKy350byFMEcE9vSAC6xPRJTtO0SElkp+txOKK31OYrUIULofummE42UrxMki6X1olx2NtKGxVS8 X-Received: by 2002:a17:907:3e21:b0:930:f953:9614 with SMTP id hp33-20020a1709073e2100b00930f9539614mr26561023ejc.1.1680095726278; Wed, 29 Mar 2023 06:15:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680095726; cv=none; d=google.com; s=arc-20160816; b=DaQqowVPkDQb37cbSvrVMKfkUeMrkO+bmGk9/8JtzH8e6HO3ymmKP7mb8FOZ70t6UD KBRpexd4M4nzpSEMVPJIQBJ4zexNQZhUV8svpD9Y62Qs1bw+sfe2dMxCmQFebvtwD16I 1Q92fXcsLRwIDOI9Oi3Ld7h/uSiHEUzhVgxIMKgZLW+yTP7rbU+0TKqRAmD4jl5UA/JB g6M5XsfvjjgVkqJNa1EgwagP4vHpAWKwGnddDmh2Sh5Y6hdloXrdG8lnE9cmFjwyCh6o rboUVkvoOoCN6V0H75ZWyiQbLTkNjE5pMnx2Yp9yEq4vnCjNzqC+ULmNs6NymVLWQ9Xn Jx1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=DG8l/Vf/q3v2qoAMU7uA0oLjL0z8Jprpk2Z2ZRzYrFU=; b=Hf9QQnWb1oZ8qaCLqLd32NqyAYkUrfqQGm2m7jhKrDXhjLwk0AMeSAva/QihlArNbG QiPNUDuYZ9rmU0yozS7q2zW7O0AMwONaPNwN4OvgGNdhgC+PJFBlHUUI6P65DrzwwbI5 9r7daimsLeCpdowQKEe0z525RCBDy6LLbxsV9rGDWRcN7Bnhd94PDypEHdYtotJQ8FSz kPWTH9QZd2+SRzrEHoeLY/ylcckR1ZUaOVhtNG5wUl9AOk4wvUSAtMoynYgno0J7SxQi rfh4yzDMTJclZCCXHzkzLQulxhWlEZyJgxnn4ONhpddHF+56U/U3JwJrjCZp4+EwZBFz LAPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k23-20020a1709067ad700b0092aa2875a02si30703616ejo.193.2023.03.29.06.14.59; Wed, 29 Mar 2023 06:15:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbjC2NOk (ORCPT + 99 others); Wed, 29 Mar 2023 09:14:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjC2NOi (ORCPT ); Wed, 29 Mar 2023 09:14:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EADA26BA; Wed, 29 Mar 2023 06:14:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9992B61CEB; Wed, 29 Mar 2023 13:14:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49D76C433D2; Wed, 29 Mar 2023 13:14:36 +0000 (UTC) Date: Wed, 29 Mar 2023 09:14:29 -0400 From: Steven Rostedt To: Vincent Donnefort Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 1/2] ring-buffer: Introducing ring-buffer mapping functions Message-ID: <20230329091429.03d52dcc@rorschach.local.home> In-Reply-To: References: <20230322102244.3239740-1-vdonnefort@google.com> <20230322102244.3239740-2-vdonnefort@google.com> <20230328224411.0d69e272@gandalf.local.home> <20230329070353.1e1b443b@gandalf.local.home> <20230329084735.6c4a9229@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Mar 2023 14:10:09 +0100 Vincent Donnefort wrote: > The v2 of this series only updates the head page in the update ioctl > (ring_buffer_update_meta_page()) Couldn't find a nice way around that as it can > be either updated by the reader or the writer. So the best solution seemed a > call to set_head_page(). Yes, the update will race between readers and writers. Let's not worry about this at the moment and not expose it yet. I'm looking at other ways around this too. -- Steve