Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 15:23:29 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com,
        petrm@nvidia.com, leon@kernel.org, shayagr@amazon.com,
        wsa+renesas@sang-engineering.com, yangyingliang@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] net: ksz884x: remove unused change variable
Message-ID: <ZCQ70Rb311WzqPIJ@corigine.com>
References: <20230329125929.1808420-1-trix@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230329125929.1808420-1-trix@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bXhhr5T8hnRyXVj7vurWstaFxudXtMYre4EDVYzz4Dcw7upyc+qqWQi071wd?=
 =?us-ascii?Q?pgiGY2uWAiIoDDzgH8fV+Yc1CjBjjuqX+yxYVBmA/UXx46r0jam3B79hVHGx?=
 =?us-ascii?Q?oNcqvTLCK0+vPa7WSnPYCMUhFIhE3JgaKRkOAZWs8/QNrw9c5WSMg+h2qSP9?=
 =?us-ascii?Q?eFAOvBldy/vkydQI3fgtoCoDpc7M+wG1QyPUe6MJlutWUCXp3BqUnwc2e2m6?=
 =?us-ascii?Q?t2VFDoiMemH0ITBLIsT8mRcpLUVZaoQ12izQUZsUgTtHhUNBF5co1gfothXm?=
 =?us-ascii?Q?/HjGavjxi0PuVYuQzHf3sSXvNue5xH4tuvnzgbxJ1a6AqiEWRjhyMPre8C90?=
 =?us-ascii?Q?OychksWDXz9KK/fQQPXcUzCAeC1NmalMx0n6v5KjRhRaqWD2892DTIDj7AgZ?=
 =?us-ascii?Q?S1xnz4YuBXVTC7JDL6HbABpUDW8C7dzspobsqjhRKfny8V0NzHui99NsYSdz?=
 =?us-ascii?Q?+9Pu2hGY16GcJaLCncxlX7+E+ZWxH/T2CwduAy0ry93LSrxnXJGIx8pxuW38?=
 =?us-ascii?Q?f3kB+HeRhNjq9hq0ZiOgQ8G5yMhnMswxLKp+l7jn/anHklrKrSPRD53O/bJF?=
 =?us-ascii?Q?6xcgd9V1ULcF23qEglAgXNerMYzR1GB99S2OII/iaaAqCRhGVO/K0vMlZKqU?=
 =?us-ascii?Q?NM+MRT0pmCUBVLRHodIJIc+2Djb/OVJWWX0ZVHkwTxbtLl2wFD9hBVEDZHpq?=
 =?us-ascii?Q?JgZP1jiHWhd5cRCzlB8Br55JaOblqLf3JLdN6M0ok3S7UPuDmxQbdOX6t82S?=
 =?us-ascii?Q?rs3MBGApmGahqTNc6+kewzSudrCyrOHgHfWHq+PnY6m6/ISKRUx22bJABnwX?=
 =?us-ascii?Q?6nM2rnnp4aivh/UTXOTmWVBs5BHeQfbDOlE1FLrOsb8YvEhfw3xSaqTa1UR/?=
 =?us-ascii?Q?yMFL7jERQGivhExbNhEQ/ysMrZhph/N+Louc6CYhXknw2aA7D7q+FQXKlr8p?=
 =?us-ascii?Q?lcZKj/rTT0DFxPDD43TCSXYXhjOUtuDLknZrTF2HxjOb3BhDf19MjVfxN0sx?=
 =?us-ascii?Q?3a6QeborQRZr1vKTQtDtKVhntqJvtxWv2easyr9qdesCFhQO/GMdCrLgJUDH?=
 =?us-ascii?Q?lu9Z9LEPBiEk08sYzKWNj1D/RXF61/wF6TqEP6jssc2FGtDu8MQHSIe4+c3A?=
 =?us-ascii?Q?VWK/TgTQtXEBQBYfNPk7AAcHLq/VkvPI8x7WlLVrRSXDB25bxBuC5gif0Ysr?=
 =?us-ascii?Q?n/fmJ+jo9Jwwiac7WcHNhAB8pvRD25OHJiJaP1OjHlJ6aJZc/xN/7f+DW6lF?=
 =?us-ascii?Q?I1e/xmrl09EXylQPZZfPJ0wtbXXeOp6TyTX1m+dTwoTSx9EB1D3vcPWj2pzH?=
 =?us-ascii?Q?k/jDXUNAkev5if5EYz3SbgGMQLT8K562c8ubCxYtE0Qa6BHugMZYjzmkt6jj?=
 =?us-ascii?Q?FJWaVqujRr+69xnC0eJHcU0y2THcrF70K6PYBhxMM0DPpzVVFbA+xiLXDjat?=
 =?us-ascii?Q?2AyzQ01Au8gDjGH7ba3VMV8leUrTnMYdTIKxnVvQ5JqZB60rA26jIat2crgU?=
 =?us-ascii?Q?k5eQoldt4K1m2gEtkItDy8UsuOedZvxm1AQBnBWuOeB6EL8eeidczTMoi3Km?=
 =?us-ascii?Q?L6VxdrH0pKUIaY6QOAKDm8wHp4MrPuU6Ymb5iJZTx6/PDwgNbKpLrhNU6XyM?=
 =?us-ascii?Q?+SbZ8JkP1b+iqheB2wCzufpscS7AzQXJGBmhEGotvl9J4FzuNUz6rO56zg7v?=
 =?us-ascii?Q?8W24aw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f583a2f6-37e6-4c24-2ec4-08db3058ce4f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 13:23:38.2819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: urjkq/diLyr6riLPIwupm2Udne6XFVUmIDN/pclw7xoJbNlW+RYnKKSc/VlqbKKyvjpsJLgoup4mgsFxmBc6HafxqUQih7IthJG9oGhmli8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5777
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 29, 2023 at 08:59:29AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/micrel/ksz884x.c:3216:6: error: variable
>   'change' set but not used [-Werror,-Wunused-but-set-variable]
>         int change = 0;
>             ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>