Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 15:41:26 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com,
        petrm@nvidia.com, leon@kernel.org, shayagr@amazon.com,
        wsa+renesas@sang-engineering.com, yangyingliang@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] net: ksz884x: remove unused change variable
Message-ID: <ZCRABhzLVCwfEgeQ@corigine.com>
References: <20230329125929.1808420-1-trix@redhat.com>
 <ZCQ70Rb311WzqPIJ@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZCQ70Rb311WzqPIJ@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0vRObrZW6VBiu7UYgXxXhbPyxTRC7nePpmmmt++INGt8MxS/O3hUUajJfq92?=
 =?us-ascii?Q?zAWgHdlRP67452hQ0CA2InIhVUsA7bdnQNebviWVVfYWn0Rrwze2TDbxZVgZ?=
 =?us-ascii?Q?pOG6vWF1krXQ9d4iDQGnY7TwDefqXtIk7F5xOJ3DhGAjCKMasOHbMwiL8f3f?=
 =?us-ascii?Q?fE+g+Wel44Jxw4hFCWy4N123xwcPiz0TMnlVZw0Jfsj5uPE8yZCXFDo/2CBk?=
 =?us-ascii?Q?KYFEvJp1jZEn1cq/hWNmhFUou5wgBa+ZiP5ukAw+vwCkT3YNIPuRZZ2bMXL5?=
 =?us-ascii?Q?Vu2QP3z+vxVRHfZCM9f6w63q5hDqR1lWQnAzTW5yA7lL2lIDZKVTFYrDwZxj?=
 =?us-ascii?Q?LGS00uBvFrxfFTc5SqZEP2U3jBPCBhAM0ilddTVE4HgdFG5fNYShH53hBTRS?=
 =?us-ascii?Q?vbytTWRnylyzqMvjJFRi3L0hJQYoflbPOE6ihd2d5lCej3RezUozyX35MU60?=
 =?us-ascii?Q?54NYFySlAPeNNTBD1buogxziJFSiWd1g8xVViZ28GtxNLLM/Upnglfy493Yi?=
 =?us-ascii?Q?BB+6+gPTfVFCcMSAEcE8Sk5EN57548b+f/6ccyz+XYlp90j+18AnWLwmg/VY?=
 =?us-ascii?Q?HT/MKCd3sFFHkfH/c0vZ9d87A9ErZO9pkip82CR71i7gWvldq1HaiEeqrM5V?=
 =?us-ascii?Q?RXjJ/zRcSW/WSJoZ2pP8nb9+7/NCODlduhG3IupvEndJnG6cBdCgoWT9O8fp?=
 =?us-ascii?Q?eRda3S6b3FvhmH9aNxAq1FiHGWEaEMKJXOl63VsGr3UCOaARvXgf3gsDtA1A?=
 =?us-ascii?Q?08HxK5ILEDpR1u2vODQ8cWnHRIhbpAaVVpBDgApNXv9Ese4ePIvHuuJLbxtN?=
 =?us-ascii?Q?gBLWu8S1GG+QYu+clQ61q/Gou2xbMRUU51gKAE/1HrSV4dy2zDo07XTrEBRn?=
 =?us-ascii?Q?G4OiFBbuQ8DVWCWg7KNgyrheICiH16qOWxhFQNua6pMQvKkhQ44bGtU3Z7V5?=
 =?us-ascii?Q?ExgmwdJVYLrXfsVDVvsrK5z8GoA7SMOsEIJ35GF7rML3iMbJlq0FjqH30dMK?=
 =?us-ascii?Q?Ns2OwUU/csrNLMpUR/FrgtUKn2pTlJ3st50vFUOp0wM76wDIOooJrrcMUTM0?=
 =?us-ascii?Q?1xnB7zs5PK+97NHAIGFMap/lqKRvLC590wZiPJfmJh5R5rwjLjCQFYEzN4L+?=
 =?us-ascii?Q?VWQYXTveQzJ+Fn7mzL0oMP4NaGPEA0YlC7k6th+KWlc72wnO+g1QVZ+hai2o?=
 =?us-ascii?Q?jQ+YWfth6PHqwsIS+P86D7OF3iChQT63ueHKXo/BUnavWBBW+4RtSPBKuD26?=
 =?us-ascii?Q?rDx4vaOGW8BpwiRdDso6UfniW58JbQ4QqeOWTZ0asnz44nQ89Afct0LEZNXp?=
 =?us-ascii?Q?ZjHdEbuChw/8GPXhY7BiHzb3VVKAJYA7EUrnbJwPvGCfxZsEKL59ENPXTQ6O?=
 =?us-ascii?Q?8ch9jKhjnB5yuVbSMCS/2Wo/sGBfgAyYI5Vb08hPNjSNGsFQAL8VSi5jglbp?=
 =?us-ascii?Q?ZlS/vKd0aTW+7E8C5la5ZOvYukLw3R1jEzGDFvR0/Gue2uff0UdTqnf+tEqc?=
 =?us-ascii?Q?SqZR2ro2HSr1Mf+VCWcdZcV/4g5Anjf87z2RSiMiGqNsPLBpQgXYOzREw+qk?=
 =?us-ascii?Q?QkBuFdB8j77FP1FzDihtnKKhRRyXSGn9PiXbY6RMW1L3x1cNenSJ/6iPtPVI?=
 =?us-ascii?Q?fWtwqkGDvmvVN2G8JlOuJOVgLHTYVtNVyTMJWsx42UvvopWg2wdorIXQd9SY?=
 =?us-ascii?Q?aKTrxQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64cf0b1e-e9eb-4410-4715-08db305b4f3f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 13:41:33.4329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /k9RNY1IUUbncntAAn/kyGlfFhGk00NdGTVgtCSoZNCnt2e53xxQHvBgnN0XsWbsizLd/VovCpEuxXrTWII+NhPAfPpLlwQv/zne4AwmHCY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5281
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 29, 2023 at 03:23:38PM +0200, Simon Horman wrote:
> On Wed, Mar 29, 2023 at 08:59:29AM -0400, Tom Rix wrote:
> > clang with W=1 reports
> > drivers/net/ethernet/micrel/ksz884x.c:3216:6: error: variable
> >   'change' set but not used [-Werror,-Wunused-but-set-variable]
> >         int change = 0;
> >             ^
> > This variable is not used so remove it.
> > 
> > Signed-off-by: Tom Rix <trix@redhat.com>
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Hi Tom,

I notice a very large number of unused functions in ksz884x.c.
And I think this means some corresponding #defines can also be removed.

I'm wondering if you happen to be looking at this.
If not, I'll see about preparing a patch.