Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp658388rwl; Wed, 29 Mar 2023 06:59:53 -0700 (PDT) X-Google-Smtp-Source: AKy350aK3ZN4LMUX+jyWavKFB5H9eY9MikEfvyOHRurwevjJZC4Aq/bZ+t1wq2VPxzU4lQygJn7q X-Received: by 2002:a17:902:f34d:b0:1a1:eda9:6739 with SMTP id q13-20020a170902f34d00b001a1eda96739mr15380634ple.41.1680098393632; Wed, 29 Mar 2023 06:59:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680098393; cv=none; d=google.com; s=arc-20160816; b=BCuFAiy+v4HIG9tRSQZ35ZjKTS2lzbudYHf03i3SGUZB9v7SPX5HCnvgHvg9VsJzdA 9ywX4o+D5Eqxct6GJUcUSrzI6JRIIDtO7KCDy/nW84Ey49AwFJJvaVPcniYOGyVHDZek 4lhFL6EjZjJ2Nefdq8KdAy8paesx8ZhB+tlax4Dd33l3cr0oWQoL+2Gwc7ktoiHCjlHL l9ws1v3FX8IImV9SaynCapfPCxjGT8QIDVGq5gX3l5WFdHpryGxjf7pcPd0ciSGBwkR0 bh6r0EcBi7jy5pInmlOMVq6UnaAFBxfj3OXwgEF72yX7AGKZfRsZd8doZVUFVxRjeo+O Xsjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LqW3RkMFvF3gcVAk619NmosOWZV1qP/XTRHnRjCzqSk=; b=NM+owuEOA8FcIEjuuWTcGmFDYRU0ujkEL3Y1cuS10/ULPFKwzyicSwsnIsPhQCSlru H9M8KYxLOJP1Q1tRFFgVeA44oXOavqWHnK+XQORTf+O4ZNmHrJnWZqNllgdVKbVSY/Cu UQ8UQjQa2Xq9Nfm8tubWS9PG+J+xFutlSYpNqW3Bp0ipHUq8FYgZ4fHmnzzhtz82qCXR XGt8Z86JoBYNB/kYJhEFTvH+rnW5k68r6uJbAQrTSppUYjb7ZEuXDsrUQ/pLq6A5Xe9Z IAgJGgfjnugM4zGvnKZXUU0vy/hEt/6tBQ5H+iQQsVsZ5dfuO2zI0JRnJ38d6mshAXIM 0z5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lWDRmXA3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g20-20020a170902e39400b0019cec50618csi29598350ple.159.2023.03.29.06.59.40; Wed, 29 Mar 2023 06:59:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lWDRmXA3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230372AbjC2N6T (ORCPT + 99 others); Wed, 29 Mar 2023 09:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230360AbjC2N6S (ORCPT ); Wed, 29 Mar 2023 09:58:18 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 548B84697; Wed, 29 Mar 2023 06:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680098297; x=1711634297; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ck3URVmLgHrVhcVJ5gg7rR62G4o0wwV83BuwrsZ3cYk=; b=lWDRmXA3XdUj9Q5/tN1xDVTjIXA6UfL1R/apwlZIg4V6cZeicPZANeII KkWp2Q1Cin8PXYTnRxfKjENdMGiMjgWkMw0sYFbf4neUTS/nkerNGHTqc +YpdYytIcNBywX1tDyXBxZ7nmDovNQYiZDaNpr1pdhgd/BWcsjQKAR7/B yHbfuxEby32cOtElwlFJrYPtLuXtmOvLFqUFZbi6FEaoptL5hTNDd9UQh B2rEet2b2vtMiJFkVUwLYx+jjloumydvlOBz3UIJqvGsvQVGsdmreT6Wv 5uyilJS7NiOL10TnJ1rhCFfNHH0HeePPwHXgHpGvk39xvgzxlhmWl+xnW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="329348375" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="329348375" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 06:58:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="716892985" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="716892985" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 29 Mar 2023 06:57:54 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1phWJF-000Jb6-0H; Wed, 29 Mar 2023 13:57:53 +0000 Date: Wed, 29 Mar 2023 21:56:55 +0800 From: kernel test robot To: Anuj Gupta , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , James Smart , Chaitanya Kulkarni , Alexander Viro , Christian Brauner Cc: oe-kbuild-all@lists.linux.dev, bvanassche@acm.org, hare@suse.de, ming.lei@redhat.com, damien.lemoal@opensource.wdc.com, anuj20.g@samsung.com, joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com, Nitesh Shetty , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns Message-ID: <202303292148.Pbx4mDpS-lkp@intel.com> References: <20230327084103.21601-7-anuj20.g@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230327084103.21601-7-anuj20.g@samsung.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anuj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linus/master v6.3-rc4 next-20230329] [cannot apply to device-mapper-dm/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/20230327084103.21601-7-anuj20.g%40samsung.com patch subject: [PATCH v8 6/9] nvmet: add copy command support for bdev and file ns config: arm64-randconfig-s041-20230329 (https://download.01.org/0day-ci/archive/20230329/202303292148.Pbx4mDpS-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/linux/commit/f846a8ac40882d9d42532e9e2b43560650ef8510 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Anuj-Gupta/block-Add-copy-offload-support-infrastructure/20230329-162018 git checkout f846a8ac40882d9d42532e9e2b43560650ef8510 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/nvme/target/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202303292148.Pbx4mDpS-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: got restricted __le16 [usertype] mssrl >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 >> drivers/nvme/target/io-cmd-bdev.c:55:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:57:29: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int [usertype] val @@ got restricted __le16 [usertype] mssrl @@ drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: expected unsigned int [usertype] val drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: got restricted __le16 [usertype] mssrl drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 drivers/nvme/target/io-cmd-bdev.c:60:27: sparse: sparse: cast from restricted __le16 vim +55 drivers/nvme/target/io-cmd-bdev.c 12 13 void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id) 14 { 15 /* Logical blocks per physical block, 0's based. */ 16 const __le16 lpp0b = to0based(bdev_physical_block_size(bdev) / 17 bdev_logical_block_size(bdev)); 18 19 /* 20 * For NVMe 1.2 and later, bit 1 indicates that the fields NAWUN, 21 * NAWUPF, and NACWU are defined for this namespace and should be 22 * used by the host for this namespace instead of the AWUN, AWUPF, 23 * and ACWU fields in the Identify Controller data structure. If 24 * any of these fields are zero that means that the corresponding 25 * field from the identify controller data structure should be used. 26 */ 27 id->nsfeat |= 1 << 1; 28 id->nawun = lpp0b; 29 id->nawupf = lpp0b; 30 id->nacwu = lpp0b; 31 32 /* 33 * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and 34 * NOWS are defined for this namespace and should be used by 35 * the host for I/O optimization. 36 */ 37 id->nsfeat |= 1 << 4; 38 /* NPWG = Namespace Preferred Write Granularity. 0's based */ 39 id->npwg = lpp0b; 40 /* NPWA = Namespace Preferred Write Alignment. 0's based */ 41 id->npwa = id->npwg; 42 /* NPDG = Namespace Preferred Deallocate Granularity. 0's based */ 43 id->npdg = to0based(bdev_discard_granularity(bdev) / 44 bdev_logical_block_size(bdev)); 45 /* NPDG = Namespace Preferred Deallocate Alignment */ 46 id->npda = id->npdg; 47 /* NOWS = Namespace Optimal Write Size */ 48 id->nows = to0based(bdev_io_opt(bdev) / bdev_logical_block_size(bdev)); 49 50 /*Copy limits*/ 51 if (bdev_max_copy_sectors(bdev)) { 52 id->msrc = id->msrc; 53 id->mssrl = cpu_to_le16((bdev_max_copy_sectors(bdev) << 54 SECTOR_SHIFT) / bdev_logical_block_size(bdev)); > 55 id->mcl = cpu_to_le32(id->mssrl); 56 } else { 57 id->msrc = (u8)to0based(BIO_MAX_VECS - 1); 58 id->mssrl = cpu_to_le16((BIO_MAX_VECS << PAGE_SHIFT) / 59 bdev_logical_block_size(bdev)); 60 id->mcl = cpu_to_le32(id->mssrl); 61 } 62 } 63 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests