Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Drewek, Wojciech" <wojciech.drewek@intel.com>
To:     Andrea Righi <andrea.righi@canonical.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: selftests: net: l2tp.sh regression starting with 6.1-rc1
Thread-Topic: selftests: net: l2tp.sh regression starting with 6.1-rc1
Thread-Index: AQHZYjl1GRPOFSRp8EO/z00nY9tXgq8Rxqfw
Date:   Wed, 29 Mar 2023 14:16:37 +0000
Message-ID: <MW4PR11MB57763144FE1BE9756FD3176BFD899@MW4PR11MB5776.namprd11.prod.outlook.com>
References: <ZCQt7hmodtUaBlCP@righiandr-XPS-13-7390>
In-Reply-To: <ZCQt7hmodtUaBlCP@righiandr-XPS-13-7390>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?nEzAF295Pq+PmdyS9Pj8hwteLV+/b9iwySRSkZTVtnh2LQ66sGmePWRMUU?=
 =?iso-8859-2?Q?KhZABY0iLyNZXEDWfvZMllIh12B/l69pXx8/oF5nbT3OIzmaD5UXsylnEc?=
 =?iso-8859-2?Q?LqxkiYuJTMdkz8y0FE+uU9vjtQu/M/RjcdOkh9ZLqEExKBjDLl+VXDHmQI?=
 =?iso-8859-2?Q?vDQnbAuPkKlDorfNw+Vcs8oG+UrAtm4NZwth6vs91xWlV7hvqJ/S7PYksq?=
 =?iso-8859-2?Q?rNPuncKKs0foowuRGYKywGB+zXEQJvoGoLBvom+DoiPWJrpFf7S5LmGcIa?=
 =?iso-8859-2?Q?I9I9f8Sonb2OML8vZOq+1RAJRFdkti71CI+hXDz9ynFiACvK7pZz0epD6+?=
 =?iso-8859-2?Q?xhuuEt2qECV0AtJrAQKMPRIefe6MaGy+yjIVU/tEPEQRC04KPqgW/rLhF8?=
 =?iso-8859-2?Q?0XDwALsDW7hkB9ji9OCgOxURfpjhmHCaDqzGlqj39zGZrqkrQd1B0PevEW?=
 =?iso-8859-2?Q?+ITahe61mOBtsXgaZy9WtkkAk+IwwziAPoo6O37UQFgldDgn2bE8JS1jyH?=
 =?iso-8859-2?Q?wz1u4IOVi/Cizmcx9aj0r2wTEmi8B9oNzDP5zJv6Eh0ESGEyY0ev+YLIOW?=
 =?iso-8859-2?Q?ZLnrqSnxm1zPrIO/qsqNwMJ5RSS/40uo9ZdkDSFfqYnmi0xOOpNmQ73RQb?=
 =?iso-8859-2?Q?zLzV0eEF56rH03/oHbpZFFaTE7J6EahOIsaCP/9MrXtD2EdhXTrfsHuNN5?=
 =?iso-8859-2?Q?UvPPu0lrdKzGVpV0EDAJwUD5vPgvUva4QaHYcuBA04oaZf7Rz1wn6NCoFL?=
 =?iso-8859-2?Q?ujaRJuOOrk55CWo96+FD/pQDQs3jqyADebXbw2HOTS4WNgCFBgBi04vUWS?=
 =?iso-8859-2?Q?2eSlYAvrDgoCBRItlhMZjHsW//l8/0wTzQ8piDYbpmy11XE6A3ZjOCVBM7?=
 =?iso-8859-2?Q?zUCxEwZS67vF0gkfb4UYwUZJVVRF8IMiKoKBllTNQXBdrb2ohf0srqw5Wz?=
 =?iso-8859-2?Q?bzdcM0Ezp0nENlWV66yNoZuB7KTYwFXhZ0EsxIW1KeZeyrfuTc+iTd/vfd?=
 =?iso-8859-2?Q?q8puykEJynUNT2IJdt/n7b03issdUbqstLz6JHOn88/riyOerPBwfyt5ba?=
 =?iso-8859-2?Q?g8seha3Od1vKlRP+wzqgwwWBziAvwVFXK/VQ1q1AvZT8Gr8toEkjLTyaxL?=
 =?iso-8859-2?Q?BEUJzllr+qvWOhUMgAvDhKch2+2aAb4X5cTbUCRcP7mAl0sCFItOGltCpd?=
 =?iso-8859-2?Q?kybtL2XnkuNgxaEl/pWyD/+6WS3S43XH+pPivZ1EMdsR3UXKqHcqt6Gatq?=
 =?iso-8859-2?Q?1OYeET5k3q0U9o0ImkuzL+qTYHRwHgW084/GkpOtrHWwnI1q1i/kGTKwMQ?=
 =?iso-8859-2?Q?deAfG9Q3Ttl3ywPhv7lflamD0poiFuwiV6cYyYRxlD/HEptgPmMa2kAe45?=
 =?iso-8859-2?Q?zyB6by1nze2xzo0SxE4nXE3EtOcS1ZjcycS1C8qSyn2Ety4jQA74Gtulxe?=
 =?iso-8859-2?Q?fYSx35UGPq6ATrdRKUE+Jm4Lx0tIAJhHmSK0vxSKpVtFvbYDhd0EXYpErR?=
 =?iso-8859-2?Q?5c3KWctaaolJkJ69gkzom8yumtjZRuPg6Ei54ep+ZWBw75dj52A3Q78UOx?=
 =?iso-8859-2?Q?nWT/OPzLT34TknwR/bG7YDBOIiUkZPy2qg2tqrNkodsmY0SIjsJHX9bn4K?=
 =?iso-8859-2?Q?jZFVEiYgEUTgip+n58d0FRXICU0kkal6Vf?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc256c2a-09ff-4894-3493-08db3060355d
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2023 14:16:37.2943
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QR2FvFyZcHJ6z107m1DSlazzshplsoP7k4uspwY6VvmlGrdpkfBo0zqMBl2frzaG5Fi25mF/K9/uaWiGgE1sa5jVGjzfHRLn9VMjcVtEBcs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5473
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Modifying UAPI was not a good idea although the patch should not break user=
space (related discussion [1]).
We could revert this patch with one additional change (include l2tp.h in ne=
t/sched/cls_flower.c) but then again,
modifying UAPI. This patch was mostly cosmetic anyway.
Second option is to try to fix the automatic load. I'm not an expert but I =
think
MODULE_ALIAS_NET_PF_PROTO macro is somehow responsible for that. I noticed =
some comments saying that
"__stringify doesn't like enums" (this macro is using _stringify) and my pa=
tch defined IPPROTO_L2TP in enum.
We can just replace IPPROTO_L2TP with 115 (where this macro is used) in ord=
er to fix this.
I'm going to give it a try and will let you know.

Regards,
Wojtek

[1] https://lore.kernel.org/netdev/Ywis3PYhKiATnzXB@nanopsycho/

> -----Original Message-----
> From: Andrea Righi <andrea.righi@canonical.com>
> Sent: =B6roda, 29 marca 2023 14:24
> To: Drewek, Wojciech <wojciech.drewek@intel.com>
> Cc: David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.=
com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Shuah Khan <shuah@kernel.org>; netdev@vger.kernel.or=
g; linux-kselftest@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: selftests: net: l2tp.sh regression starting with 6.1-rc1
>=20
> I noticed that l2tp.sh net selftest is failing in recent kernels with
> the following error:
>=20
>  RTNETLINK answers: Protocol not supported
>=20
> See also: https://bugs.launchpad.net/bugs/2013014
>=20
> Apprently the module lt2p_ipv6 is not automatically loaded when the test
> is trying to create an l2tp ipv6 tunnel.
>=20
> I did a bisect and found that the offending commit is this one:
>=20
>  65b32f801bfb ("uapi: move IPPROTO_L2TP to in.h")
>=20
> I've temporarily reverted this commit for now, any suggestion on how to
> fix this properly?
>=20
> Thanks,
> -Andrea