Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp740265rwl; Wed, 29 Mar 2023 07:55:29 -0700 (PDT) X-Google-Smtp-Source: AKy350bpxo+GjOL/3yZdDRu5cbtzd4Telc69ginMTwTYPazI16nIgC+1pO//HLlBWUimyTkvPM6r X-Received: by 2002:a62:17c9:0:b0:625:ce21:3b1b with SMTP id 192-20020a6217c9000000b00625ce213b1bmr16578714pfx.3.1680101728928; Wed, 29 Mar 2023 07:55:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680101728; cv=none; d=google.com; s=arc-20160816; b=G71Kw6fsF51wtLu2y00H25+AFEh0Fqg7FfIhIu3q7RWp6USJDXFWLVjezjF0Etb/HR mNh8w+vHxo5XfCYTaoJPr3XNjOXw8IDuAjCzR6TRNfyIpjybpT4QJHILWE+sdJ3vtHYJ +JLsERv7guYfRf7x2SyELWJg8//9L0hVzpff+l72X8OKGJYLS1F+djm/sYQ3DDWYdYR5 H1rWLSxQFJuTfvzfizI0v9fLPYFnV024oqZ4bs8P43RzO0GpWMLlfOaM8koiwYqXUT7U lLzA9yW4r49iM6nQoD95dXpW41zUmNf9qMWKB0uY+lT8nq6ITOfv2PpRnkaWczCzKp20 +stA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WvYhhpbeU80HU0h+X9OMYDOPX+zv63vHlKhtAvy3f2U=; b=MIrfELEuul1rmZpXPfbasdu1PkjcatiL3ACmazcb8ecb5YlkFRtFy1x5sTay8XsOA/ mYdBJuLHyB5xI7dE62t6NX/DZijXUMLfXZ1N9v9Ev67Q8EH6deLo6RgPH8Q96soWZutp VbWnQiH1zow2rl0paFpTYRCkbs96G3xA1tycxRm6ykexFeun89U00H6vnLaR4joDALrl mQO+q1IcqBtmgSWsu7fXWDORWcraEnlhwowkSj4Ld28jy319hTcXFkP+JLmGiFbyVtlU VFbuWi9WVl9mtUE6HPjXVcwLzB9jQnHoW2U9DZmI0RnyzXGW8C1U/NwPb8TVUfDtfHiI dIkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C5czJaOJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q1-20020a056a00084100b006257c287ddcsi32921249pfk.45.2023.03.29.07.55.16; Wed, 29 Mar 2023 07:55:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C5czJaOJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbjC2Ouc (ORCPT + 99 others); Wed, 29 Mar 2023 10:50:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjC2Oub (ORCPT ); Wed, 29 Mar 2023 10:50:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B578D8E; Wed, 29 Mar 2023 07:50:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 61542B82105; Wed, 29 Mar 2023 14:50:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 607CCC433D2; Wed, 29 Mar 2023 14:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680101428; bh=eYl93MUIVFF6BLBKgWr8lqbFVa1ntSPyCl9lEoHchcI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C5czJaOJZhcF44+QDVhnXsDcOYQduzOs4tSkaL5cfs1gmL/YOadkgwpwqHvJ882dN RdkIO/sMlhAtQYsD2wLrFBj7eumSAP6RBGwjTMyjZcKWI0v8rPfWviJxyV9kJIQbT1 uMebe+NYahzuRy54PyamPntuF2n6V4416w1YItkO1HPynWU66EtzoS11Za7kYKKf7k IGaG6KrX0HI2GFnt6HF2PzLJQl9pH1LeS9AyAgqS1dPr4ErGV203Dmsie7JVAYkIar 5S9w0QRuLKar2xssmAFx58Au6tCI4BuYT41A+COsYiMLUxMtAmsaKNoytomWlAdfhx 3j6OEgM5BtP0w== Date: Wed, 29 Mar 2023 15:50:20 +0100 From: Lee Jones To: Julien Panis Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, corbet@lwn.net, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com, eric.auger@redhat.com, jgg@ziepe.ca, razor@blackwall.org, stephen@networkplumber.org, davem@davemloft.net, christian.koenig@amd.com, contact@emersion.fr, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, sterzik@ti.com, u-kumar1@ti.com, eblanc@baylibre.com, jneanne@baylibre.com Subject: Re: [PATCH v4 2/4] mfd: tps6594: Add driver for TI TPS6594 PMIC Message-ID: <20230329145020.GU2673958@google.com> References: <20230327154101.211732-1-jpanis@baylibre.com> <20230327154101.211732-3-jpanis@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230327154101.211732-3-jpanis@baylibre.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Mar 2023, Julien Panis wrote: > This patch adds support for TPS6594 PMIC MFD core. It provides > communication through the I2C and SPI interfaces, and supports > protocols with embedded CRC data fields for safety applications. > > Signed-off-by: Julien Panis > --- > drivers/mfd/Kconfig | 32 ++ > drivers/mfd/Makefile | 3 + > drivers/mfd/tps6594-core.c | 462 ++++++++++++++++ > drivers/mfd/tps6594-i2c.c | 244 +++++++++ > drivers/mfd/tps6594-spi.c | 129 +++++ > include/linux/mfd/tps6594.h | 1020 +++++++++++++++++++++++++++++++++++ > 6 files changed, 1890 insertions(+) > create mode 100644 drivers/mfd/tps6594-core.c > create mode 100644 drivers/mfd/tps6594-i2c.c > create mode 100644 drivers/mfd/tps6594-spi.c > create mode 100644 include/linux/mfd/tps6594.h Note to self: I already Acked this once. -- Lee Jones [李琼斯]