Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761406AbXIUPru (ORCPT ); Fri, 21 Sep 2007 11:47:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759122AbXIUPrm (ORCPT ); Fri, 21 Sep 2007 11:47:42 -0400 Received: from bipbip.grupopie.com ([195.23.16.24]:50921 "EHLO bipbip.grupopie.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1758801AbXIUPrl (ORCPT ); Fri, 21 Sep 2007 11:47:41 -0400 Message-ID: <46F3E79B.7030305@grupopie.com> Date: Fri, 21 Sep 2007 16:47:39 +0100 From: Paulo Marques Organization: Grupo PIE User-Agent: Thunderbird 1.5.0.12 (X11/20070509) MIME-Version: 1.0 To: Steven Rostedt CC: Satyam Sharma , Gilboa Davara , Linux Kernel Mailing List Subject: Re: [PATCH] Reduce __print_symbol/sprint_symbol stack usage. References: <1189856129.18191.11.camel@gilboa-home-dev.localdomain> <1189869329.18191.77.camel@gilboa-home-dev.localdomain> <1189879681.18191.93.camel@gilboa-home-dev.localdomain> <46F1314B.8040105@grupopie.com> <20070921145628.GE15697@goodmis.org> In-Reply-To: <20070921145628.GE15697@goodmis.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 31 Steven Rostedt wrote: > On Wed, Sep 19, 2007 at 03:25:15PM +0100, Paulo Marques wrote: >> if we change the interface from "print_symbol(fmt, addr)" to >> "print_symbol(prefix, addr, int newline)" we can simply do: >> >> printk(prefix); >> printk_symbol(addr); >> if (newline) >> printk("\n"); > > NACK > > I just wrote something that does "print_symbol(" %s)\n", addr);" > Notice the ")" in the output. We can just change that to "print_symbol(prefix, addr, suffix)" instead. The concept is basically the same (and I wasn't very fond of that newline argument either). As an added bonus we stop needing an extra layer to check that the string passed is in the right format with a single "%s" in it. -- Paulo Marques - www.grupopie.com "Very funny Scotty. Now beam up my clothes." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/