Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 23:43:10 +0800
From:   Jianhua Lu <lujianhua000@gmail.com>
To:     Richard Fitzgerald <rf@opensource.cirrus.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Simon Trimmer <simont@opensource.cirrus.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
        patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [PATCH] Asoc: wm_adsp: Add support for loading firmware with
 prefix name
Message-ID: <ZCRcjgMWhV0dp8p0@Gentoo>
References: <20230329130525.15830-1-lujianhua000@gmail.com>
 <57c5a3b3-00cd-5b44-02f4-dedabacc7662@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57c5a3b3-00cd-5b44-02f4-dedabacc7662@opensource.cirrus.com>
Precedence: bulk

On Wed, Mar 29, 2023 at 04:33:08PM +0100, Richard Fitzgerald wrote:
> On 29/3/23 14:05, Jianhua Lu wrote:
> > For platform using fdt, system_name is NULL, it doesn't provide
> > a way to load firmware with prefix name, so add it.
> 
> This is intended behavior.
> 
> To load per-amp tuning you must know the function of each amp.
> You only know that if you know what hardware platform you are running
> on.
> 
> So if system_name is NULL it should fall back to generic firmware.
Make sense