Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp823834rwl; Wed, 29 Mar 2023 08:57:26 -0700 (PDT) X-Google-Smtp-Source: AKy350aRp2BcbN92gAgbuxoEvi4CANxFj9q1brJEjPxZhY6+lAkoAxIP89Z1h5EFR0oExI9JwT9x X-Received: by 2002:a17:907:6d24:b0:93e:9362:75fa with SMTP id sa36-20020a1709076d2400b0093e936275famr22747124ejc.47.1680105446238; Wed, 29 Mar 2023 08:57:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680105446; cv=none; d=google.com; s=arc-20160816; b=rsaLr3tPivmuzFVT82l8dPEiNr+h57a+vvnEuxIQ1qf6N0yW7gZYx0poNb29b/HNH1 IdYRj4MiGzhX7T6KAn1qOSbCK7yBncyr85KlNqyLqndqrpBsuQ2nbbAhFYyoTJBjI1lm 2xBh6p97zFmycYiGooH1FDmvhqi+sD+X5vLVAZnRTVRjOY9ZuVckLO3f7gB6xUZLZ35l TYJqKBPxOf40PnEfoZJ86T2b4d8fNrEY6M1CmXsCG/XwThGduIisDk7+NMMD0d3SULYt 1GkurFHakDiSffGwDAk50Z0PD3ZzU06odNCmf7mmUs/zJLehEZZfMl+AXFWdstnl8OrH puAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=p/ajfvBQTErdVHrQqdHTV8eJEA/8/+bHBYeF2lwVNsg=; b=mrnPH5sTIWRjV/knh8iLw9checq6PR6XitRM7hd8MxuCW0zOc/Sqgxzce1T+bXrTVz s7PE03wm73TcOxm3bRaTUded4sWwpprajIYQWoiw10URgz0hgid5nVfJrcswnoCXT8L+ FSPRXpl/tt4HkgChPUtKxvc9q8aR0Rdb7YzUnm5KTuzyx+Ihdt+ZDBwpEsTEdkwVZCWX S63X8Fk5PaYN1LEIWm7QHB+zj8PhyHM+JPfRX2NsO90GdtQiD0xoIAbVCGoxt1QE6utH xbyxQ+RH7joLibeCxfVaGbFhZhEI6ufi8NRfKJslUHW0VVSYSYq4KoogkfxdWCPcvWPH dTUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=SOkFAslu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n8-20020a170906700800b0093161749da7si24902853ejj.369.2023.03.29.08.57.01; Wed, 29 Mar 2023 08:57:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=SOkFAslu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229996AbjC2P4b (ORCPT + 99 others); Wed, 29 Mar 2023 11:56:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbjC2P4O (ORCPT ); Wed, 29 Mar 2023 11:56:14 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DBAA6A45 for ; Wed, 29 Mar 2023 08:55:19 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id t4so11030331wra.7 for ; Wed, 29 Mar 2023 08:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; t=1680105278; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p/ajfvBQTErdVHrQqdHTV8eJEA/8/+bHBYeF2lwVNsg=; b=SOkFAsluPYOQnvWnrI6rJWoGQCnPbGS4aPRnkzovQR9VqxnEUy0RXhloFovA+8rqKn 4tjySc4vKqnSmZo2NsDpADZ+2w/ZgOqg3xd6zSCXolYkZB71bMPXl12m/XMQpXnpXGg8 I2U55HCmBQ6I+ky0/6zXA2J3/3GxN/VO+1JuWMgBEWf/WA2kIszLZrHji2mLoZ8qBwvz PBxWci7BcAWgM2tfy48tRjM2vYhYj6pWwtXTztz+hkCIknYAP/7cmXy/ZUe4O3RXXPCP 1vWBYR/+icccwZHPv5Ds0p/b+hy4Sn4rT0dNNrZgtVPuFGoJRNvEgqG5fD52Iowkd2cI hYuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680105278; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p/ajfvBQTErdVHrQqdHTV8eJEA/8/+bHBYeF2lwVNsg=; b=XlpL4gR3AQEfiRYxdVU+mfHWO93qXgcfOenpPLxMNozSN0Vs09VNYC6jgJ0aDUL/T7 SsMnDEtXMQ2J3SQ4RgQLCHUox2o85bWC1q7fPKFJGVQ+vIub+bNLQppOQDx2CChonAEF liaxNB2DQLy5Rg7QKVPiVR63PO0bDvvdviG4sUW+vCfQ8OJuwPZnxQ3GqQW50C0cDEFY vy6Qm7U7rp1Rm8HuK/XS/0AFU2/NypCUq421TyEKElZhCps8hJ4ltoXVMGwZxuCONdWu tzkjArPG0Pduo7i6rqEHuEEsN1VOqqRnGT8m1BolN7uI9UVvZD9JIrM9V9jgeez5DBRZ QL8g== X-Gm-Message-State: AAQBX9efim9jupfGssOoYBecSoHMLXmrfxT+OPQlcRMrXe6FwbxM78RN VO7NPmc9IhAYgIsqGzZT5R2j2HM39ud4tMCUxFbqpQ== X-Received: by 2002:adf:ec87:0:b0:2d1:46eb:3f98 with SMTP id z7-20020adfec87000000b002d146eb3f98mr16685731wrn.36.1680105278598; Wed, 29 Mar 2023 08:54:38 -0700 (PDT) Received: from localhost ([2620:10d:c092:400::5:e994]) by smtp.gmail.com with ESMTPSA id e13-20020a5d4e8d000000b002ceacff44c7sm30650177wru.83.2023.03.29.08.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 08:54:38 -0700 (PDT) Date: Wed, 29 Mar 2023 11:54:37 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, surenb@google.com, brauner@kernel.org, chris@chrisdown.name Subject: Re: [PATCH v4 3/4] sched/psi: extract update_triggers side effect Message-ID: References: <20230329153327.140215-1-cerasuolodomenico@gmail.com> <20230329153327.140215-4-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329153327.140215-4-cerasuolodomenico@gmail.com> X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2023 at 05:33:26PM +0200, Domenico Cerasuolo wrote: > This change moves update_total flag out of update_triggers function, > currently called only in psi_poll_work. > In the next patch, update_triggers will be called also in psi_avgs_work, > but the total update information is specific to psi_poll_work. > Returning update_total value to the caller let us avoid differentiating > the implementation of update_triggers for different aggregators. > > Suggested-by: Johannes Weiner > Signed-off-by: Domenico Cerasuolo Acked-by: Johannes Weiner