Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fba14fea-787b-c5b2-a72a-ab802f76b3f7@amd.com>
Date:   Wed, 29 Mar 2023 12:07:56 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 2/2] drm/amd/display: Add previous prototype to
 'optc3_wait_drr_doublebuffer_pending_clear'
Content-Language: en-US
To:     Caio Novais <caionovais@usp.br>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Wesley Chalmers <Wesley.Chalmers@amd.com>,
        "Lee, Alvin" <Alvin.Lee2@amd.com>, Jun Lei <Jun.Lei@amd.com>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>,
        Gabe Teeger <gabe.teeger@amd.com>, Roman Li <roman.li@amd.com>,
        =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>,
        Deepak R Varma <drv@mailo.com>
References: <20230328220947.108188-1-caionovais@usp.br>
 <20230328220947.108188-3-caionovais@usp.br>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230328220947.108188-3-caionovais@usp.br>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDJJelBZZ1hGS2VXVG9vWDJwWSthL1NkdUtlN1VZbWRsaXE5dlpHQ212UEVi?=
 =?utf-8?B?MTR0NFBvMmVkSmhXdFNuVjBuWFFMYkZNUWZzSkd3cXlYRjlQTVQ3UyszR3VS?=
 =?utf-8?B?cGhEcEkvZW5yZnRRcU96SUJlMkpsTkZOUFdiVDJORmZONXlkU0lyQm5KRXJY?=
 =?utf-8?B?SjFIbVJxRiszeVJJTnRqb2hycWpHdGIzZnp1Q3l2OTM4TkEyZitEbE1wazJ5?=
 =?utf-8?B?R2Z5dVlOSkM0bVh6aFRWd3ZzcmY0V3dOVm96RS9yOXZ5QzdtYms3bVp2N091?=
 =?utf-8?B?VVRDak1FRWV6aU9jYkI2STZ0N3h3K3JseG5xNk42UjBZNjR6M2U4aFFiUThG?=
 =?utf-8?B?VlgwUm1iWnEzcE9XUS8wZ1R3Qkk5bkxBSEwrYjNCVU5ST2k5NGEvSGx0TFFn?=
 =?utf-8?B?KzZpL0hDUGg5YlRpYUhNVnlyUGpGL2tPQkFXRGoraXZvOHVEUmsvaEMwb2lu?=
 =?utf-8?B?cm9IQll5MmxRbjZ5S3JuTFhncFA2VVMrbVAvdEcrTkE2RjNQM2NYOVhha250?=
 =?utf-8?B?RTZjNUZ2RTJKYUNVR2twMy9OcXF6VVJMOU90ZGdqaU56NWFQeW16NS9OQnNX?=
 =?utf-8?B?QW44N2RGQTFwY0JIZEpjUFQwNkxvRDc5Rit1TSsvT0o4TE9iNFBRcjRkOEZv?=
 =?utf-8?B?L2Z0emxJUHRNcHY1TmR2NmQ4K0ZkNTM2ZXZQMHpEbUJMNStqUHdIcHRJREJl?=
 =?utf-8?B?U29XNmJTWjdaUy9XZ3R4NitONUhCd1pIL3NUeXBXQkhuVlk0akMxUnB1RmtO?=
 =?utf-8?B?cnlDZzlBbUpWN0V2eTJrTEpSOTBEVkc4NzBaQzlzMi9IVEJpQXZ6eFBJaWNt?=
 =?utf-8?B?ZXFMS0Y4Q1ozOENRcjB6WEREMk80M3VlcmVmSGVyQzlXaTArV2xjODNxUUdu?=
 =?utf-8?B?ay9jZnhIYThsSWFDWFFaeTc1TFlXUExtTEtSajZDZGduNmgrdTgzdDBpYXhu?=
 =?utf-8?B?ZGlPdjBvQVlhbWpiZlNuWHk1cHVrN1h6Z1psa20rUzVDS0IvZFVhVGVOR3px?=
 =?utf-8?B?d2o1OXd0ZVZWdkdyVWZtbUNMODBqRVcrcEtlTkRiNlU4SnV4elFQZWdFRmtn?=
 =?utf-8?B?VGVhSlR0MElQbkhsZVp6SCtQby9jREpEV0RnYTloLzZNallWTi9YVHBKNnhX?=
 =?utf-8?B?UXpkdWFJQmdRSFhkWWNsWnpKaUVYbFIwbjZCa05mZmllRDE1WkVEa3dQbXYy?=
 =?utf-8?B?QmtBTGhNMzdrTXJIRHNhWC9xbG9saC9TQWxGRFdod1BvR1hweHJKbWlFdk5k?=
 =?utf-8?B?OGY0Ny9qQjBFYTZrSzhVSnJFMFVBSE9udnI1VFJnV2tERkRSNnROellIWkZo?=
 =?utf-8?B?N21tdWw4ajlCdFd4bkZTMzNNSGdBcEgweXBwMEdjZGZMaHh3Ym9YR3ZkODFS?=
 =?utf-8?B?N1JycWtyNHBxcFVBSmFQd0RkaVZwYlprSFRJRmdHYW9LRzlXTzJ2UVFIVmpC?=
 =?utf-8?B?Mm85dmx3YURyMlNpYjkyNFNna1dDYXZFVnFsUlI2b0tBT3UzMmkyRW0vNzN1?=
 =?utf-8?B?clRqbGxqOHNhQlV4aWdTZUtMOTcxemVtdjVrRUlEcWk0bEdzemJ2RjlBTDVi?=
 =?utf-8?B?dWlGTmROcUx5NXlrUUVHWm5ITlpyMjBoNFN4T3Q3YVc1YkFPenBNeXBIODRk?=
 =?utf-8?B?QlR6MGpHbFJuUFpqYzZra2F6NXBrVXp4NU9iclBSbVprZjNydEhzN2RwKzVp?=
 =?utf-8?B?eW9SV0dCdlpGcndodFpwVE9kM0lVbm1Xcllib3VIZWFYNkFUZzNaZHFpRVgy?=
 =?utf-8?B?VzlEYnE2TWhuVHg0OHIzZ205UVVMYXV5c1VYeGQ3QllqM2dqcGh5TkFTaHlR?=
 =?utf-8?B?SFN4VFNWWXI0OXlKYTJGVmRSVndSclRiZld2dWliUmtoR0JwbE9FczlzV0Vy?=
 =?utf-8?B?WXhKRW1UMnM4em9pVHVGS0tPaXlvaFZpcityMW00WFMwZG9MRTIrZXZzejRS?=
 =?utf-8?B?ajcxbDNXOWdLWW5CM0tqRVlkRnBOWWtvNmowVHlrcE9QZjlLSXRSeXNJMldC?=
 =?utf-8?B?YktLTGFPMnpIRzNMR0pQdHRiU2Fud3l1VEcvdmQyWHI2dVJoYzRvZkRLaTl4?=
 =?utf-8?B?OFd6QjZyYWpRZW9XeEllVEZLZVlmWGNxTkZsQzIvaGpXMWtyZkJyS2dJWWln?=
 =?utf-8?Q?Z/eKtPYiK95sPHlnWTpQeoAas?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7068e712-64f1-4099-43b5-08db306f93f2
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 16:06:38.6950
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YNtchfnCwrG/qP3thYmgWvEuhADna15wLXNGa1hPZCOawBjnd8gSb6buEWcVUN+qFObUZ+iI2A4/F+9ZfsJaCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6853
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/28/23 18:09, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]
> 
> Get rid of it by adding a function prototype
> 
> 'optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)' on drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> 
> Signed-off-by: Caio Novais <caionovais@usp.br>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> index fb06dc9a4893..2e3ba6e2f336 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> @@ -331,6 +331,8 @@ void optc3_lock_doublebuffer_enable(struct timing_generator *optc);
>   
>   void optc3_lock_doublebuffer_disable(struct timing_generator *optc);
>   
> +void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc);

I would prefer if you marked the function as static instead, since it is
only used in dcn30_optc.c.

> +
>   void optc3_set_drr_trigger_window(struct timing_generator *optc,
>   		uint32_t window_start, uint32_t window_end);
>   

-- 
Hamza