Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp904881rwl; Wed, 29 Mar 2023 09:53:24 -0700 (PDT) X-Google-Smtp-Source: AKy350Zzla1FsA2b4cq7E8ClP8mflSmohsw3IRYlUCZ5tWnMhmA7VQEB4NL3vF9LePRCpYVsP8+3 X-Received: by 2002:a50:ef01:0:b0:4fb:de7d:b05a with SMTP id m1-20020a50ef01000000b004fbde7db05amr17210957eds.40.1680108804647; Wed, 29 Mar 2023 09:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680108804; cv=none; d=google.com; s=arc-20160816; b=jPW0dg4uQybRGcWuzzzCngOa7X6QLPjvOJ2ZFEuLzz8MBUADUB+PSAMk2Qpg2J12bo lczctxfg2fMCQ5WNyBDChwAUDtKTNbjG4hHN41lxC+IZ/vn6nzcuXeXMb18qbWZyRzvs 07j9rakhCzdWI1r6F4+aV5p9LMKF3Qz0kW2sLa3UC8w2mG4GYCd4kDHWSdjkqDezSd/f KB6rR2YxvnENKEEEGze+9rjFFgOH0hm46uzF8nWmKNfXpjCEyomc1n3O4YvZ6k98tj5S R2q4sOC+vOPwR6n1afT3k4tqJ9GUy8TMvnYk1Sb86XVXmxtKRKBDz7Znw0d5kK3HPNTM eoBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+jXKHUtknIYsW5onYdVNmhni/4ffvAb6VEdjSV93nTE=; b=Ezxu34fw+XhCGkM58LYmWQSfbtZH1rXV0P0kGtGkvgT/2MXc+ac4/YSA+vxO4Vh2JK 5HnJQlJP9T0o5n79jq5vfQiN48l8Ez1BY3Elp2igPzGAKKELXeMaJnLkn3PEs/vaTE6h nd+qyGEoJsamj2MKuMMQyrIbJAKFxIu1bm494Izbxe4Le/A9McjV/CM27gcBNBnviOzQ 1rf6Bfg/1cx1J2HScxxlwNbywKHZ8xtUCDihSagLmpN7xV+quoYykaBU0b7oL4bo8Aur pPI9Cxk0mpoOEQR7RszHhtT8qhCUrTK2AWiTZPFU9MbCjyN3/ydrzeqKFRvr8S/kLm3D QMkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ozxBKntl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020aa7dad1000000b004a18f2ffb81si34386006eds.321.2023.03.29.09.53.00; Wed, 29 Mar 2023 09:53:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ozxBKntl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbjC2Q2s (ORCPT + 99 others); Wed, 29 Mar 2023 12:28:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbjC2Q2r (ORCPT ); Wed, 29 Mar 2023 12:28:47 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6FA423F; Wed, 29 Mar 2023 09:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=+jXKHUtknIYsW5onYdVNmhni/4ffvAb6VEdjSV93nTE=; b=ozxBKntl/ns+qAe7u20tANVKv9 YIlNEYw9i1spyxcvKMyhffdh1Ie71kiyuTFQlms0H0sUa6nlJXM1NFr3+kYxuLyKpJakw6wo4mcct d0GQEsZv9t5QstfXFsQxvX6f6km9k4dK+s+pp9sF2/Zs9af/2rD0YzkP0Xl9U8T0BXek=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1phYf8-008mVT-W7; Wed, 29 Mar 2023 18:28:38 +0200 Date: Wed, 29 Mar 2023 18:28:38 +0200 From: Andrew Lunn To: Daniel Golle Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sean Wang , Landen Chao , DENG Qingfang , Philipp Zabel , Sam Shih , Lorenzo Bianconi , John Crispin , Felix Fietkau Subject: Re: [RFC PATCH net-next v3 06/15] net: dsa: mt7530: move p5_intf_modes() function to mt7530.c Message-ID: <38703034-8977-495c-aadd-ea93d13395da@lunn.ch> References: <98fc2eec00985854010e3d0d16ba7f4c924ab49f.1680105013.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98fc2eec00985854010e3d0d16ba7f4c924ab49f.1680105013.git.daniel@makrotopia.org> X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2023 at 04:58:35PM +0100, Daniel Golle wrote: > In preparation of splitting mt7530.c into a driver for MDIO-connected > as well as MDIO-accessed built-in switches on one hand and MMIO-accessed > built-in switches move the p5_inft_modes() function from mt7530.h to > mt7530.c. The function is only needed there and will trigger a compiler > warning about a defined but unused function otherwise when including > mt7530.h in the to-be-introduced bus-specific drivers. The other way to avoid the warning is to mark it inline. The compiler will not warn than. But this solution is also good. Reviewed-by: Andrew Lunn Andrew