Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1df6748-d923-6ff5-9012-359cbfd8a718@squashfs.org.uk>
Date:   Wed, 29 Mar 2023 17:41:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 0/2] bio iter improvements
To:     Kent Overstreet <kent.overstreet@linux.dev>,
        Phillip Lougher <phillip.lougher@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        willy@infradead.org, axboe@kernel.dk
References: <20230327174402.1655365-1-kent.overstreet@linux.dev>
 <CAB3woddAP_6uOUJ4Yjj_PATme-CQao3p2JErBBtjtpzYxQejng@mail.gmail.com>
 <ZCMcbnlZchi3kWIL@moria.home.lan>
From:   Phillip Lougher <phillip@squashfs.org.uk>
In-Reply-To: <ZCMcbnlZchi3kWIL@moria.home.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 28/03/2023 17:57, Kent Overstreet wrote:
> On Tue, Mar 28, 2023 at 02:42:28PM +0100, Phillip Lougher wrote:
>> On Mon, Mar 27, 2023 at 7:02 PM Kent Overstreet
>> <kent.overstreet@linux.dev> wrote:
>>>
>>> Small patch series cleaning up/standardizing bio_for_each_segment_all(),
>>> which means we can use the same guts for bio_for_each_folio_all(),
>>> considerably simplifying that code.
>>>
>>> The squashfs maintainer will want to look at and test those changes,
>>> that code was doing some slightly tricky things. The rest was a pretty
>>> mechanical conversion.
>>
>> An eyeball of the changes doesn't bring up anything obviously wrong.
>>
>> I'll apply and do some tests.
>>
>> Phillip
>>
>> BTW please CC me on the cover letter as well as patch [1/2].
> 
> Will do.
> 
> There were some squashfs files that got missed, there's a fixup patch
> you'll want in this branch:
> 
> https://evilpiepirate.org/git/bcachefs.git/log/?h=bio_folio_iter

Patches applied, and I do see some issues in testing.

I'll reply on patch [1/2] because that's where the code is.

Phillip