Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp924942rwl; Wed, 29 Mar 2023 10:08:07 -0700 (PDT) X-Google-Smtp-Source: AKy350bAZqqeTa90TauDTFH5VSBzD3YdblasX+vVjMkcV8T1n4u8ufk6K+WZInn0anLAvQ1Gt8W8 X-Received: by 2002:a17:907:d402:b0:930:ca4d:f2bf with SMTP id vi2-20020a170907d40200b00930ca4df2bfmr23935524ejc.54.1680109687367; Wed, 29 Mar 2023 10:08:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680109687; cv=none; d=google.com; s=arc-20160816; b=QhWhnoUN0ijvsF06OxINiDP3grfrCrbjl8pc6tLBXT7pUOYugfe5MAEOST55JZ4tyT 1GAnzvjxHgtfv6KYBs5gP81Uebwezz/QYpO1i/Rb0Vg8fI64Fcq8wjZpd/5dx355Bwb/ JeXNFwDl3n6k5JipOCAMIQuUduz/3uzpPHvAhGPXCbXZoaWZeILKAxWEHfjf22NQhmow zwPT8GxvscqtbFyc4ZCFE687kv6lZmaAv5kOlWi6sACjyOSlm1ZkPjk56tT6hnSVwCX5 pBwrQ+hhSQUrQ17f9RBALT3isgojXC+ltgW4oYivehy9Bxk/jQmIztjK+VxxemaIGJXF 6c5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=LJyKxfqik5pkLxxaxHBMhGOhe4hjxW+SG9mHfiB6n4w=; b=DhUiW40pOJx4SrQm28pTwBaws0AqcdnS7QUCGFKul5Hr3lNPYRJULgY/Ch0h4j8EXM RMAhBAKavNkHfaX0kODAT+1NmAVv8+rufn2tnhSmYqCLvsswptht9Mt1wBOv6j50wZ7F 1Kj2bDPn1mmEBIIJglfmYHn9YK1RF4lY/Ynenztptmlgey1dGiO8kr94ST3Mf/v7gf3d 4L8acYXUm/5tetfOF/P1bb4IkuVaZ/R5xx72hofbMOSRfA83HcBo2v9czWcxEGkg2xag hFfpz9iEcnhqmVzA3qjir4j3OjQG/n1A3umGU4FNyLnGL76aBRGUxfPrhVZrWoZ+tP/7 aydw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c1+JvlWV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r13-20020aa7d58d000000b005002ec25762si29499041edq.192.2023.03.29.10.07.39; Wed, 29 Mar 2023 10:08:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c1+JvlWV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229448AbjC2RFW (ORCPT + 99 others); Wed, 29 Mar 2023 13:05:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjC2RFU (ORCPT ); Wed, 29 Mar 2023 13:05:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 132221FC6; Wed, 29 Mar 2023 10:05:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A291961D14; Wed, 29 Mar 2023 17:05:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA0E3C433D2; Wed, 29 Mar 2023 17:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680109517; bh=ItVnaZ8FUAX4pSnv5WsIqGPOgOFkxmneK6Rfun+mOtY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=c1+JvlWVoHxfTWRdSlzBTwUTIw3f3QETPbe52cty0rY36OZA8abs67W9qizwgOuWF 5IoLpxrEH5RzrH0UDNkXIvYL0rJJ4nqbwLZvs9c1FE3l7qMRwtdK86SA1QFzXFtSTG TiLe9iNTx8he8OyIWwpiVH0BPml1o7ksCnTZEFwhbqAqexfmj4URDBKcfd1rt50Epl J90k/f6t1FaOqo+dKSXZOo07HREotWF3WjX2NQwkQ9I56eUMT0OPt0An7JdL938eB5 qXP8UeRrkkx7lE2KOWw5Rd332/3xQoJHwsUJhSWQNUPRNPSFwBV1WjL0gd5gRgkDKh LWmaY0kiJgrsA== Date: Wed, 29 Mar 2023 12:05:15 -0500 From: Bjorn Helgaas To: Wu Zongyong Cc: sdonthineni@nvidia.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, wllenyj@linux.alibaba.com, wutu.xq2@linux.alibaba.com, gerry@linux.alibaba.com Subject: Re: [RFC PATCH] PCI: avoid SBR for NVIDIA T4 Message-ID: <20230329170515.GA3067097@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <388bc353a5f88edb502ec04c0dc53ab62a526020.1680090885.git.wuzongyong@linux.alibaba.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2023 at 07:58:45PM +0800, Wu Zongyong wrote: > Secondary bus reset will fail if NVIDIA T4 card is direct attached to a > root port. Blank line between paragraphs. Rewrap to fill 75 columns if it's a single paragraph. Is this only a problem when direct attached to a Root Port? Why would that be? If it's *not* related to being directly under a Root Port, don't mention that at all. > So avoid to do bus reset, pci_parent_bus_reset() works nomarlly. > > Maybe NVIDIA guys can do some detailed explanation abount the SBR > behaviour of GPUs. This is a follow-on to 4c207e7121fa ("PCI: Mark some NVIDIA GPUs to avoid bus reset"), so probably should have a Fixes: tag so it goes whereever that commit goes. Also copy the subject line from 4c207e7121fa, e.g., PCI: Mark NVIDIA T4 GPUs to avoid bus reset Are there any problem reports or bugzilla issues you can include a URL to? > Signed-off-by: Wu Zongyong > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 44cab813bf95..be86b93b9e38 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -3618,7 +3618,7 @@ static void quirk_no_bus_reset(struct pci_dev *dev) > */ > static void quirk_nvidia_no_bus_reset(struct pci_dev *dev) > { > - if ((dev->device & 0xffc0) == 0x2340) > + if ((dev->device & 0xffc0) == 0x2340 || dev->device == 0x1eb8) > quirk_no_bus_reset(dev); > } > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, > -- > 2.34.3 >