Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Hariprasad Kelam <hkelam@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "willemdebruijn.kernel@gmail.com" <willemdebruijn.kernel@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "naveenm@marvel.com" <naveenm@marvel.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "maxtram95@gmail.com" <maxtram95@gmail.com>
Subject: Re: [net-next Patch v5 5/6] octeontx2-pf: Add support for HTB offload
Thread-Topic: [net-next Patch v5 5/6] octeontx2-pf: Add support for HTB
 offload
Thread-Index: AQHZYmJdJ6XjBYfPvUGEMW82DfsoKg==
Date:   Wed, 29 Mar 2023 17:17:40 +0000
Message-ID: <PH0PR18MB44743C4D7AFDE15AA6FE0260DE899@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20230326181245.29149-1-hkelam@marvell.com>
 <20230326181245.29149-6-hkelam@marvell.com> <ZCL8mXFZxpTj1Duz@corigine.com>
In-Reply-To: <ZCL8mXFZxpTj1Duz@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uX25M0MsZ1MIf6j+TA5b8P/oPAsjsIQcTVbZYA6rnuz+21Ych0VJbSB6lKC2?=
 =?us-ascii?Q?Mb3h7B16qaiSO2dj3cRdO/jhJCZXlLchgc2ZHchApKuFIBWZ97nQ2ovbF+0A?=
 =?us-ascii?Q?yedMtBDF2NPuIkCmDalbOfxppbbmNTJ0uOxqJh8TasGjxZ1rH8slK2OTa/3W?=
 =?us-ascii?Q?wECW14GI/5vd9Z2TlYCPi2PWOIJU2kLKTdoQf7izCeozZNq/LnrUt0Ap2EbH?=
 =?us-ascii?Q?uq6pRNVsP7PVUDMx6yEmTJjsv3aq45J7Jx8O42tc1znX2N9ttSQ1dn2uG4zz?=
 =?us-ascii?Q?ELJHRuaKuui7yv61ts0gfZXqCZwhfd/GFkhmHtU51mCHVzSf41t2LFl30dRI?=
 =?us-ascii?Q?KhGB7zPOUW9+kzrmxfoUkE8WrOgSUrcZaYm5NsdKXAZ9oCcMnJ/Cy3nqydGQ?=
 =?us-ascii?Q?Viq9QGpAfe/H6NcQykw/l//AeIfvqcVoMAq2QL4xUP9Rtdvs9T6TV0q6E/3A?=
 =?us-ascii?Q?W/rr15zb2D6AkCrFbpEng5l+7Mw+38ElPW/RfOFgFe39iTt9U6spFWphOPqu?=
 =?us-ascii?Q?ENQrXscRZKmTtO1eS1WxW4rGD+BoNZFa03a8TUTv8yqllLRwloyh7l4/Wlxs?=
 =?us-ascii?Q?ORDvXPyqymNUgy4oZ3zuOO6Jc2AQJfHNPTmBtm+gglasIyxahNNDzPXYw9ou?=
 =?us-ascii?Q?SyAlqvmOyiRInhweofxHIBrIEFi4bJlPaiwLKiQ1+zgaP2UMrN12SfggLt+W?=
 =?us-ascii?Q?x6GUOb+a0fn3O9dFL9hdcgVq+cgqr8u6nriXjgGXWC1a0DsyDQeNBOVQKrNM?=
 =?us-ascii?Q?gH6/lDvRvLJBIAb1JDvCurdw452KfyNSXAXGy7NlmIwBE8SunX9nka3979de?=
 =?us-ascii?Q?5iw7YHZFXrkESw/sFVw4jjHijFh5N+/S6m8GCE17BhnvPplf4Iyk4xj24Yyz?=
 =?us-ascii?Q?C0G+A6DjZ9Hh3zCgLou5Ugqd2m5z6vmdOGEORcuC3IQhHqfbEIO4D4QMbTry?=
 =?us-ascii?Q?h7XMRTUkyewPjSHgpdYdDlfQMYJPSUpc/rsn+S76FN5r4Tytvxo1TfIA3w2r?=
 =?us-ascii?Q?3LSAj+nnWdl+cx+hnh9PFFfoC/AfF+JHmkz6cWgOcDbjH31j6VQ2G0fGN0us?=
 =?us-ascii?Q?YLXrk6wnTmDEQGbpeyfzVPOXR4lw0nGI+MqnWT5AyH5G6EostO8q2VoEEWGC?=
 =?us-ascii?Q?hlvJOamOsAO0U3lvxBGyNyLMMPGqRlfa/C8bNHtKiX757ty7FcxQM4Ai2qSN?=
 =?us-ascii?Q?2BSBvScxItV6FOV/447pvxPhB33liGMgZeDZgYV+nOiKywofhxQwmxiUuQir?=
 =?us-ascii?Q?QmMv1brJgpMKN5ufN9jPDyTRkMOg4sLYlSpIplEAP/d5djD/OB51bpeJ+EiI?=
 =?us-ascii?Q?QPt9NjKqOl/Pee4qtaUqTItpzA1QuIS5hySLgXMOyV1VIGcP+NYrNZQWOVBd?=
 =?us-ascii?Q?qNTsl7ZIRmZrTaJ4oTU7K0ev6cM9mQOH9jq2FSoaeLFTjR5tfOvQNVSZ9kdP?=
 =?us-ascii?Q?Sf/KO2KkudfGdLIHGLhnTbBRaIirlSDXMQhn6saybJQcM++RcscEI/f8+Yqg?=
 =?us-ascii?Q?CDyyyVL1yuge8YfzCvXaHAi0HyYpeUpTI65LPR/aBzIgaJDw4+1exYV8SXG4?=
 =?us-ascii?Q?T6XQyTslDRXv449xJ8k=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 113093cc-a92f-4325-8c78-08db3079805e
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2023 17:17:40.5858
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nPCp7uWja9F5ndBiSODvyByliwLfP9YeFQ2So3oMMWS+6BAw8hoTI1fvidriVZlu8k89um4+HsoWsWIkDJX9fQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4796
X-Proofpoint-ORIG-GUID: dMRQu_jnaXauiWhA_C56yBqOX4DK4X5j
X-Proofpoint-GUID: dMRQu_jnaXauiWhA_C56yBqOX4DK4X5j
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-29_10,2023-03-28_02,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for the review, will address issues in next version.

Thanks,
Hariprasad k

> On Sun, Mar 26, 2023 at 11:42:44PM +0530, Hariprasad Kelam wrote:
> > From: Naveen Mamindlapalli <naveenm@marvell.com>
> >
> > This patch registers callbacks to support HTB offload.
> >
> > Below are features supported,
> >
> > - supports traffic shaping on the given class by honoring rate and
> > ceil configuration.
> >
> > - supports traffic scheduling,  which prioritizes different types of
> > traffic based on strict priority values.
> >
> > - supports the creation of leaf to inner classes such that parent node
> > rate limits apply to all child nodes.
> >
> > Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
>=20
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>=20
> > ---
> >  .../ethernet/marvell/octeontx2/af/common.h    |    2 +-
> >  .../ethernet/marvell/octeontx2/nic/Makefile   |    2 +-
> >  .../marvell/octeontx2/nic/otx2_common.c       |   35 +-
> >  .../marvell/octeontx2/nic/otx2_common.h       |    8 +-
> >  .../marvell/octeontx2/nic/otx2_ethtool.c      |   31 +-
> >  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |   56 +-
> >  .../ethernet/marvell/octeontx2/nic/otx2_reg.h |   13 +
> >  .../ethernet/marvell/octeontx2/nic/otx2_tc.c  |    7 +-
> >  .../net/ethernet/marvell/octeontx2/nic/qos.c  | 1460
> +++++++++++++++++
> >  .../net/ethernet/marvell/octeontx2/nic/qos.h  |   58 +-
> >  .../ethernet/marvell/octeontx2/nic/qos_sq.c   |   20 +-
> >  11 files changed, 1657 insertions(+), 35 deletions(-)
>=20
> nit: this is a rather long patch.
>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
>=20
> ...
>=20
> > @@ -159,7 +165,7 @@ static void otx2_get_qset_stats(struct otx2_nic
> *pfvf,
> >  				[otx2_queue_stats[stat].index];
> >  	}
> >
> > -	for (qidx =3D 0; qidx < pfvf->hw.tx_queues; qidx++) {
> > +	for (qidx =3D 0; qidx <  otx2_get_total_tx_queues(pfvf); qidx++) {
>=20
> nit: extra whitespace after '<'
>=20
> >  		if (!otx2_update_sq_stats(pfvf, qidx)) {
> >  			for (stat =3D 0; stat < otx2_n_queue_stats; stat++)
> >  				*((*data)++) =3D 0;
>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/qos.c
>=20
> ...
>=20
> > +static int otx2_qos_update_tx_netdev_queues(struct otx2_nic *pfvf) {
> > +	int tx_queues, qos_txqs, err;
> > +	struct otx2_hw *hw =3D &pfvf->hw;
>=20
> nit: reverse xmas tree - longest line to shortest -
>      for local variable declarations.
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> > b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
>=20
> ...
>=20
> > +struct otx2_qos_node {
> > +	struct list_head list; /* list managment */
>=20
> nit: s/managment/management/
>=20
> > +	struct list_head child_list;
> > +	struct list_head child_schq_list;
> > +	struct hlist_node hlist;
> > +	DECLARE_BITMAP(prio_bmap, OTX2_QOS_MAX_PRIO + 1);
> > +	struct otx2_qos_node *parent;	/* parent qos node */
> > +	u64 rate; /* htb params */
> > +	u64 ceil;
> > +	u32 classid;
> > +	u32 prio;
> > +	u16 schq; /* hw txschq */
> > +	u16 qid;
> > +	u16 prio_anchor;
> > +	u8 level;
> > +};
> > +
> >
> >  #endif
>=20
> ...