Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Hariprasad Kelam <hkelam@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "willemdebruijn.kernel@gmail.com" <willemdebruijn.kernel@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "naveenm@marvel.com" <naveenm@marvel.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "maxtram95@gmail.com" <maxtram95@gmail.com>
Subject: Re: [net-next Patch v5 3/6] octeontx2-pf: qos send queues management
Thread-Topic: [net-next Patch v5 3/6] octeontx2-pf: qos send queues management
Thread-Index: AQHZYmKkh30hN16dn0isZP1bs+NTRg==
Date:   Wed, 29 Mar 2023 17:19:38 +0000
Message-ID: <PH0PR18MB4474D7DA8B343FB842A9E649DE899@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20230326181245.29149-1-hkelam@marvell.com>
 <20230326181245.29149-4-hkelam@marvell.com> <ZCL9CbpBuH0M3OJU@corigine.com>
In-Reply-To: <ZCL9CbpBuH0M3OJU@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m30cBokGkl3HZamxj/ea0ibu5nKosI/JRJDxHGwFDsoXwoYkmozIsqMb5fLL?=
 =?us-ascii?Q?BKpOZktakNZyuNBpAzEkvcG32Dvl0KbC5R8Lto8VgODB6D3m36r9uD0DIkVB?=
 =?us-ascii?Q?qM5GV/SjlCQqMPc0dehoJ48PVPOrAOegjR5bBXkl1jg3q1foDja3TZ5PuLpn?=
 =?us-ascii?Q?q0jwxSbqH+vcpguPZX9LYaXCOccxfzj3HTovWkbHT/2O+iw13gbrblcJa9V2?=
 =?us-ascii?Q?OrI/nt0RxAw+NoJ07rdyk6zxdBSq7dwJKqO2UcDxAVQeTPsIbAt5iir48A/P?=
 =?us-ascii?Q?UT05uwv0PUhEAr+p+3GboedeXfvOLI8vpFWi/acKOuVmJDNoJ4KJJRv8IcIc?=
 =?us-ascii?Q?dJugzi/JPiCio8EQ7Rtgb0Kt/SpajEvJ3mgm7CXNXRybAUVB75OYCmM23nHY?=
 =?us-ascii?Q?/8dHNMDhx+Q9V637citTa6D8+pptQ/Kc/Nzd4i6arWgrvIdqnhKFWR8J43FY?=
 =?us-ascii?Q?AivIguNGocrwHQa6tdBLIJYFq4Vo0oDsrqUQtv+I+NZUevegNTkIa9PDx4hk?=
 =?us-ascii?Q?2ebA2uixCFuWc9JzH0zToON3jPj4qkmgfHq25ecAJTmGjl8llMcP4uVogF9k?=
 =?us-ascii?Q?cFvc8Vbu6EAobJpIvPs+kcLV7uTc1cAVG6zhBFwWdLp3DiuTj7HCOuy0oOX6?=
 =?us-ascii?Q?brDmcseYv3yLURXjhTbXsvxXYydDBAnVJQ4tReXxBXIGz72FWyAspgX79PHl?=
 =?us-ascii?Q?2YcKaVRPMemtp6hGUbt2zs+CBiJoPbKgzA1zkLmDUc57o6jcsApnmF490V5p?=
 =?us-ascii?Q?hg/5TEUBWSPrInT4eArbSjGgqSdNn++OLtItlncgXEAfJid259idKLgzB46B?=
 =?us-ascii?Q?1QKgma7cN/rvkiQmilxOSvDzTUgPiVckAdp1rB3A7GUCfdDz1seq35c9UXFq?=
 =?us-ascii?Q?8xYmVw9xY/PNjHtYdjcJF9HKyBZ5mpD653ri87IrK/GKoTxWYnnMA/XUpLka?=
 =?us-ascii?Q?WnGIf3AYUnM9rzeK/iotHPhy0s1G2IT+Qju1dVef5femZ5msXlfcaEy3/Iax?=
 =?us-ascii?Q?+BxSwlx6t1si8u1eCZ/bDUbX1ACIQpZ2CTrGMEUZAgSd8pbcERcyf6Ic9iHh?=
 =?us-ascii?Q?g9CdIUciCet0UFPM9HtmHwHGu5UxZdF1Gt7k31nF8IABWK5+n3vBpxsQRlw/?=
 =?us-ascii?Q?R9h/HOc3w6dP8lCTQ+aZZC53VWSIElrTCTwatRBMBCBnI2nqPl5xEXxufZ0l?=
 =?us-ascii?Q?B8Hh6I00GmbToVm+EfkAkGp3pAyj+eJtyfAUpl3V1aKhQDCEd30YqXkv7MYj?=
 =?us-ascii?Q?ySw5+6qcZyLNKU+AMpv4hRUScqupC08WwNpeTxjmv94WIZ4LeKgg98sm8CBb?=
 =?us-ascii?Q?4tL1lqamzwNEryN/2wHdTXcehzl2B+6siypowUkDfq+EtTsC+tVEYdXL254b?=
 =?us-ascii?Q?378eOwC3x5GOMsvBu3MlBPeOWz8On8KnufXDdLPi0Tp0SjlkKino2lOwggaQ?=
 =?us-ascii?Q?ymSxO/9szex5ZxlwT2DWLcvihQHAMJQ4d4peSW7qZDsIN49B9CNotd9Jc9gf?=
 =?us-ascii?Q?c3ySQXgFwn4yEcWLJpqX5ve8eXMhCwCOT9tHOIQzkJ5c1ssf7h6kwo2UImgA?=
 =?us-ascii?Q?bjbdGlEx7bIBEGXTrvg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bffcd033-4473-4894-b79e-08db3079c696
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2023 17:19:38.3598
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rceKUP5UjtmV8j7t1R0+83PBcpHTiWL0dowW/krN9STBpQL8MLcccF17I0LfF5WJf2aMTpS7Hp9egeXyzaxs7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR18MB5291
X-Proofpoint-ORIG-GUID: 5upjUeSQJVUid6omyJVHX0azXMYLRNF4
X-Proofpoint-GUID: 5upjUeSQJVUid6omyJVHX0azXMYLRNF4
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-29_10,2023-03-28_02,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sun, Mar 26, 2023 at 11:42:42PM +0530, Hariprasad Kelam wrote:
> > From: Subbaraya Sundeep <sbhatta@marvell.com>
> >
> > Current implementation is such that the number of Send queues (SQs)
> > are decided on the device probe which is equal to the number of online
> > cpus. These SQs are allocated and deallocated in interface open and c
> > lose calls respectively.
> >
> > This patch defines new APIs for initializing and deinitializing Send
> > queues dynamically and allocates more number of transmit queues for
> > QOS feature.
> >
> > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
>=20
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>=20
> ...
>=20
> > @@ -1938,6 +1952,12 @@ static netdev_tx_t otx2_xmit(struct sk_buff
> *skb, struct net_device *netdev)
> >  	int qidx =3D skb_get_queue_mapping(skb);
> >  	struct otx2_snd_queue *sq;
> >  	struct netdev_queue *txq;
> > +	int sq_idx;
> > +
> > +	/* XDP SQs are not mapped with TXQs
> > +	 * advance qid to derive correct sq maped with QOS
>=20
> nit: s/maped/mapped/
>=20
ACK , will add the change in next version.

Thanks,
Hariprasad k
> ...