Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ajay Kaher <akaher@vmware.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     "mhiramat@kernel.org" <mhiramat@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-trace-kernel@vger.kernel.org" 
        <linux-trace-kernel@vger.kernel.org>,
        "chinglinyu@google.com" <chinglinyu@google.com>,
        Nadav Amit <namit@vmware.com>,
        Srivatsa Bhat <srivatsab@vmware.com>,
        "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
        Alexey Makhalov <amakhalov@vmware.com>,
        Vasavi Sirnapalli <vsirnapalli@vmware.com>,
        Tapas Kundu <tkundu@vmware.com>,
        "er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>
Subject: Re: [PATCH 0/8] tracing: introducing eventfs
Thread-Topic: [PATCH 0/8] tracing: introducing eventfs
Thread-Index: AQHZLoQH5dE+ZQnOVUm4TxmRzoe30q8RMZWAgAFCCQA=
Date:   Wed, 29 Mar 2023 18:00:22 +0000
Message-ID: <68D75872-2495-48E6-970F-6A414EEBE3BC@vmware.com>
References: <1674407228-49109-1-git-send-email-akaher@vmware.com>
 <1674407228-49109-9-git-send-email-akaher@vmware.com>
 <20230328184743.7984463b@gandalf.local.home>
In-Reply-To: <20230328184743.7984463b@gandalf.local.home>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DzVBR2/9Ue4v7X5+5/1wy5SVw9DgDs+iExJja7YCAHw8Feo5xvlePDidEG+j?=
 =?us-ascii?Q?eA2c8JlqXx9BT/j+GanETn53/JGgaLF5pbrOF2kAJ5h3SFqkzILDH6fOuMeT?=
 =?us-ascii?Q?Dd8Ob8QlMMKr3bdemfvp1857K40mS84G0l8qTStSATOXK6xjDdqosC/EtSX7?=
 =?us-ascii?Q?T3NTJygFQPqCbiDwiHimIFYZ9mdZfUyvZYBYu4H2tDiZU8tcqlJz/AWRKlUs?=
 =?us-ascii?Q?FIbzZyUpgIRH8K5ZtnduCX5JRoHYpv4FjaSwxI50Ywlxy8cQczWFT1I7MVo0?=
 =?us-ascii?Q?uCuO5LoPP5cUcyYmmKVxL6apswuNo0UJ5vErqkrRhHCyP0TByhEHufA+zkcy?=
 =?us-ascii?Q?S9oy+Ioibusq/SZ8djj901VcAZBc4H8RdcU9sQ74la91XfVGY9aH36uHGm+S?=
 =?us-ascii?Q?tJOMcfG7tTgGf2eLMDQq1miv9rq/PkPIrpzMyT0waqfOclE0q4lGOl4f5H2u?=
 =?us-ascii?Q?F94erfweZ5OUGyMn1hFHWiBU614eopGeBWPfQfdSrejjiW28xeKk7b9ChvbA?=
 =?us-ascii?Q?XWctYhUvShFkAWdo2rpLfpIgSBp1LawcA4uc7bgg0188/8T9rjdFIXKiYKHG?=
 =?us-ascii?Q?dUZLII6mkNAmznxuvOmXSMIbzYVpn16bZhJZFpy7nu3W/u69+6t8hds/RTFS?=
 =?us-ascii?Q?VX7EowzHAoCLDvKfs8fFiJ8elxwNoB7uvF8XgF4B58eJPCCIgaLm8JvdKl9r?=
 =?us-ascii?Q?9ZxVM9iiTsSNwZl1+mWkoUwKBrW2HukBUWwnvB6uX5hY0s3qboveSuMnM9aJ?=
 =?us-ascii?Q?ZcuUjWMD4c1nwIM3//HDjcnEuNLBd3DUqs3+7ZLeJyIL8dMWKEvbhWcUZEj/?=
 =?us-ascii?Q?0FXHijtZsLS3VVsAZfAbbsXEqKVnjYfrv2kTXyY2FKbWcW64KAJb59jbTxmd?=
 =?us-ascii?Q?utBhq5X7kMO8rQkOUklCKKeA/9gIW6Z/jkrFJx74rLq9Vg+hgr2xSKzqbeA7?=
 =?us-ascii?Q?pVr0UaHqvSgGD3+fCysGlNK7fyFPi5UjueM3VQ3SrJfC9byjyZY4+54T9rVQ?=
 =?us-ascii?Q?2j0hs6BcWxFXKZvrdmZln8wPvLXPE9ID/RfYVslSg8CVG2vNpiqmPrAWbJug?=
 =?us-ascii?Q?W7zZgYXjS+sU/0mHa3BiRnxeGlsrb6iEYTMWR2CoQ9KIoPDFEaILjBZOdwde?=
 =?us-ascii?Q?uWffc8DSDpPgIMFiWfVQwVBDcc6PEmRNd/oHT81NczPdBpDv/h7U7VPJ2RtX?=
 =?us-ascii?Q?/s5XG+bP/lFCw9MJAuPe9G6NM2/ML2BC9sf7uyHGtnNAWzv0oaBsBXPYWiTQ?=
 =?us-ascii?Q?ZJHGSyqIIpSFYEwcnqitJKZmjDZIKUaO29rePeNNum9aoPUcakOdNJgKgjqY?=
 =?us-ascii?Q?lj/PVN8BMxn1mG7Q9FQDkwot3bvtBeYNxr9Vpf2MntI/DRAC2+yaCfJDYdIo?=
 =?us-ascii?Q?vs1BSXHviQd2uqoGFmCKQaa8GUXmrXD1Lnsl+htsiKWITL7xKLX0vFJtEja2?=
 =?us-ascii?Q?05KZYp7GaAlgJmKr+vTHRZetkHAhffN1L6BRwafSfrOup5WTiY35mRceJHP7?=
 =?us-ascii?Q?bqQS+Ve5+5H01cz22MiMwKsj61MEE9KE7FHlIOvYdQi3/Dg7YeO8SeplBZa9?=
 =?us-ascii?Q?BJC8th/0wUYX0dLhs41ePHk+YmjPzElSh1W/X1La?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0B141CB4B0B7D4429494213E1B59C60C@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df1c08aa-6ae3-411e-430d-08db307f77ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2023 18:00:22.9781
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L+qVKxhvrStJOJxm+ny5kWe7kty/L5dk9ZpT7GSTHuiOwnYEHsAliYqrvyJ5ikKV53d2MS6ldEfgcl7R3tjuRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR05MB6705
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On 29-Mar-2023, at 4:17 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>=20
> !! External Email
>=20
> On Sun, 22 Jan 2023 22:37:08 +0530
> Ajay Kaher <akaher@vmware.com> wrote:
>=20
>> Events Tracing infrastructure contains lot of files, directories
>> (internally in terms of inodes, dentries). And ends up by consuming
>> memory in MBs. We can have multiple events of Events Tracing, which
>> further requires more memory.
>>=20
>> Instead of creating inodes/dentries, eventfs could keep meta-data and
>> skip the creation of inodes/dentries. As and when require, eventfs will
>> create the inodes/dentries only for required files/directories.
>> Also eventfs would delete the inodes/dentries once no more requires
>> but preserve the meta data.
>>=20
>=20
> Hi Ajay,
>=20
> Is there going to be any more work on this?
>=20
> -- Steve

Yes, Steve.

While running tools/testing/selftests/ftrace/ftracetests got crashes, as yo=
u also mentioned.
These crashes are because of lack of synchronisation and bugs in eventfs cl=
ean up path.

Locally I have fixed all these crashes with the help of Alexey.
I need one internal review round, once done I will post v2.

-Ajay


>=20
>> Tracing events took ~9MB, with this approach it took ~4.5MB
>> for ~10K files/dir.
>>=20
>> [PATCH 1/8]: Introducing struct tracefs_inode
>> [PATCH 2/8]: Adding eventfs-dir-add functions
>> [PATCH 3/8]: Adding eventfs-file-add function
>> [PATCH 4/8]: Adding eventfs-file-directory-remove function
>> [PATCH 5/8]: Adding functions to create-eventfs-files
>> [PATCH 6/8]: Adding eventfs lookup, read, open functions
>> [PATCH 7/8]: Creating tracefs_inode_cache
>> [PATCH 8/8]: Moving tracing events to eventfs
>=20
>=20
> !! External Email: This email originated from outside of the organization=
. Do not click links or open attachments unless you recognize the sender.