Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e74c4c93f4bcc6a7af0c3ef5a8edd23.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <d1874eb8848d5f97f87337011188640a1463a666.1676649335.git.christophe.jaillet@wanadoo.fr>
References: <d1874eb8848d5f97f87337011188640a1463a666.1676649335.git.christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] clk: Reorder fields in 'struct clk_fractional_divider'
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-clk@vger.kernel.org
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Michael Turquette <mturquette@baylibre.com>
Date:   Wed, 29 Mar 2023 11:46:36 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Christophe JAILLET (2023-02-17 07:55:55)
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index cf1adfeaf257..8cec844f5dde 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -1134,13 +1134,13 @@ struct clk_hw *clk_hw_register_fixed_factor_paren=
t_hw(struct device *dev,
>  struct clk_fractional_divider {
>         struct clk_hw   hw;
>         void __iomem    *reg;
> +       u8              flags;
>         u8              mshift;
>         u8              mwidth;
>         u32             mmask;

This member ...

>         u8              nshift;
>         u8              nwidth;
>         u32             nmask;

and this member can be calculated. Doing that would save more bytes when
combined with this patch. Can you make this into a patch series?

> -       u8              flags;
>         void            (*approximation)(struct clk_hw *hw,
>                                 unsigned long rate, unsigned long *parent=
_rate,
>                                 unsigned long *m, unsigned long *n);