Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1054472rwl; Wed, 29 Mar 2023 11:59:42 -0700 (PDT) X-Google-Smtp-Source: AKy350YQNAgpJQthwkocYqMIifU23RcoOqHOwKz23To1vY63i1HVwlYUhYZkrIF4F9lP2Zmi5Yne X-Received: by 2002:a17:907:7ba1:b0:8b1:820a:7b60 with SMTP id ne33-20020a1709077ba100b008b1820a7b60mr26453388ejc.6.1680116382667; Wed, 29 Mar 2023 11:59:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680116382; cv=none; d=google.com; s=arc-20160816; b=mreZoXKB6JX6Q1fJpBk9cRzbdKDa46hoC8XzsTCTrCbqaxnW9xwMO8B54G6yzK4vMF e+P8Vr8ptaZTnHrTn1Xz7nJf1SSjxfSu4ShIy9aJBCKVgNoYHs6lbFilo9IgCYe7zwXn Vlm+JJnpgz2rbScRRlf6zkD7Df+LGcutVkRn/JbQ/T5L2/Bpbp1wSGjf/+p3mmJoQyMg 5gMnBPG5lHNfSYHimUMl2NUElfBc8dS5IEpRCFTUNOiBJbR4HpJxH3WAMjsWJIFbJSwC x68fA9dKuoYhZvrnhJ62FBVgAxw9/ntp1h9OlhJzQHxW9+zu0JyMaIjPKihuCYfShj9X O65g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=GrKgNBdgVGDd5tuVm5wP/QWfKRU7XwBSou05qKklH3k=; b=R52HY8QedX43o9xz8Ww4wrbW6PeA+mInLzbgGJSqvkPBgTjDisaMrG5fPYUDdcvl3q VXKzp48u8Uek6l+XjWz0RdvIIGEmLNW3PbSDw4I1owAGnOY4GYFlSqn/UGzsoOiNmI3x 8YwLULyjxQvrjGr5Kvz14OfAflLKBjs1pDnzEtxWjEfQxLiAoyXKmJQiUYXnHtd7RI/e WBvUHP9EpvsECn+Xl2LQTaIbjybIN/mnokqAzQb7TCoDjmIO+v9wChJWFTjPuN8tCaYB ExXt7k+JTFkWoQN0bO65CGMWzUhrcRd6iLUupOmP7wamNYpJLgeZHoJUQ/s70jc1TGMk relg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q8B3J857; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm14-20020a170907948e00b00944010e04fasi13214002ejc.712.2023.03.29.11.59.18; Wed, 29 Mar 2023 11:59:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q8B3J857; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjC2Ssz (ORCPT + 99 others); Wed, 29 Mar 2023 14:48:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjC2Ssx (ORCPT ); Wed, 29 Mar 2023 14:48:53 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E7BB4C3A for ; Wed, 29 Mar 2023 11:48:51 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id w9so67259666edc.3 for ; Wed, 29 Mar 2023 11:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680115730; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=GrKgNBdgVGDd5tuVm5wP/QWfKRU7XwBSou05qKklH3k=; b=Q8B3J857qhjR2TSPbJ1IJc6AAGDDCJRITn7O9RBll+yoLHHqTAfQeLs1CutVvnaRk+ w3pcaW+fhER4vIQa7gwgHeHXo1+ijAKhfYhPMpXsTMT1mNCFRYPcJjdt4vlPoJGl9JAn sgDwzuDzJBIzHxwb3lEiW4tTyYBBJKDFFg6G+l/F27R+DmfM9r98Zkh28N7o40XxNpY+ bvBMoGsRKqixep5wRcgokXu402Q0l/sPF3Up7deagSnLguMdWcEtq+5GOy5eb4G0/Ye2 fHSuulIFU5ix8lkw4hCK/sycBVePrhVHTSU4Fb1x1SoX1tt9qSHS2uD9iWCRscv511Hs dTHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680115730; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GrKgNBdgVGDd5tuVm5wP/QWfKRU7XwBSou05qKklH3k=; b=LN/bn3gWxjS7PnOjtsR+HbjoMBPhCydBE++9TPA9dR3gzMF7OABJRPacyz/ngf0xfx hwxKMQ98z4fNBHFcxLvSSHND3cTBn3BG7kA1eAyDY64z54Z7DPMQOPp3tyvge2RGCPje EUBoFEEOjLP1I4cXFwK0VCrTDv75UcWZhP2ZwTEge3HtxZJVT0Bb1IBmiYAIcESMh35L iODfncQhn/eYImsF1dldbd6OdrV9OPMpzI4rd667rksn/dhX9t8mT7Pg20HhKTYeHMQQ QYciK+Hq91EfX3OjdCFVsoMNNh8T1T95FMpAZ5nUaVenbtWmmqSnV8h10HTODyUzkdSH jcIg== X-Gm-Message-State: AAQBX9ebIzYCP0kVdljHT9yhjk/74Onprk7zShduHYxoqq7dyL1Eskmh +j3R6oIP+CVBDn+x+Sz3FX8= X-Received: by 2002:a05:6402:2811:b0:502:92d:4f51 with SMTP id h17-20020a056402281100b00502092d4f51mr24946261ede.1.1680115729529; Wed, 29 Mar 2023 11:48:49 -0700 (PDT) Received: from [192.168.0.103] (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id r17-20020a50aad1000000b005024459f431sm4008559edc.70.2023.03.29.11.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 11:48:48 -0700 (PDT) Message-ID: Date: Wed, 29 Mar 2023 20:48:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 0/5] staging: r8188eu: code cleanup and coding-style fix patches To: Abhirup Deb , Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev References: Content-Language: en-US From: Philipp Hortmann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/23 19:01, Abhirup Deb wrote: > This series of patches fixes the coding-style issues > reported by checkpatch.pl for the staging/r8188eu driver. > > Abhirup Deb (5): > staging: r8188eu: add blank line after declaration > staging: r8188eu: refactor block-comments > staging: r8188eu: remove redundant else after return > staging: r8188eu: Replace "<<" with BIT macro > staging: r8188eu: place constants on right side of comparison > > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 61 +++++++------- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 2 +- > drivers/staging/r8188eu/hal/rtl8188e_dm.c | 2 +- > .../staging/r8188eu/hal/rtl8188e_hal_init.c | 10 +-- > drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 2 +- > drivers/staging/r8188eu/hal/usb_halinit.c | 23 ++++-- > drivers/staging/r8188eu/include/ieee80211.h | 82 +++++++++---------- > drivers/staging/r8188eu/include/rtw_mlme.h | 4 +- > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 6 +- > 9 files changed, 98 insertions(+), 94 deletions(-) > Hi, sorry this driver was deleted: Please read: https://lore.kernel.org/linux-staging/92a9442a-cece-4179-fbdc-3c9188da073e@redhat.com/ Please also check on which tree you are working on. This seems to be the wrong one. If you need support I will help you. Thanks for your support. Bye Philipp