Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <57f41574-7886-3bfc-c992-74d40664f5ba@amd.com>
Date:   Wed, 29 Mar 2023 15:00:55 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 2/2] drm/amd/display: Mark function
 'optc3_wait_drr_doublebuffer_pending_clear' as static
Content-Language: en-US
To:     Caio Novais <caionovais@usp.br>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Wesley Chalmers <Wesley.Chalmers@amd.com>,
        "Lee, Alvin" <Alvin.Lee2@amd.com>, Jun Lei <Jun.Lei@amd.com>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>,
        Gabe Teeger <gabe.teeger@amd.com>, Roman Li <roman.li@amd.com>,
        =?UTF-8?Q?Ma=c3=adra_Canal?= <mairacanal@riseup.net>,
        Deepak R Varma <drv@mailo.com>
References: <20230329180534.99151-1-caionovais@usp.br>
 <20230329180534.99151-3-caionovais@usp.br>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230329180534.99151-3-caionovais@usp.br>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2U2azlscDFPNEFScHhEL01QaERHelljR3g1Vi92bnNaaitrNk42aWI5U21L?=
 =?utf-8?B?eEdpaUxoc3duV3M4TnNPRFNuZVcwdXlPbnVydkV1NmRKVlRUVzhoMHVjb2FI?=
 =?utf-8?B?TnVsY09TT3NKLzk4NUEwOFA5end3SGxZYkVqOU5TQUM4QW14UThySDBLY3Ix?=
 =?utf-8?B?VlNqdEMxNFExa093VlQ5dkNUNW0yenFKeDI3eDJQZHpmMW11UFBIMGhSa3do?=
 =?utf-8?B?ZjdJZFUzNmh6ZDZJYW5GWS92SmVzNVJoRFFyNVBTZ3lROVc1aHJTM0hCZFI3?=
 =?utf-8?B?cDlZUElBZkhCcEVxdTYvSmEweURXQk4zN2h3RkM3SkQwRmJPU0tzNXBrdEhL?=
 =?utf-8?B?NW41MThvYldtdmFJSXUzRXVjeStCeVlBbmdLdlFKM0tNZHZMUUxjYStMdHFl?=
 =?utf-8?B?eUpTT01Ga3BaL0tLS1FEYjJYa3c0Mzg3dUV6Y3Vmdk4vSysrbkNyVXdJU1ZN?=
 =?utf-8?B?L1c0d3VvQkFGYmdPMjhUWmFqSDNmejdXMmlmM2haRlZ0L2I1czF0eTNxYXFi?=
 =?utf-8?B?WWFvV3pmclFhUm1YZUJaL0dxSzJnZFFzcml2UkxMZXB2V0RaM0VrZFMxdk4y?=
 =?utf-8?B?eFNoRXB3WHVrUElaaXVXT1RycVlHTjA4eTZidFJTTVBtL2luRXdzK0JiUVVa?=
 =?utf-8?B?bXNpOTZ4YmJBU3hjT09ZQ3FUTW1YaWhrMXJLQmpVWFF5anJORTlKa1lQVEJp?=
 =?utf-8?B?d1dvWHJvUXBRZWxhTjhPOTBEbHFjUXZRN3RwUXd5VXg1bk1NbmJQdDZISHhs?=
 =?utf-8?B?YjAxbk5Wa1hvWDg4Vnc4WmhVckNrMFZYODNYZkxJbXJrNkszTm5FKzdrUFlr?=
 =?utf-8?B?cklnZ1Y2U1o4VlYwaHNtcWVpVFhtWmg4UnhNMUtBTHJvU0dMT0t3VE9jMG9i?=
 =?utf-8?B?UUd2bTdtTTJzZEI4K0t0bVY5WDFGWDJjUkUrV2lrbFhIbm9sL0hxSWNUV240?=
 =?utf-8?B?SFJLNUZRWCtTdEYzWjFIbWZPNXZmM2JTU3ZqRDQ0S3kzZWRTSXVMTGNxdkVN?=
 =?utf-8?B?eGNWdm5pUFM2N3BKMVlhNjQrNy9ReWdVVkZDUy9mbXF1enVGVW5tTkh6SGJj?=
 =?utf-8?B?UkE0UWJqRzZNV0tQa3RKQnpIQ200d3doWWpqVXhBWmQ1bk9ubDkwcTg5c1ZZ?=
 =?utf-8?B?K3U5ZTg4R2ZHekhNc2VJWDB0UzkyVFJBb1lxTjBSaUFVeXZXTXA4eHpqbFFM?=
 =?utf-8?B?dGczRFZKRm02bXVhMlVUL014Tm5VdWhEcytTWklET0k5aUNRTmJvcWNQU1hV?=
 =?utf-8?B?eFhueUZSRFVKd1REb3dGRWE3OE1LRldhT1kzK2JETU56a3dTVFQ0dEYzY0ZF?=
 =?utf-8?B?S0w0Q2xrWlBmR3BwSW1ZbVk3SDFnT3NyT1hGeVVTak94clZxTVpISDh1anJk?=
 =?utf-8?B?Q1BTUDZMWmhVUksvbFRSbEs5Qk1DOGQ4dWtVTlpCelRzbmtKb3N4dEY1aGYz?=
 =?utf-8?B?cnI1a2xvZ2k0RDZub0p6c0M3ejNId29UWTVLcEh3N1pYWFhsNFBxeVIzM2dH?=
 =?utf-8?B?MXYvZGllTlFMZ0xsdmh0RGxLS2x0ZTdhV0FEWi96Y1NPbXhDVlZvekordzhO?=
 =?utf-8?B?WFNkZ1BaRHFDZ2lWRzhibnhMV2taalVhZUxNM1FlNHhlUVpPNmZmV21CWXpk?=
 =?utf-8?B?QzRyODN3WERhWXZJUzVPSjFpYmtmU0dKaUJLaHBpNjh4a1RVYWZKNFZzemhV?=
 =?utf-8?B?Y1ZyRS9sRmtPbE1JazFLZG13UlpXZGxjcGhDUEc3VGF4T1BPeGVMS2djeG5C?=
 =?utf-8?B?emNnbUdqQ01vZkNWNys1YjRUTmxxdGdNYy9GTzkxRkFyYUpBRks1WDh0b3RH?=
 =?utf-8?B?bTNqNmQ1eE80azlXbmR6L213bUFPYVozRldVMVBITWZiKzM4eTd1OG5lWTBU?=
 =?utf-8?B?elN3ZU5QTk9WRHVQektSSnlMMnRpa0tuK3VOb1craWVNNzJiT1Q3MGZwWThN?=
 =?utf-8?B?aDYxS2xPYlI4bTdzQjMzTk5HOXVEYmRtU1ZjQ0xNVUxWRVpscGdJVEphZkph?=
 =?utf-8?B?QTZrTzhZWGoyUlFwbmQrVjh2SnlGNkZaNHdjb0h5SUNDQzdQeG1PZy91Wk5H?=
 =?utf-8?B?U1RJeXFjU2RYVU1BMHBIREdqOXMzNUJNd0tDUGJZcHpBbmkydlJYYzg3eVM4?=
 =?utf-8?Q?3SyId3BH8nbtPSKdtFKY62lpI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 475213e1-ca52-4fe3-a0ad-08db3087bdff
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 18:59:37.1914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yf/RpWpRFNl0rcF+Mhe+ipw8Pk2mGegHzqX4/KBXNot9DfaevJCeN8fbxGF/rQOmQJxWo4yQFdque4w/pJ3l5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5476
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/29/23 14:05, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]
> 
> Get rid of it by marking the function as static
> 
> Signed-off-by: Caio Novais <caionovais@usp.br>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> index 08b92715e2e6..c95f000b63b2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> @@ -291,7 +291,7 @@ static void optc3_set_timing_double_buffer(struct timing_generator *optc, bool e
>   		   OTG_DRR_TIMING_DBUF_UPDATE_MODE, mode);
>   }
>   
> -void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
> +static void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
>   {
>   	struct optc *optc1 = DCN10TG_FROM_TG(optc);
>   
-- 
Hamza