Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e4a6e5bb-d014-aa55-5eee-65f1c5f59875@amd.com>
Date:   Wed, 29 Mar 2023 14:17:06 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: Panic starting 6.2.x and later 6.1.x kernels
Content-Language: en-US
To:     David R <david@unsolicited.net>, Borislav Petkov <bp@alien8.de>,
        Gabriel David <ultracoolguy@disroot.org>,
        eric.devolder@oracle.com
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kishon Vijay Abraham I <kvijayab@amd.com>
References: <943d2445-84df-d939-f578-5d8240d342cc@unsolicited.net>
 <20230327074952.GAZCFKoDOiJUdtse2H@fat_crate.local>
 <e8d15248-e694-79d7-da9c-b4485b471e14@unsolicited.net>
 <4c660f0f-2845-0e02-ccf9-619958e24236@unsolicited.net>
 <20230328142014.GCZCL3nkW5Qx5jhfsB@fat_crate.local>
 <57385475-c289-356f-d696-fc6decce1390@unsolicited.net>
 <20230328171057.GDZCMfobguhGUFiUuh@fat_crate.local>
 <9ed16be4-051d-c20f-0410-b8a973c4c09e@disroot.org>
 <20230329103943.GAZCQVb1n3tKlGOAWI@fat_crate.local>
 <20230329161450.GDZCRj+rz9lTEZFNBz@fat_crate.local>
 <f033acad-593c-a741-8f4f-a9962eb8aab9@unsolicited.net>
 <e8fd7cdf-b6a5-1c7d-bd08-0d60a1c10495@amd.com>
 <eaa97a25-27b2-187c-1db2-9c56e35d3463@unsolicited.net>
 <b65c4f1f-4990-f7ce-e4c0-85912d187eaf@amd.com>
 <a0ca1e4e-891c-273d-e2d8-eeb9fc4d0c77@unsolicited.net>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <a0ca1e4e-891c-273d-e2d8-eeb9fc4d0c77@unsolicited.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RU9BaWF2a2dhdXNkNExyTTNZWTZadXR2eFZFY2Vkb0UrV1puQm43MkNpOFBj?=
 =?utf-8?B?TEFKUVBKMVpZbS9RblM1THg2RnFsb1hSSW1CRlhrUFRhaWhqV0c4ZHBkRnBS?=
 =?utf-8?B?UkJZbDlvN1VITkttNkh4RDZob0l6UGVOZEI2cW9aVDJZMEVhL0wwM2RHbnB2?=
 =?utf-8?B?ajQxVHhZTDZTeE5CNFZmV21YNmhVTTJxYXE1R3RYV0Q4WXFaUTRCeTc3VmNm?=
 =?utf-8?B?a3p5TTI0N3dTNG5RcG9tcE9iZ010YTJrY0dQYmVYRmZJZjE4b1BRQjdMdkky?=
 =?utf-8?B?M21WY3IrL21aNDVXVFpzZk1YTVlPTll0Vk1YcWNNUGFRTTlKVnJiOS9nUzlh?=
 =?utf-8?B?VWlGM2E3T0ZQc1haZVpqSHZFRUFHUzlNbUZBZkhyMzdqYzhRN0tzMEhGaDNl?=
 =?utf-8?B?V2VFRTNlRXJoS0Z4T3ppb0JzaUw1dTFzd0srNm1sZkNjVzNTZWV4amlCR2RT?=
 =?utf-8?B?a0lUc3I1b1JiRVlCbFNKam5CTU5odGlIeWc5UUt1SmZ2cVpkK25SZHdGZ1RP?=
 =?utf-8?B?YnBoU1ZlSldIQ2M0L1ROTU4rcXMwZ3oxUC9LM3Jxcy9HTGFabVNWT2EzSFRF?=
 =?utf-8?B?TDJtdWNlOG1vUGJkTnUwM1lnak1TdjYyWnpIVEg0b2NZN1ViWUtkYmJKT0Z0?=
 =?utf-8?B?UDJPQUdPYU5scS9iZHNqMkV5OWRqU0R2TnUwRTBya3hDeW1qYlhnblFGYU1a?=
 =?utf-8?B?YUUvVFBhMzlkNVVMblYwYkFuNTVHNUNRTlRtY2IxaytaeXkzYTBwYlB6cXhr?=
 =?utf-8?B?bkNFaWk2Um94NElScEduWi9WeFQzTTEzU3JmOHFKYmdYSFNqTzFFK0xCZ0sr?=
 =?utf-8?B?K2dWODU4bldsVUNVbDZpN3BQbVpxVk93NnlZaEhZWE11WkJmNDFaRDZ4bTdG?=
 =?utf-8?B?dmJLSCttaFlCUm9ZaUtPTE4ySERHcDlWUVRBUkdFQW5jcUppMHVJSnJIVVcw?=
 =?utf-8?B?bXVQSGdtQUlKSE52OXFpV2dGb2o5SlJVU1JmS1dDYkJpY2lTQzE5M1ZkYURG?=
 =?utf-8?B?VjRXUEtYZXFaUFFKamFEYmxQeUo2SC9yY1RsZjBYbDFQL2ZsTTFjVzBTL2Q0?=
 =?utf-8?B?bi94R01DWkRlbWl3d0RDTU91MCtITXJQNlRWdVJOM01EWUxwa2kwSGhVRTFi?=
 =?utf-8?B?cWhNSjViaEZ3ZmpPUWp3bGlKdXFBeUpNMDFBRi9vVU5oTUhpZ0JYK0ZRc1c2?=
 =?utf-8?B?anp3MTM1T0ZpV2VnS2J6N3NkOE9tSlVMeFUwbTRpL2lpQ2pzSE82Mjh4MUlo?=
 =?utf-8?B?QnFidS9mSE5vYkh2WjZqWHZaLzRpZDZCbVlPd3RCc3AxNWdGNWN6V1JCdElD?=
 =?utf-8?B?RWYyRk5qd0lHcEExNXNxKy82TXZocFBGQ2ZmSjAzQjg1ZlowRXJWWUhmT09H?=
 =?utf-8?B?SlNGa0ZmYmtKSFRkcjI0VUVvVUQybjBXRXROeHRPYmMyTkNBNFpYRGVXUGVH?=
 =?utf-8?B?cUEzUlluN2Q5cmpQaDgySmVDRE5lVmRhSHlweDNCVU13ZUlBa3AvYWRYYURa?=
 =?utf-8?B?YWxoQjJHSjNDM29tYXNQRDhkaERXQW5HVTl3bGFpRDRITndOOXQ1Mmxpc1du?=
 =?utf-8?B?S1dBYXYrVWxqS3BMVGhWYVZJN3A0MnRwcUFjdnNGRit4cXpMYnJ4bWtFeExw?=
 =?utf-8?B?dW5LblFuM2tRRmxWaGdsNUxtY3gzOUgxL0NSZEh5VjhWUlFlZ1lKK2t1ODlh?=
 =?utf-8?B?YkRiUUhlZUk2cGZsM1NDVFJ4NSs5NlN4VE4vR1NhOFhrMDVBTkQ0ZnhPMmQ4?=
 =?utf-8?B?MXdUVUZXMEs5dkx3SVk4VWs2MEhlZkdkL1BPdytGdG9wZ0NaQUFwQ0VZQjZB?=
 =?utf-8?B?MG1QNkRHcWdTRnFrY0MxTFgzbWZrSHk3aWlTeVE5cUdQYlFLYXRPbTA1TlVh?=
 =?utf-8?B?SnBUVmhKamsyeCtkUHlpbktBQ20zTFFqVmwybnNqbXFzMHI0QkpwdVZEbkk5?=
 =?utf-8?B?YmhZSEdTSlJSY1VqeGh5Vy81cUV0TUJRTzIwQnJ0NXoyYnM0K3lwa0FFZmFB?=
 =?utf-8?B?cE5hQjFCLy9XQ3FqN29NeFA5REdZczRUbWFQS0hhcnRZWW96QUhORVhNWUhM?=
 =?utf-8?B?RGNQdkdQQjM0RVVmd0xPUVdHVFNjV1BQcHZJdG9IY01rMnJCVEZNWFhnblVp?=
 =?utf-8?Q?zQ1QUVL5jI9ydw719XO1PoTDm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 169fc501-3555-4214-e103-08db308a3173
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 19:17:09.7999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 30zx5QNobkstiISTNXQV8SY9PI/FNe5E4awwIut1UHEQpVuH7DTuDODgiGV6sTutRObslpSwUr03cREGhJv8Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7658
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/29/2023 14:14, David R wrote:
> On 29/03/2023 20:07, Limonciello, Mario wrote:
>> On 3/29/2023 14:03, David R wrote:
>>>
>>>> Can you guys have a try with this patch to see if it helps the 
>>>> situation?
>>>>
>>>> https://lore.kernel.org/linux-pm/20230329174536.6931-1-mario.limonciello@amd.com/T/#u
>>>>
>>>> Thanks,
>>>
>>> Your patch on top of 6.2.8 brought the crash back I'm afraid.
>>>
>>> Cheers
>>> David
>>
>> Humm.  In that case I'm a bit worried there is some conflicting 
>> patches that caused this result.  Could you try with both
>>
>> e2869bd7af60 and aa06e20f1be6 reverted?  If that also fails, I think a 
>> more complicated bisect removing those commits is needed.
> 
> I note that 6.2.8 still has:
> 
> static bool __init acpi_is_processor_usable(u32 lapic_flags)
> {
>          if (lapic_flags & ACPI_MADT_ENABLED)
>                  return true;
> 
>          if (acpi_support_online_capable && (lapic_flags & 
> ACPI_MADT_ONLINE_CAPABLE))
>                  return true;
> 
>          return false;
> }
> 
> The flag getting set to false won't help unless the patch I tried 
> previously is applied ?
> 
> diff 
> <https://lore.kernel.org/all/20230327191026.3454-2-eric.devolder@oracle.com/#iZ31arch:x86:kernel:acpi:boot.c> --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 1c38174b5f01..7b5b8ed018b0 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -193,7 +193,13 @@ static bool __init acpi_is_processor_usable(u32 lapic_flags)   	if (lapic_flags & ACPI_MADT_ENABLED)
>   		return true;
>   
> - if (acpi_support_online_capable && (lapic_flags & 
> ACPI_MADT_ONLINE_CAPABLE)) + /* + * Prior to MADT.revision 5, the 
> presence of the Local x2/APIC + * structure _implicitly_ noted a 
> possible hotpluggable cpu. + * Starting with MADT.revision 5, the Online 
> Capable bit + * _explicitly_ indicates a hotpluggable cpu. + */ + if 
> (!acpi_support_online_capable || (lapic_flags & ACPI_MADT_ONLINE_CAPABLE))   		return true;
>   
>   	return false;
> -- 
> 

You mean specifically this change:
https://lore.kernel.org/all/20230327191026.3454-2-eric.devolder@oracle.com/

Yes; I suppose that still makes sense.