Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1138872rwl; Wed, 29 Mar 2023 13:17:39 -0700 (PDT) X-Google-Smtp-Source: AKy350aB3HlVP57XVC27GjIVEseYEvoWWONOKuu4p3ryI9kMkAMRh5xz4q6UEBgWNifiP50U3K/F X-Received: by 2002:aa7:c54f:0:b0:4fb:7ad6:907a with SMTP id s15-20020aa7c54f000000b004fb7ad6907amr20309381edr.13.1680121058632; Wed, 29 Mar 2023 13:17:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680121058; cv=none; d=google.com; s=arc-20160816; b=Jd5BbxtroqQ3t1ufeyodp9SU4rz26WHhiNCXDsnmk68g5yPcWNaAhJKgC7uEAaFepT A7DQMaSS8ne0u/RyLB6bM8Exag0ZwxtGa25A4IF0iP9LkHPwP6n7+t8z6vfUZ86EqVwq vF+YAjdppOcy4pcRJ5iLg7thX9ZnJTMVy1glwjwoy9P6b2490BfOVEKko53l+mV0O8PP ksk5XAldf49kfq+MoNFRUcmrCfQF2iYon8ksvEzC8+qMrMyTZDaYBVIxGPxsjhvUS4sr 83NPYT7AL+a5F+3vwAgjxfTzorXQwdWCMICtHGJFFTrSMSYHhZcGRumeVaw4YmWg9Q0C pClA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=DdQ/InU+JW6FxMcEa544An9vo1GjuN7pFdS9qPTwzR0=; b=rl5M7A8UKfn+/aP2hsTxEVa/Bm/00GUrXOyZS5Jaj6jS+xXxA6AuQAx5HjC5KyV6C1 pMU+Lt0FgKIiIJKScc88dgh9pRsTl+Q/P9DMyhKrvMwrNNHDy0jEv4vmvJeJ20IJn4in WbVE2fPtEfBQCT4u1n9EuHc2dqBBMvPsbSQFk77Wrm/fZdPldE7vskNgALQhBLshljTl a7ODAQ+30gJm0qh0hAop94e8tGxmPMncpHlpvCmGdsHwiirG3X+xIYNG+gZZ+p3nKOzy GXwOjeImah4fBzQeYmE4qBtW48uHq4UDEWik0uVBIL2AomMVjYhWUnfhi5TncHycpXD9 Z5bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FBi6j/qw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r22-20020aa7d156000000b00502030dd391si18740965edo.46.2023.03.29.13.17.12; Wed, 29 Mar 2023 13:17:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FBi6j/qw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230371AbjC2Tvw (ORCPT + 99 others); Wed, 29 Mar 2023 15:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbjC2Tvr (ORCPT ); Wed, 29 Mar 2023 15:51:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 609947DA0; Wed, 29 Mar 2023 12:51:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F1A97B82435; Wed, 29 Mar 2023 19:50:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A242C433D2; Wed, 29 Mar 2023 19:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680119445; bh=DdQ/InU+JW6FxMcEa544An9vo1GjuN7pFdS9qPTwzR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FBi6j/qw9eZ7S+XE7GyglFFe6nIcEepVGw/DOcSKnd/j6Eb3QlyQfhm366ogCr3qH lYYkW+fqmZskhWF23oz88zeyfcXxvMECpRZI7H1w6HCyVu/uy+ZfeQletZYWD44Fol shTvFUmhzCoHQfD0bjlXxZVwWhVJJBWPHRBCSFH/5lIVlpt5NzaEzsqdVOZrF2E614 1Qn11Ot6C1/KDBrSVTqLu07QFFa7KjVVM4kMUvgZIt++hX+lqrFSZYFiyhVfUgNNfD efRwFGaND95MyeCelC4PyYTjsbka4+J+SGj4ayMKgROGEKMi3EFs4rq/Onk7QDvpKh vpET/yHmUU+wQ== Date: Wed, 29 Mar 2023 21:50:42 +0200 From: Wolfram Sang To: Benjamin Bara Cc: Lee Jones , rafael.j.wysocki@intel.com, dmitry.osipenko@collabora.com, jonathanh@nvidia.com, richard.leitner@linux.dev, treding@nvidia.com, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, Benjamin Bara , stable@vger.kernel.org Subject: Re: [PATCH v3 2/4] i2c: core: run atomic i2c xfer when !preemptible Message-ID: Mail-Followup-To: Wolfram Sang , Benjamin Bara , Lee Jones , rafael.j.wysocki@intel.com, dmitry.osipenko@collabora.com, jonathanh@nvidia.com, richard.leitner@linux.dev, treding@nvidia.com, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, Benjamin Bara , stable@vger.kernel.org References: <20230327-tegra-pmic-reboot-v3-0-3c0ee3567e14@skidata.com> <20230327-tegra-pmic-reboot-v3-2-3c0ee3567e14@skidata.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VVeP+HbfnOeUVDlq" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VVeP+HbfnOeUVDlq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 27, 2023 at 06:23:24PM +0200, Benjamin Bara wrote: > On Mon, 27 Mar 2023 at 16:54, Wolfram Sang wrote: > > For the !CONFIG_PREEMPT_COUNT case, preemptible() is defined 0. So, > > don't we lose the irqs_disabled() check in that case? >=20 > Thanks for the feedback! > PREEMPT_COUNT is selected by PREEMPTION, so I guess in the case of > !PREEMPT_COUNT, > we should be atomic (anyways)? Could you make sure please? Asking Peter Zijlstra might be a good idea. He helped me with the current implementation. --VVeP+HbfnOeUVDlq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmQklpIACgkQFA3kzBSg KbYNNA/+Lc8HqdBhMVtjtKZDd3Km+SqobG8vzuo0octKy5b3E6mK3/y6ZdGssoBs EBZ30DQ1H3dBfNsLFz4Ydy2Dir2SLgcxBKT3IPp6bTzjheXumCjCMTa65N8jmBX2 zX2eu9mVBv5XZAZ1pVzeZVK9EVUU2u/stFuknIg8Cmk+jEgaNCxkKsCnPbnL2l/a lKzps+mfNQWI+Tda5XdBPmLP0gtcHvqQpAJ2SRvDwtf03w+YLY4dJ2jN6IhuwSGO fisy58cwOPwgen46mk3BLPoEftAw9Ss7smkGmQOb8QY6ZWBo1d2KaxOnaY325kI7 oGqqtJP1lWinThlqmEhNfUnqJpDrSySgisyT1NKJ6b60Wr0u9BbM8rkfclpnnzyY QGZW7lfL4EFzKKbMq1GQiMCDn3tN9nR35W9KtqXPM7i3urOHKWQ3/3dFjcv69Tuk QU79XKhnrzEhb43YAhzpfYb8QMB4YdahH78/PhDrwTsfZodqN5yNJeAvx70XiCYp 3J9jrzmwKquFhz/too/2CLjsiJHie9tcwQZthiV/9+NsulXGg4E0Kv9XKKINB4+e condSDcIwRbw0c0T5V5GSHILnNptQywbPoU8npgThFQGsJX4dluRv9+SD4K4hwsf qOPVXjiwt+UIZPyz3qW0dHp+dD4TgwmyuH3rl7HAZyk4Csiu/Vw= =JbH5 -----END PGP SIGNATURE----- --VVeP+HbfnOeUVDlq--